From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Stephen Boyd <stephen.boyd@linaro.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Jisheng Zhang <jszhang@marvell.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 07/34] clk: berlin: Migrate to clk_hw based registration and OF APIs
Date: Tue, 7 Jun 2016 18:33:36 +0200 [thread overview]
Message-ID: <20160607163336.GM3363@piout.net> (raw)
In-Reply-To: <146528884761.28742.8093002152658120585@sboyd-linaro>
On 07/06/2016 at 01:40:47 -0700, Stephen Boyd wrote :
> Quoting Alexandre Belloni (2016-06-05 10:41:57)
> > Hi,
> >
> > The main drawback of those patches is that they break the alignment
> > (checkpatch.pl --strict complains).
>
> Didn't checkpatch --strict already warn on these files though? I'm not
> sure I've done anything to break the alignment style here.
>
As you change the function return value, the function arguments are no
longer aligned with the opening parenthesis.
I would agree that keeping the alignment will make the change quit
bigger though.
> >
> > On 01/06/2016 at 16:15:06 -0700, Stephen Boyd wrote :
> > > diff --git a/drivers/clk/berlin/berlin2-avpll.h b/drivers/clk/berlin/berlin2-avpll.h
> > > index a37f5068d299..17e311153b42 100644
> > > --- a/drivers/clk/berlin/berlin2-avpll.h
> > > +++ b/drivers/clk/berlin/berlin2-avpll.h
> > > @@ -19,17 +19,13 @@
> > > #ifndef __BERLIN2_AVPLL_H
> > > #define __BERLIN2_AVPLL_H
> > >
> > > -struct clk;
> > > -
> > > #define BERLIN2_AVPLL_BIT_QUIRK BIT(0)
> > > #define BERLIN2_AVPLL_SCRAMBLE_QUIRK BIT(1)
> > >
> > > -struct clk * __init
> > > -berlin2_avpll_vco_register(void __iomem *base, const char *name,
> > > +int berlin2_avpll_vco_register(void __iomem *base, const char *name,
> >
> > This is missing __init.
>
> Ah I also removed __init in the header file here because it doesn't do
> anything. I guess I should mention that in the commit text.
Indeed, you are right.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/34] clk: berlin: Migrate to clk_hw based registration and OF APIs
Date: Tue, 7 Jun 2016 18:33:36 +0200 [thread overview]
Message-ID: <20160607163336.GM3363@piout.net> (raw)
In-Reply-To: <146528884761.28742.8093002152658120585@sboyd-linaro>
On 07/06/2016 at 01:40:47 -0700, Stephen Boyd wrote :
> Quoting Alexandre Belloni (2016-06-05 10:41:57)
> > Hi,
> >
> > The main drawback of those patches is that they break the alignment
> > (checkpatch.pl --strict complains).
>
> Didn't checkpatch --strict already warn on these files though? I'm not
> sure I've done anything to break the alignment style here.
>
As you change the function return value, the function arguments are no
longer aligned with the opening parenthesis.
I would agree that keeping the alignment will make the change quit
bigger though.
> >
> > On 01/06/2016 at 16:15:06 -0700, Stephen Boyd wrote :
> > > diff --git a/drivers/clk/berlin/berlin2-avpll.h b/drivers/clk/berlin/berlin2-avpll.h
> > > index a37f5068d299..17e311153b42 100644
> > > --- a/drivers/clk/berlin/berlin2-avpll.h
> > > +++ b/drivers/clk/berlin/berlin2-avpll.h
> > > @@ -19,17 +19,13 @@
> > > #ifndef __BERLIN2_AVPLL_H
> > > #define __BERLIN2_AVPLL_H
> > >
> > > -struct clk;
> > > -
> > > #define BERLIN2_AVPLL_BIT_QUIRK BIT(0)
> > > #define BERLIN2_AVPLL_SCRAMBLE_QUIRK BIT(1)
> > >
> > > -struct clk * __init
> > > -berlin2_avpll_vco_register(void __iomem *base, const char *name,
> > > +int berlin2_avpll_vco_register(void __iomem *base, const char *name,
> >
> > This is missing __init.
>
> Ah I also removed __init in the header file here because it doesn't do
> anything. I guess I should mention that in the commit text.
Indeed, you are right.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-06-07 16:33 UTC|newest]
Thread overview: 172+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 23:14 [PATCH 00/34] Convert clk providers to clk_hw based APIs (part 1) Stephen Boyd
2016-06-01 23:14 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 01/34] clk: qcom: Migrate to clk_hw based registration and OF APIs Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 02/34] clk: at91: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-06-07 16:36 ` Alexandre Belloni
2016-06-07 16:36 ` Alexandre Belloni
2016-06-07 16:40 ` Boris Brezillon
2016-06-07 16:40 ` Boris Brezillon
2016-09-15 0:39 ` Stephen Boyd
2016-09-15 0:39 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 03/34] clk: highbank: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-06-02 1:02 ` Rob Herring
2016-06-02 1:02 ` Rob Herring
2016-06-30 19:25 ` Stephen Boyd
2016-06-30 19:25 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 04/34] clk: bcm2835: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-06-02 18:25 ` Eric Anholt
2016-06-02 18:25 ` Eric Anholt
2016-09-15 0:36 ` Stephen Boyd
2016-09-15 0:36 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 05/34] clk: bcm: iproc: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-06-02 17:22 ` Ray Jui
2016-06-02 17:22 ` Ray Jui
2016-06-30 19:27 ` Stephen Boyd
2016-06-30 19:27 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 06/34] clk: bcm: kona: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-08-24 23:08 ` Stephen Boyd
2016-08-24 23:08 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 07/34] clk: berlin: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-06-05 17:41 ` Alexandre Belloni
2016-06-05 17:41 ` Alexandre Belloni
2016-06-07 8:40 ` Stephen Boyd
2016-06-07 8:40 ` Stephen Boyd
2016-06-07 16:33 ` Alexandre Belloni [this message]
2016-06-07 16:33 ` Alexandre Belloni
2016-06-01 23:15 ` [PATCH 08/34] clk: asm9260: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-08-24 23:09 ` Stephen Boyd
2016-08-24 23:09 ` Stephen Boyd
2016-08-24 23:10 ` Stephen Boyd
2016-08-24 23:10 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 09/34] clk: axi-clkgen: Migrate to clk_hw based OF and registration APIs Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-08-24 23:11 ` Stephen Boyd
2016-08-24 23:11 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 10/34] clk: axm5516: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-08-24 23:12 ` Stephen Boyd
2016-08-24 23:12 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 11/34] clk: cdce: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-08-24 23:13 ` Stephen Boyd
2016-08-24 23:13 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 12/34] clk: cdce925: Migrate to clk_hw based OF and provider APIs Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-08-25 0:19 ` Stephen Boyd
2016-08-25 0:19 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 13/34] clk: clps711x: Migrate to clk_hw based OF and registration APIs Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-08-25 0:20 ` Stephen Boyd
2016-08-25 0:20 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 14/34] clk: cs2000: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-08-25 0:21 ` Stephen Boyd
2016-08-25 0:21 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 15/34] clk: efm32gg: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-08-25 0:22 ` Stephen Boyd
2016-08-25 0:22 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 16/34] clk: ls1x: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-08-19 0:09 ` Stephen Boyd
2016-08-19 0:09 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 17/34] clk: maxgen: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-06-07 18:50 ` Javier Martinez Canillas
2016-06-07 18:50 ` Javier Martinez Canillas
2016-06-07 18:55 ` Javier Martinez Canillas
2016-06-07 18:55 ` Javier Martinez Canillas
2016-08-16 20:06 ` Stephen Boyd
2016-08-16 20:06 ` Stephen Boyd
2016-08-17 3:00 ` Javier Martinez Canillas
2016-08-17 3:00 ` Javier Martinez Canillas
2016-06-01 23:15 ` [PATCH 18/34] clk: mb86s7x: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-08-25 0:27 ` Stephen Boyd
2016-08-25 0:27 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 19/34] clk: moxart: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-08-25 0:25 ` Stephen Boyd
2016-08-25 0:25 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 20/34] clk: nomadik: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-06-02 12:06 ` Linus Walleij
2016-06-02 12:06 ` Linus Walleij
2016-06-30 19:26 ` Stephen Boyd
2016-06-30 19:26 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 21/34] clk: nspire: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-08-25 0:25 ` Stephen Boyd
2016-08-25 0:25 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 22/34] clk: palmas: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-08-25 0:25 ` Stephen Boyd
2016-08-25 0:25 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 23/34] clk: pwm: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-08-25 0:25 ` Stephen Boyd
2016-08-25 0:25 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 24/34] clk: rk808: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-08-25 0:30 ` Stephen Boyd
2016-08-25 0:30 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 25/34] clk: s2mps11: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-06-03 7:18 ` Krzysztof Kozlowski
2016-06-03 7:18 ` Krzysztof Kozlowski
2016-06-08 7:22 ` Andi Shyti
2016-06-08 7:22 ` Andi Shyti
2016-06-30 19:29 ` Stephen Boyd
2016-06-30 19:29 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 26/34] clk: scpi: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-08-25 0:30 ` Stephen Boyd
2016-08-25 0:30 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 27/34] clk: si514: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-08-25 0:30 ` Stephen Boyd
2016-08-25 0:30 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 28/34] clk: si5351: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-08-25 0:30 ` Stephen Boyd
2016-08-25 0:30 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 29/34] clk: si570: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-08-25 0:30 ` Stephen Boyd
2016-08-25 0:30 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 30/34] clk: stm32f3: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-06-06 13:48 ` Daniel Thompson
2016-06-06 13:48 ` Daniel Thompson
2016-06-07 8:37 ` Stephen Boyd
2016-06-07 8:37 ` Stephen Boyd
2016-06-07 8:37 ` Stephen Boyd
2016-06-30 19:28 ` Stephen Boyd
2016-06-30 19:28 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 31/34] clk: twl6040: Migrate to clk_hw based " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-08-25 0:34 ` Stephen Boyd
2016-08-25 0:34 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 32/34] clk: u300: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-06-02 12:06 ` Linus Walleij
2016-06-02 12:06 ` Linus Walleij
2016-06-30 19:26 ` Stephen Boyd
2016-06-30 19:26 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 33/34] clk: vt8500: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-08-25 0:36 ` Stephen Boyd
2016-08-25 0:36 ` Stephen Boyd
2016-06-01 23:15 ` [PATCH 34/34] clk: wm831x: " Stephen Boyd
2016-06-01 23:15 ` Stephen Boyd
2016-08-25 0:36 ` Stephen Boyd
2016-08-25 0:36 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607163336.GM3363@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stephen.boyd@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.