* [PATCH] drm/ast: Remove useless drm_fb_get_bpp_depth() call
@ 2016-06-06 18:14 Laurent Pinchart
2016-06-07 16:49 ` Eric Engestrom
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2016-06-06 18:14 UTC (permalink / raw)
To: dri-devel; +Cc: Dave Airlie
The function has no side effect and its returned values are ignored,
don't call it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/gpu/drm/ast/ast_fb.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
index 5320f8c57884..c017a9330a18 100644
--- a/drivers/gpu/drm/ast/ast_fb.c
+++ b/drivers/gpu/drm/ast/ast_fb.c
@@ -167,12 +167,9 @@ static int astfb_create_object(struct ast_fbdev *afbdev,
struct drm_gem_object **gobj_p)
{
struct drm_device *dev = afbdev->helper.dev;
- u32 bpp, depth;
u32 size;
struct drm_gem_object *gobj;
-
int ret = 0;
- drm_fb_get_bpp_depth(mode_cmd->pixel_format, &depth, &bpp);
size = mode_cmd->pitches[0] * mode_cmd->height;
ret = ast_gem_create(dev, size, true, &gobj);
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/ast: Remove useless drm_fb_get_bpp_depth() call
2016-06-06 18:14 [PATCH] drm/ast: Remove useless drm_fb_get_bpp_depth() call Laurent Pinchart
@ 2016-06-07 16:49 ` Eric Engestrom
2016-06-07 20:17 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Eric Engestrom @ 2016-06-07 16:49 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: Dave Airlie, dri-devel
On Mon, Jun 06, 2016 at 09:14:12PM +0300, Laurent Pinchart wrote:
> The function has no side effect and its returned values are ignored,
> don't call it.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Good catch! Do you have a tool that detects this, or do you just have
a really good eye?
Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
> ---
> drivers/gpu/drm/ast/ast_fb.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
> index 5320f8c57884..c017a9330a18 100644
> --- a/drivers/gpu/drm/ast/ast_fb.c
> +++ b/drivers/gpu/drm/ast/ast_fb.c
> @@ -167,12 +167,9 @@ static int astfb_create_object(struct ast_fbdev *afbdev,
> struct drm_gem_object **gobj_p)
> {
> struct drm_device *dev = afbdev->helper.dev;
> - u32 bpp, depth;
> u32 size;
> struct drm_gem_object *gobj;
> -
> int ret = 0;
> - drm_fb_get_bpp_depth(mode_cmd->pixel_format, &depth, &bpp);
>
> size = mode_cmd->pitches[0] * mode_cmd->height;
> ret = ast_gem_create(dev, size, true, &gobj);
> --
> Regards,
>
> Laurent Pinchart
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/ast: Remove useless drm_fb_get_bpp_depth() call
2016-06-07 16:49 ` Eric Engestrom
@ 2016-06-07 20:17 ` Laurent Pinchart
0 siblings, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2016-06-07 20:17 UTC (permalink / raw)
To: Eric Engestrom; +Cc: Dave Airlie, dri-devel
Hi Eric,
On Tuesday 07 Jun 2016 17:49:20 Eric Engestrom wrote:
> On Mon, Jun 06, 2016 at 09:14:12PM +0300, Laurent Pinchart wrote:
> > The function has no side effect and its returned values are ignored,
> > don't call it.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Good catch! Do you have a tool that detects this, or do you just have
> a really good eye?
I was reviewing the callers of drm_fb_get_bpp_depth() to see if I could get
rid of the function, and realized that two of them didn't need it. A tool
would be nice though :-)
> Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
>
> > ---
> >
> > drivers/gpu/drm/ast/ast_fb.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
> > index 5320f8c57884..c017a9330a18 100644
> > --- a/drivers/gpu/drm/ast/ast_fb.c
> > +++ b/drivers/gpu/drm/ast/ast_fb.c
> > @@ -167,12 +167,9 @@ static int astfb_create_object(struct ast_fbdev
> > *afbdev,>
> > struct drm_gem_object **gobj_p)
> >
> > {
> >
> > struct drm_device *dev = afbdev->helper.dev;
> >
> > - u32 bpp, depth;
> >
> > u32 size;
> > struct drm_gem_object *gobj;
> >
> > -
> >
> > int ret = 0;
> >
> > - drm_fb_get_bpp_depth(mode_cmd->pixel_format, &depth, &bpp);
> >
> > size = mode_cmd->pitches[0] * mode_cmd->height;
> > ret = ast_gem_create(dev, size, true, &gobj);
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-07 20:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-06 18:14 [PATCH] drm/ast: Remove useless drm_fb_get_bpp_depth() call Laurent Pinchart
2016-06-07 16:49 ` Eric Engestrom
2016-06-07 20:17 ` Laurent Pinchart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.