From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: linux-kernel@lists.codethink.co.uk,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: at91: make of_sama5d2_clk_generated_setup() static
Date: Tue, 7 Jun 2016 18:41:39 +0200 [thread overview]
Message-ID: <20160607184139.69411eef@bbrezillon> (raw)
In-Reply-To: <1465317489-14920-1-git-send-email-ben.dooks@codethink.co.uk>
On Tue, 7 Jun 2016 17:38:09 +0100
Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> The of_sama5d2_clk_generated_setup() is not exported outside
> of the driver, so make it static to fix the warning about it
> being not static:
>
> drivers/clk/at91/clk-generated.c:270:13: warning: symbol 'of_sama5d2_clk_generated_setup' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Cc: linux-clk@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> drivers/clk/at91/clk-generated.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/at91/clk-generated.c b/drivers/clk/at91/clk-generated.c
> index e1aa210..7f6bec8 100644
> --- a/drivers/clk/at91/clk-generated.c
> +++ b/drivers/clk/at91/clk-generated.c
> @@ -267,7 +267,7 @@ at91_clk_register_generated(struct regmap *regmap, spinlock_t *lock, const char
> return clk;
> }
>
> -void __init of_sama5d2_clk_generated_setup(struct device_node *np)
> +static void __init of_sama5d2_clk_generated_setup(struct device_node *np)
> {
> int num;
> u32 id;
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: at91: make of_sama5d2_clk_generated_setup() static
Date: Tue, 7 Jun 2016 18:41:39 +0200 [thread overview]
Message-ID: <20160607184139.69411eef@bbrezillon> (raw)
In-Reply-To: <1465317489-14920-1-git-send-email-ben.dooks@codethink.co.uk>
On Tue, 7 Jun 2016 17:38:09 +0100
Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> The of_sama5d2_clk_generated_setup() is not exported outside
> of the driver, so make it static to fix the warning about it
> being not static:
>
> drivers/clk/at91/clk-generated.c:270:13: warning: symbol 'of_sama5d2_clk_generated_setup' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Cc: linux-clk at vger.kernel.org
> Cc: linux-arm-kernel at lists.infradead.org
> ---
> drivers/clk/at91/clk-generated.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/at91/clk-generated.c b/drivers/clk/at91/clk-generated.c
> index e1aa210..7f6bec8 100644
> --- a/drivers/clk/at91/clk-generated.c
> +++ b/drivers/clk/at91/clk-generated.c
> @@ -267,7 +267,7 @@ at91_clk_register_generated(struct regmap *regmap, spinlock_t *lock, const char
> return clk;
> }
>
> -void __init of_sama5d2_clk_generated_setup(struct device_node *np)
> +static void __init of_sama5d2_clk_generated_setup(struct device_node *np)
> {
> int num;
> u32 id;
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-06-07 16:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 16:38 [PATCH] clk: at91: make of_sama5d2_clk_generated_setup() static Ben Dooks
2016-06-07 16:38 ` Ben Dooks
2016-06-07 16:41 ` Boris Brezillon [this message]
2016-06-07 16:41 ` Boris Brezillon
2016-06-21 0:44 ` Stephen Boyd
2016-06-21 0:44 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607184139.69411eef@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=ben.dooks@codethink.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.