From: mnghuan@gmail.com (Minfei Huang)
Subject: [PATCH V2] Use MACRO UINT_MAX instead of actual value
Date: Wed, 8 Jun 2016 10:05:25 +0800 [thread overview]
Message-ID: <20160608020525.GA16012@MinfeideMacBook-Pro.local> (raw)
In-Reply-To: <1463471921-20261-1-git-send-email-mnghuan@gmail.com>
Ping. Any comment is appreciate.
Thanks
Minfei
On 05/17/16@03:58P, Minfei Huang wrote:
> It's more elegant to use MACRO UINT_MAX to represent the max value of
> type unsigned int. So replace the actual value by using this MACRO.
>
> Signed-off-by: Minfei Huang <mnghuan at gmail.com>
> ---
> v1:
> - fix typo
> ---
> drivers/nvme/host/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 643f457..2c0bb13 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -597,7 +597,7 @@ static void nvme_config_discard(struct nvme_ns *ns)
>
> ns->queue->limits.discard_alignment = logical_block_size;
> ns->queue->limits.discard_granularity = logical_block_size;
> - blk_queue_max_discard_sectors(ns->queue, 0xffffffff);
> + blk_queue_max_discard_sectors(ns->queue, UINT_MAX);
> queue_flag_set_unlocked(QUEUE_FLAG_DISCARD, ns->queue);
> }
>
> --
> 2.6.3
>
WARNING: multiple messages have this Message-ID (diff)
From: Minfei Huang <mnghuan@gmail.com>
To: keith.busch@intel.com, axboe@fb.com, gpiccoli@linux.vnet.ibm.com,
sagi@grimberg.me
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] Use MACRO UINT_MAX instead of actual value
Date: Wed, 8 Jun 2016 10:05:25 +0800 [thread overview]
Message-ID: <20160608020525.GA16012@MinfeideMacBook-Pro.local> (raw)
In-Reply-To: <1463471921-20261-1-git-send-email-mnghuan@gmail.com>
Ping. Any comment is appreciate.
Thanks
Minfei
On 05/17/16 at 03:58P, Minfei Huang wrote:
> It's more elegant to use MACRO UINT_MAX to represent the max value of
> type unsigned int. So replace the actual value by using this MACRO.
>
> Signed-off-by: Minfei Huang <mnghuan@gmail.com>
> ---
> v1:
> - fix typo
> ---
> drivers/nvme/host/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 643f457..2c0bb13 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -597,7 +597,7 @@ static void nvme_config_discard(struct nvme_ns *ns)
>
> ns->queue->limits.discard_alignment = logical_block_size;
> ns->queue->limits.discard_granularity = logical_block_size;
> - blk_queue_max_discard_sectors(ns->queue, 0xffffffff);
> + blk_queue_max_discard_sectors(ns->queue, UINT_MAX);
> queue_flag_set_unlocked(QUEUE_FLAG_DISCARD, ns->queue);
> }
>
> --
> 2.6.3
>
next prev parent reply other threads:[~2016-06-08 2:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 7:58 [PATCH V2] Use MACRO UINT_MAX instead of actual value Minfei Huang
2016-05-17 7:58 ` Minfei Huang
2016-06-08 2:05 ` Minfei Huang [this message]
2016-06-08 2:05 ` Minfei Huang
2016-06-08 4:22 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160608020525.GA16012@MinfeideMacBook-Pro.local \
--to=mnghuan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.