From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>,
keith.busch@intel.com, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Ming Lin <ming.l@ssi.samsung.com>
Subject: Re: [PATCH 1/8] blk-mq: add blk_mq_alloc_request_hctx
Date: Wed, 8 Jun 2016 13:54:34 +0200 [thread overview]
Message-ID: <20160608115434.GA30912@lst.de> (raw)
In-Reply-To: <5757A3D2.1030003@kernel.dk>
On Tue, Jun 07, 2016 at 10:49:22PM -0600, Jens Axboe wrote:
> Why are we duplicating this code here? If NOWAIT isn't set, then we'll
> always return a request. bt_get() will run the queue for us, if it needs
> to. blk_mq_alloc_request() does this too, and I'm guessing that code was
> just copied. I'll fix that up. Looks like this should just be:
The generic code is a bit of a mess as it does the nowait optimization
in two different cases, I'll send you a separate cleanup patch for that.
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/8] blk-mq: add blk_mq_alloc_request_hctx
Date: Wed, 8 Jun 2016 13:54:34 +0200 [thread overview]
Message-ID: <20160608115434.GA30912@lst.de> (raw)
In-Reply-To: <5757A3D2.1030003@kernel.dk>
On Tue, Jun 07, 2016@10:49:22PM -0600, Jens Axboe wrote:
> Why are we duplicating this code here? If NOWAIT isn't set, then we'll
> always return a request. bt_get() will run the queue for us, if it needs
> to. blk_mq_alloc_request() does this too, and I'm guessing that code was
> just copied. I'll fix that up. Looks like this should just be:
The generic code is a bit of a mess as it does the nowait optimization
in two different cases, I'll send you a separate cleanup patch for that.
next prev parent reply other threads:[~2016-06-08 11:54 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 21:21 generic NVMe over Fabrics library support Christoph Hellwig
2016-06-06 21:21 ` Christoph Hellwig
2016-06-06 21:21 ` [PATCH 1/8] blk-mq: add blk_mq_alloc_request_hctx Christoph Hellwig
2016-06-06 21:21 ` Christoph Hellwig
2016-06-07 14:57 ` Keith Busch
2016-06-07 14:57 ` Keith Busch
2016-06-07 15:27 ` Ming Lin
2016-06-07 15:27 ` Ming Lin
2016-06-07 23:21 ` Ming Lin
2016-06-07 23:21 ` Ming Lin
2016-06-08 4:49 ` Jens Axboe
2016-06-08 4:49 ` Jens Axboe
2016-06-08 5:20 ` Ming Lin
2016-06-08 5:20 ` Ming Lin
2016-06-08 11:56 ` Christoph Hellwig
2016-06-08 11:56 ` Christoph Hellwig
2016-06-08 11:54 ` Christoph Hellwig [this message]
2016-06-08 11:54 ` Christoph Hellwig
2016-06-06 21:21 ` [PATCH 2/8] nvme: allow transitioning from NEW to LIVE state Christoph Hellwig
2016-06-06 21:21 ` Christoph Hellwig
2016-06-06 21:21 ` [PATCH 3/8] nvme: Modify and export sync command submission for fabrics Christoph Hellwig
2016-06-06 21:21 ` Christoph Hellwig
2016-06-06 21:21 ` [PATCH 4/8] nvme: add fabrics sysfs attributes Christoph Hellwig
2016-06-06 21:21 ` Christoph Hellwig
2016-06-07 8:52 ` Johannes Thumshirn
2016-06-07 8:52 ` Johannes Thumshirn
2016-06-07 8:52 ` Johannes Thumshirn
2016-06-07 10:51 ` Christoph Hellwig
2016-06-07 10:51 ` Christoph Hellwig
2016-06-07 15:21 ` Christoph Hellwig
2016-06-07 15:21 ` Christoph Hellwig
2016-06-06 21:21 ` [PATCH 5/8] nvme.h: add NVMe over Fabrics definitions Christoph Hellwig
2016-06-06 21:21 ` Christoph Hellwig
2016-06-06 21:21 ` [PATCH 6/8] nvme-fabrics: add a generic NVMe over Fabrics library Christoph Hellwig
2016-06-06 21:21 ` Christoph Hellwig
2016-06-06 21:21 ` [PATCH 7/8] nvme.h: Add keep-alive opcode and identify controller attribute Christoph Hellwig
2016-06-06 21:21 ` Christoph Hellwig
2016-06-06 21:21 ` [PATCH 8/8] nvme: add keep-alive support Christoph Hellwig
2016-06-06 21:21 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2016-06-13 14:45 generic NVMe over Fabrics library support V2 Christoph Hellwig
2016-06-13 14:45 ` [PATCH 1/8] blk-mq: add blk_mq_alloc_request_hctx Christoph Hellwig
2016-06-13 14:45 ` Christoph Hellwig
2016-06-13 14:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160608115434.GA30912@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.l@ssi.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.