From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: TS-4800: add CAN support
Date: Thu, 9 Jun 2016 21:30:57 +0800 [thread overview]
Message-ID: <20160609133057.GB19473@tiger> (raw)
In-Reply-To: <1463516190-10606-2-git-send-email-damien.riegel@savoirfairelinux.com>
On Tue, May 17, 2016 at 04:16:30PM -0400, Damien Riegel wrote:
> This enables support for the CAN controller located in the FPGA.
>
> Signed-off-by: Damien Riegel <damien.riegel@savoirfairelinux.com>
> ---
> arch/arm/boot/dts/imx51-ts4800.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx51-ts4800.dts b/arch/arm/boot/dts/imx51-ts4800.dts
> index 2c89988..41be82e 100644
> --- a/arch/arm/boot/dts/imx51-ts4800.dts
> +++ b/arch/arm/boot/dts/imx51-ts4800.dts
> @@ -149,6 +149,16 @@
> #size-cells = <1>;
> ranges = <0 0 0 0x1d000>;
>
> + can at 0,1a000 {
> + compatible = "technologic,sja1000";
> + reg = <0x1a000 0x00000100>;
> + interrupt-parent = <&fpga_irqc>;
> + interrupts = <1>;
> + reg-io-width = <2>;
> + nxp,tx-output-config = <0x06>;
> + nxp,external-clock-frequency = <24000000>;
> + };
> +
For nodes under bus node with unit-address (or 'reg' property), it makes
more sense to sort the nodes in order of unit-address.
Shawn
> fpga_irqc: fpga_irqc at 0,15000 {
> compatible = "technologic,ts4800-irqc";
> reg = <0x15000 0x1000>;
> --
> 2.5.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Damien Riegel <damien.riegel@savoirfairelinux.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Mark Rutland <mark.rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Russell King <linux@armlinux.org.uk>,
Rob Herring <robh+dt@kernel.org>,
kernel@savoirfairelinux.com, Sascha Hauer <kernel@pengutronix.de>,
Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH 2/2] ARM: dts: TS-4800: add CAN support
Date: Thu, 9 Jun 2016 21:30:57 +0800 [thread overview]
Message-ID: <20160609133057.GB19473@tiger> (raw)
In-Reply-To: <1463516190-10606-2-git-send-email-damien.riegel@savoirfairelinux.com>
On Tue, May 17, 2016 at 04:16:30PM -0400, Damien Riegel wrote:
> This enables support for the CAN controller located in the FPGA.
>
> Signed-off-by: Damien Riegel <damien.riegel@savoirfairelinux.com>
> ---
> arch/arm/boot/dts/imx51-ts4800.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx51-ts4800.dts b/arch/arm/boot/dts/imx51-ts4800.dts
> index 2c89988..41be82e 100644
> --- a/arch/arm/boot/dts/imx51-ts4800.dts
> +++ b/arch/arm/boot/dts/imx51-ts4800.dts
> @@ -149,6 +149,16 @@
> #size-cells = <1>;
> ranges = <0 0 0 0x1d000>;
>
> + can@0,1a000 {
> + compatible = "technologic,sja1000";
> + reg = <0x1a000 0x00000100>;
> + interrupt-parent = <&fpga_irqc>;
> + interrupts = <1>;
> + reg-io-width = <2>;
> + nxp,tx-output-config = <0x06>;
> + nxp,external-clock-frequency = <24000000>;
> + };
> +
For nodes under bus node with unit-address (or 'reg' property), it makes
more sense to sort the nodes in order of unit-address.
Shawn
> fpga_irqc: fpga_irqc@0,15000 {
> compatible = "technologic,ts4800-irqc";
> reg = <0x15000 0x1000>;
> --
> 2.5.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2016-06-09 13:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 20:16 [PATCH 1/2] ARM: dts: TS-4800: add FPGA's IRQ controller support Damien Riegel
2016-05-17 20:16 ` Damien Riegel
2016-05-17 20:16 ` [PATCH 2/2] ARM: dts: TS-4800: add CAN support Damien Riegel
2016-05-17 20:16 ` Damien Riegel
2016-05-17 20:16 ` Damien Riegel
2016-06-09 13:30 ` Shawn Guo [this message]
2016-06-09 13:30 ` Shawn Guo
2016-06-09 13:25 ` [PATCH 1/2] ARM: dts: TS-4800: add FPGA's IRQ controller support Shawn Guo
2016-06-09 13:25 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160609133057.GB19473@tiger \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.