From: Christoph Hellwig <hch@lst.de>
To: Ming Lin <mlin@kernel.org>
Cc: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>,
James Smart <james.smart@broadcom.com>
Subject: Re: [PATCH 0/2] check the number of hw queues mapped to sw queues
Date: Thu, 9 Jun 2016 16:09:09 +0200 [thread overview]
Message-ID: <20160609140909.GA30293@lst.de> (raw)
In-Reply-To: <1465415292-9416-1-git-send-email-mlin@kernel.org>
On Wed, Jun 08, 2016 at 03:48:10PM -0400, Ming Lin wrote:
> It adds check code to blk_mq_update_queue_map().
> But it seems too aggresive because it's not an error that some hw queues
> were not mapped to sw queues.
>
> So this series just add a new function blk_mq_hctx_mapped() to check
> how many hw queues were mapped. And the driver(for example, nvme-rdma)
> that cares about it will do the check.
I think it would be better to have this number available a structure
field. Any reason not to update nr_hw_queues in the tag set
with the actual number of queues?
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 0/2] check the number of hw queues mapped to sw queues
Date: Thu, 9 Jun 2016 16:09:09 +0200 [thread overview]
Message-ID: <20160609140909.GA30293@lst.de> (raw)
In-Reply-To: <1465415292-9416-1-git-send-email-mlin@kernel.org>
On Wed, Jun 08, 2016@03:48:10PM -0400, Ming Lin wrote:
> It adds check code to blk_mq_update_queue_map().
> But it seems too aggresive because it's not an error that some hw queues
> were not mapped to sw queues.
>
> So this series just add a new function blk_mq_hctx_mapped() to check
> how many hw queues were mapped. And the driver(for example, nvme-rdma)
> that cares about it will do the check.
I think it would be better to have this number available a structure
field. Any reason not to update nr_hw_queues in the tag set
with the actual number of queues?
next prev parent reply other threads:[~2016-06-09 14:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 19:48 [PATCH 0/2] check the number of hw queues mapped to sw queues Ming Lin
2016-06-08 19:48 ` Ming Lin
2016-06-08 19:48 ` [PATCH 1/2] blk-mq: add a function to return number of hw queues mapped Ming Lin
2016-06-08 19:48 ` Ming Lin
2016-06-08 19:48 ` [PATCH 2/2] nvme-rdma: check the " Ming Lin
2016-06-08 19:48 ` Ming Lin
2016-06-09 11:19 ` Sagi Grimberg
2016-06-09 11:19 ` Sagi Grimberg
2016-06-09 14:10 ` Christoph Hellwig
2016-06-09 14:10 ` Christoph Hellwig
2016-06-09 19:47 ` Ming Lin
2016-06-09 19:47 ` Ming Lin
2016-06-08 22:25 ` [PATCH 0/2] check the number of hw queues mapped to sw queues Keith Busch
2016-06-08 22:25 ` Keith Busch
2016-06-08 22:47 ` Ming Lin
2016-06-08 22:47 ` Ming Lin
2016-06-08 23:05 ` Keith Busch
2016-06-08 23:05 ` Keith Busch
2016-06-09 14:09 ` Christoph Hellwig [this message]
2016-06-09 14:09 ` Christoph Hellwig
2016-06-09 19:43 ` Ming Lin
2016-06-09 19:43 ` Ming Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160609140909.GA30293@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=james.smart@broadcom.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mlin@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.