From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: orion: remove unreferenced board-d2net.c
Date: Thu, 9 Jun 2016 18:36:08 +0200 [thread overview]
Message-ID: <20160609163608.GA23507@lunn.ch> (raw)
In-Reply-To: <d521ce93-f647-0c6f-89f5-aeffd82b87e1@codethink.co.uk>
On Thu, Jun 09, 2016 at 04:52:35PM +0100, Ben Dooks wrote:
> On 09/06/16 15:12, Thomas Petazzoni wrote:
> > Hello,
> >
> > On Thu, 9 Jun 2016 16:10:06 +0200, Andrew Lunn wrote:
> >
> >>> That being said, this has been broken more than 2 years ago, and nobody
> >>> noticed. Doesn't this mean that we could get rid of the support for
> >>> this board entirely? :)
> >>
> >> Well, all it means is the LEDs don't blink. If the disk was not
> >> spinning, or the ethernet device missing, i would agree with you. But
> >> somebody could be using this device and don't notice the difference
> >> with the LEDs.
>
> Surely DT can manage blinking LEDs??
There is an additional GPIO needed. However, i think a pin hog should
allow this to be represented in DT. Two years ago, i don't think this
sort of hogging existed.
Andrew
next prev parent reply other threads:[~2016-06-09 16:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 10:04 [PATCH] ARM: orion: remove unreferenced board-d2net.c Ben Dooks
2016-06-09 13:31 ` Andrew Lunn
2016-06-09 13:39 ` Thomas Petazzoni
2016-06-09 14:10 ` Andrew Lunn
2016-06-09 14:12 ` Thomas Petazzoni
2016-06-09 15:52 ` Ben Dooks
2016-06-09 16:36 ` Andrew Lunn [this message]
2016-06-10 12:49 ` Simon Guinot
2016-07-27 14:42 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160609163608.GA23507@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.