From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: orion: remove unreferenced board-d2net.c
Date: Wed, 27 Jul 2016 16:42:41 +0200 [thread overview]
Message-ID: <87invrnnvi.fsf@free-electrons.com> (raw)
In-Reply-To: <20160609153935.44323b8e@free-electrons.com> (Thomas Petazzoni's message of "Thu, 9 Jun 2016 15:39:35 +0200")
Hi Thomas,
On jeu., juin 09 2016, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Thu, 9 Jun 2016 15:31:16 +0200, Andrew Lunn wrote:
>> On Thu, Jun 09, 2016 at 11:04:16AM +0100, Ben Dooks wrote:
>> > Either this has been mis-converted (and needs to be fixed) or
>> > is no longer referenced and can be safely removed.
>>
>> Hi Thomas
>>
>> You added this code, which Ben is removing. It does look like you
>> forgot to call d2net_init() from orion5x_dt_init().
>>
>> Please could you look at this.
>
> You are correct: d2net_init() should be called from orion5x_dt_init(),
> or called through some initcall mechanism.
So should we apply the patch as is or wait for the needed fix for this
board?
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2016-07-27 14:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 10:04 [PATCH] ARM: orion: remove unreferenced board-d2net.c Ben Dooks
2016-06-09 13:31 ` Andrew Lunn
2016-06-09 13:39 ` Thomas Petazzoni
2016-06-09 14:10 ` Andrew Lunn
2016-06-09 14:12 ` Thomas Petazzoni
2016-06-09 15:52 ` Ben Dooks
2016-06-09 16:36 ` Andrew Lunn
2016-06-10 12:49 ` Simon Guinot
2016-07-27 14:42 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87invrnnvi.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.