From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Andrea Venturi
<ennesimamail.av-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Code Kipper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
gianfranco-25KmuZRQ+wx0ubjbjo6WXg@public.gmane.org
Subject: Re: [PATCH 2/4] ASoC: sunxi: Add Allwinner A10 Digital Audio driver
Date: Fri, 10 Jun 2016 09:36:43 +0200 [thread overview]
Message-ID: <20160610073643.GK5242@lukather> (raw)
In-Reply-To: <20160610003755.GC7510-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 857 bytes --]
Hi Mark,
On Fri, Jun 10, 2016 at 01:37:55AM +0100, Mark Brown wrote:
> > > > +static int sun4i_i2s_dai_probe(struct snd_soc_dai *dai)
> > > > +{
> > > > + struct sun4i_i2s *i2s = snd_soc_dai_get_drvdata(dai);
>
> > > > + /* Enable the whole hardware block */
> > > > + regmap_write(i2s->regmap, SUN4I_I2S_CTRL_REG,
> > > > + SUN4I_I2S_CTRL_GL_EN);
>
> > > Runtime PM? It also seems like this is something that ought to be
> > > covered in the suspend and resume callbacks.
>
> > runtime_pm is supported, and uses the regmap cache to keep those
> > changes.
>
> No, my point is that I'd expect to see the block powered off on suspend.
It is. The bus clock is disabled, which also puts the IP in reset.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ASoC: sunxi: Add Allwinner A10 Digital Audio driver
Date: Fri, 10 Jun 2016 09:36:43 +0200 [thread overview]
Message-ID: <20160610073643.GK5242@lukather> (raw)
In-Reply-To: <20160610003755.GC7510@sirena.org.uk>
Hi Mark,
On Fri, Jun 10, 2016 at 01:37:55AM +0100, Mark Brown wrote:
> > > > +static int sun4i_i2s_dai_probe(struct snd_soc_dai *dai)
> > > > +{
> > > > + struct sun4i_i2s *i2s = snd_soc_dai_get_drvdata(dai);
>
> > > > + /* Enable the whole hardware block */
> > > > + regmap_write(i2s->regmap, SUN4I_I2S_CTRL_REG,
> > > > + SUN4I_I2S_CTRL_GL_EN);
>
> > > Runtime PM? It also seems like this is something that ought to be
> > > covered in the suspend and resume callbacks.
>
> > runtime_pm is supported, and uses the regmap cache to keep those
> > changes.
>
> No, my point is that I'd expect to see the block powered off on suspend.
It is. The bus clock is disabled, which also puts the IP in reset.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160610/9fe2b624/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Liam Girdwood <lgirdwood@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Andrea Venturi <ennesimamail.av@gmail.com>,
Code Kipper <codekipper@gmail.com>,
gianfranco@moddevices.com
Subject: Re: [PATCH 2/4] ASoC: sunxi: Add Allwinner A10 Digital Audio driver
Date: Fri, 10 Jun 2016 09:36:43 +0200 [thread overview]
Message-ID: <20160610073643.GK5242@lukather> (raw)
In-Reply-To: <20160610003755.GC7510@sirena.org.uk>
[-- Attachment #1: Type: text/plain, Size: 857 bytes --]
Hi Mark,
On Fri, Jun 10, 2016 at 01:37:55AM +0100, Mark Brown wrote:
> > > > +static int sun4i_i2s_dai_probe(struct snd_soc_dai *dai)
> > > > +{
> > > > + struct sun4i_i2s *i2s = snd_soc_dai_get_drvdata(dai);
>
> > > > + /* Enable the whole hardware block */
> > > > + regmap_write(i2s->regmap, SUN4I_I2S_CTRL_REG,
> > > > + SUN4I_I2S_CTRL_GL_EN);
>
> > > Runtime PM? It also seems like this is something that ought to be
> > > covered in the suspend and resume callbacks.
>
> > runtime_pm is supported, and uses the regmap cache to keep those
> > changes.
>
> No, my point is that I'd expect to see the block powered off on suspend.
It is. The bus clock is disabled, which also puts the IP in reset.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-10 7:36 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 17:54 [PATCH 0/4] ASoC: sunxi: Add i2s controller support Maxime Ripard
2016-06-01 17:54 ` Maxime Ripard
2016-06-01 17:54 ` [PATCH 1/4] dt-bindings: Add A10 I2S controller binding documentation Maxime Ripard
2016-06-01 17:54 ` Maxime Ripard
[not found] ` <20160601175430.11625-2-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-06-02 10:09 ` Mark Brown
2016-06-02 10:09 ` Mark Brown
2016-06-02 10:09 ` Mark Brown
2016-06-06 13:08 ` Rob Herring
2016-06-06 13:08 ` Rob Herring
2016-06-09 17:15 ` Maxime Ripard
2016-06-09 17:15 ` Maxime Ripard
2016-06-09 17:15 ` Maxime Ripard
2016-06-01 17:54 ` [PATCH 2/4] ASoC: sunxi: Add Allwinner A10 Digital Audio driver Maxime Ripard
2016-06-01 17:54 ` Maxime Ripard
2016-06-02 8:03 ` Code Kipper
2016-06-02 8:03 ` Code Kipper
2016-06-09 21:06 ` Maxime Ripard
2016-06-09 21:06 ` Maxime Ripard
2016-06-09 21:06 ` Maxime Ripard
2016-06-02 10:26 ` Mark Brown
2016-06-02 10:26 ` Mark Brown
2016-06-09 21:05 ` Maxime Ripard
2016-06-09 21:05 ` Maxime Ripard
2016-06-09 21:05 ` Maxime Ripard
2016-06-10 0:37 ` Mark Brown
2016-06-10 0:37 ` Mark Brown
2016-06-10 0:37 ` Mark Brown
[not found] ` <20160610003755.GC7510-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-06-10 7:36 ` Maxime Ripard [this message]
2016-06-10 7:36 ` Maxime Ripard
2016-06-10 7:36 ` Maxime Ripard
2016-06-01 17:54 ` [PATCH 3/4] ARM: sun7i: Add mod1 clock nodes Maxime Ripard
2016-06-01 17:54 ` Maxime Ripard
2016-06-01 17:54 ` [PATCH 4/4] ARM: sun7i: Add DAI nodes Maxime Ripard
2016-06-01 17:54 ` Maxime Ripard
2016-06-01 17:54 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160610073643.GK5242@lukather \
--to=maxime.ripard-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ennesimamail.av-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=gianfranco-25KmuZRQ+wx0ubjbjo6WXg@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.