From: Rob Herring <robh@kernel.org>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org,
Richard Weinberger <richard@nod.at>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH 1/3] mtd: nand: Add an option to maximize the ECC strength
Date: Fri, 10 Jun 2016 09:04:41 -0500 [thread overview]
Message-ID: <20160610140441.GA4743@rob-hp-laptop> (raw)
In-Reply-To: <1465398264-8202-2-git-send-email-boris.brezillon@free-electrons.com>
On Wed, Jun 08, 2016 at 05:04:22PM +0200, Boris Brezillon wrote:
> The generic NAND DT bindings allows one to tweak the ECC strength and
> step size to their need. It can be used to lower the ECC strength to
> match a bootloader/firmware config, but might also be used to get a better
> reliability.
>
> In the latter case, the user might want to use the maximum ECC strength
> without having to explicitly calculate the exact value (this value not
> only depends on the OOB size, but also on the NAND controller, and can
> be tricky to extract).
>
> Add a generic 'nand-ecc-maximize' DT property and the associated
> NAND_ECC_MAXIMIZE flag, to let ECC controller drivers select the best
> ECC strength and step-size on their own.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> Documentation/devicetree/bindings/mtd/nand.txt | 9 +++++++++
Acked-by: Rob Herring <robh@kernel.org>
> drivers/mtd/nand/nand_base.c | 3 +++
> include/linux/mtd/nand.h | 1 +
> 3 files changed, 13 insertions(+)
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Boris Brezillon
<boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Brian Norris
<computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RESEND PATCH 1/3] mtd: nand: Add an option to maximize the ECC strength
Date: Fri, 10 Jun 2016 09:04:41 -0500 [thread overview]
Message-ID: <20160610140441.GA4743@rob-hp-laptop> (raw)
In-Reply-To: <1465398264-8202-2-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
On Wed, Jun 08, 2016 at 05:04:22PM +0200, Boris Brezillon wrote:
> The generic NAND DT bindings allows one to tweak the ECC strength and
> step size to their need. It can be used to lower the ECC strength to
> match a bootloader/firmware config, but might also be used to get a better
> reliability.
>
> In the latter case, the user might want to use the maximum ECC strength
> without having to explicitly calculate the exact value (this value not
> only depends on the OOB size, but also on the NAND controller, and can
> be tricky to extract).
>
> Add a generic 'nand-ecc-maximize' DT property and the associated
> NAND_ECC_MAXIMIZE flag, to let ECC controller drivers select the best
> ECC strength and step-size on their own.
>
> Signed-off-by: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> ---
> Documentation/devicetree/bindings/mtd/nand.txt | 9 +++++++++
Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> drivers/mtd/nand/nand_base.c | 3 +++
> include/linux/mtd/nand.h | 1 +
> 3 files changed, 13 insertions(+)
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-06-10 14:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 15:04 [RESEND PATCH 0/3] mtd: nand: standardize ECC maximization Boris Brezillon
2016-06-08 15:04 ` Boris Brezillon
2016-06-08 15:04 ` [RESEND PATCH 1/3] mtd: nand: Add an option to maximize the ECC strength Boris Brezillon
2016-06-10 14:04 ` Rob Herring [this message]
2016-06-10 14:04 ` Rob Herring
2016-06-08 15:04 ` [RESEND PATCH 2/3] mtd: nand: Support maximizing ECC when using software BCH Boris Brezillon
2016-06-08 15:04 ` Boris Brezillon
2016-06-08 15:04 ` [RESEND PATCH 3/3] mtd: nand: sunxi: Support ECC maximization Boris Brezillon
2016-06-08 15:04 ` Boris Brezillon
2016-09-16 13:08 ` [RESEND PATCH 0/3] mtd: nand: standardize " Boris Brezillon
2016-09-16 13:08 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160610140441.GA4743@rob-hp-laptop \
--to=robh@kernel.org \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.