All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Ben Dooks <ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
Cc: linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO@public.gmane.org,
	Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	Alexandre Courbot
	<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ARM: tegra: fix missing include <soc/tegra/cpuidle.h>
Date: Fri, 10 Jun 2016 16:22:10 +0200	[thread overview]
Message-ID: <20160610142210.GN27142@ulmo.ba.sec> (raw)
In-Reply-To: <1465404897-16654-1-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]

On Wed, Jun 08, 2016 at 05:54:57PM +0100, Ben Dooks wrote:
> The prototype of tegra_cpuidle_pcie_irqs_in_use() is missing
> from the cpuidle.c file, it is defined in <soc/tegra/cpuidle.h>
> so add that include to avoid the following warning:
> 
> arch/arm/mach-tegra/cpuidle.c:51:6: warning: symbol 'tegra_cpuidle_pcie_irqs_in_use' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
> ---
> Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
> Cc: Alexandre Courbot <gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Cc: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> ---
>  arch/arm/mach-tegra/cpuidle.c | 1 +
>  1 file changed, 1 insertion(+)

I've been carrying a set of patches to fix these, and a couple of other
sparse warnings, in my tree locally, but never sent them out because
they were so trivial. I probably should've to avoid the duplication of
effort. Sorry about that.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: fix missing include <soc/tegra/cpuidle.h>
Date: Fri, 10 Jun 2016 16:22:10 +0200	[thread overview]
Message-ID: <20160610142210.GN27142@ulmo.ba.sec> (raw)
In-Reply-To: <1465404897-16654-1-git-send-email-ben.dooks@codethink.co.uk>

On Wed, Jun 08, 2016 at 05:54:57PM +0100, Ben Dooks wrote:
> The prototype of tegra_cpuidle_pcie_irqs_in_use() is missing
> from the cpuidle.c file, it is defined in <soc/tegra/cpuidle.h>
> so add that include to avoid the following warning:
> 
> arch/arm/mach-tegra/cpuidle.c:51:6: warning: symbol 'tegra_cpuidle_pcie_irqs_in_use' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-tegra at vger.kernel.org
> ---
>  arch/arm/mach-tegra/cpuidle.c | 1 +
>  1 file changed, 1 insertion(+)

I've been carrying a set of patches to fix these, and a couple of other
sparse warnings, in my tree locally, but never sent them out because
they were so trivial. I probably should've to avoid the duplication of
effort. Sorry about that.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160610/ffcc37ab/attachment.sig>

  parent reply	other threads:[~2016-06-10 14:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-08 16:54 [PATCH] ARM: tegra: fix missing include <soc/tegra/cpuidle.h> Ben Dooks
2016-06-08 16:54 ` Ben Dooks
     [not found] ` <1465404897-16654-1-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2016-06-10 14:22   ` Thierry Reding [this message]
2016-06-10 14:22     ` Thierry Reding
     [not found]     ` <20160610142210.GN27142-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org>
2016-06-10 14:33       ` Jon Hunter
2016-06-10 14:33         ` Jon Hunter
     [not found]         ` <575ACFB5.4070706-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-06-10 14:55           ` Thierry Reding
2016-06-10 14:55             ` Thierry Reding
     [not found]             ` <20160610145520.GP27142-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org>
2016-06-10 15:07               ` Jon Hunter
2016-06-10 15:07                 ` Jon Hunter
2016-06-10 15:02           ` Ben Dooks
2016-06-10 15:02             ` Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160610142210.GN27142@ulmo.ba.sec \
    --to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org \
    --cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.