All of lore.kernel.org
 help / color / mirror / Atom feed
From: b-liu@ti.com (Bin Liu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] USB: Fix of_usb_get_dr_mode_by_phy with a shared phy block
Date: Fri, 10 Jun 2016 10:00:14 -0500	[thread overview]
Message-ID: <20160610150014.GF2167@uda0271908> (raw)
In-Reply-To: <1465551985-3332-1-git-send-email-hdegoede@redhat.com>

Hi,

On Fri, Jun 10, 2016 at 11:46:25AM +0200, Hans de Goede wrote:
> Some SoCs have a single phy-hw-block with multiple phys, this is
> modelled by a single phy dts node, so we end up with multiple
> controller nodes with a phys property pointing to the phy-node
> of the otg-phy.
> 
> Only one of these controllers typically is an otg controller, yet we
> were checking the first controller who uses a phy from the block and
> then end up looking for a dr_mode property in e.g. the ehci controller.
> 
> This commit fixes this by adding an arg0 parameter to
> of_usb_get_dr_mode_by_phy and make of_usb_get_dr_mode_by_phy
> check that this matches the phandle args[0] value when looking for
> the otg controller.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Changes in v2:
> -Add a arg0 parameter instead of looking for nodes with a dr_mode property
> Changes in v3:
> -No changes
> Changes in v4:
> -When arg0 == -1, use of_parse_phandle instead of of_parse_phandle_with_args
>  because using of_parse_phandle_with_args breaks phy's which use the usb-phy
>  bindings instead of the generic phy bindings

I would think you'd better send this patch with --in-reply-to to the
patch in v3, so whoever picks it can easily pick the whole patch set,
especially in this case the set touches multiple modules, and you don't
want to resend the other patches.

Regards,
-Bin.

WARNING: multiple messages have this Message-ID (diff)
From: Bin Liu <b-liu-l0cyMroinI0@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>,
	Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v4] USB: Fix of_usb_get_dr_mode_by_phy with a shared phy block
Date: Fri, 10 Jun 2016 10:00:14 -0500	[thread overview]
Message-ID: <20160610150014.GF2167@uda0271908> (raw)
In-Reply-To: <1465551985-3332-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Hi,

On Fri, Jun 10, 2016 at 11:46:25AM +0200, Hans de Goede wrote:
> Some SoCs have a single phy-hw-block with multiple phys, this is
> modelled by a single phy dts node, so we end up with multiple
> controller nodes with a phys property pointing to the phy-node
> of the otg-phy.
> 
> Only one of these controllers typically is an otg controller, yet we
> were checking the first controller who uses a phy from the block and
> then end up looking for a dr_mode property in e.g. the ehci controller.
> 
> This commit fixes this by adding an arg0 parameter to
> of_usb_get_dr_mode_by_phy and make of_usb_get_dr_mode_by_phy
> check that this matches the phandle args[0] value when looking for
> the otg controller.
> 
> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
> Changes in v2:
> -Add a arg0 parameter instead of looking for nodes with a dr_mode property
> Changes in v3:
> -No changes
> Changes in v4:
> -When arg0 == -1, use of_parse_phandle instead of of_parse_phandle_with_args
>  because using of_parse_phandle_with_args breaks phy's which use the usb-phy
>  bindings instead of the generic phy bindings

I would think you'd better send this patch with --in-reply-to to the
patch in v3, so whoever picks it can easily pick the whole patch set,
especially in this case the set touches multiple modules, and you don't
want to resend the other patches.

Regards,
-Bin.

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-06-10 15:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-10  9:46 [PATCH v4] USB: Fix of_usb_get_dr_mode_by_phy with a shared phy block Hans de Goede
2016-06-10  9:46 ` Hans de Goede
2016-06-10 15:00 ` Bin Liu [this message]
2016-06-10 15:00   ` Bin Liu
2016-06-10 18:27   ` Hans de Goede
2016-06-10 18:27     ` Hans de Goede
2016-06-10 18:34     ` Bin Liu
2016-06-10 18:34       ` Bin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160610150014.GF2167@uda0271908 \
    --to=b-liu@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.