From: Will Deacon <will.deacon@arm.com>
To: jroedel@suse.de
Cc: iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org,
Jean-Philippe Brucker <jean-philippe.brucker@arm.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] iommu/arm-smmu: wire up map_sg for arm-smmu-v3
Date: Fri, 10 Jun 2016 16:53:35 +0100 [thread overview]
Message-ID: <20160610155335.GC16476@arm.com> (raw)
In-Reply-To: <1464951030-14044-1-git-send-email-will.deacon@arm.com>
Hi Joerg,
On Fri, Jun 03, 2016 at 11:50:30AM +0100, Will Deacon wrote:
> From: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
>
> The map_sg callback is missing from arm_smmu_ops, but is required by
> iommu.h. Similarly to most other IOMMU drivers, connect it to
> default_iommu_map_sg.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
> ---
>
> Joerg -- this is the only fix I have queued, so could you pick it up
> directly, please?
Could you queue this as a fix for 4.7, please?
Will
> drivers/iommu/arm-smmu-v3.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c
> index 94b68213c50d..5f6b3bcab078 100644
> --- a/drivers/iommu/arm-smmu-v3.c
> +++ b/drivers/iommu/arm-smmu-v3.c
> @@ -1941,6 +1941,7 @@ static struct iommu_ops arm_smmu_ops = {
> .attach_dev = arm_smmu_attach_dev,
> .map = arm_smmu_map,
> .unmap = arm_smmu_unmap,
> + .map_sg = default_iommu_map_sg,
> .iova_to_phys = arm_smmu_iova_to_phys,
> .add_device = arm_smmu_add_device,
> .remove_device = arm_smmu_remove_device,
> --
> 2.1.4
>
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] iommu/arm-smmu: wire up map_sg for arm-smmu-v3
Date: Fri, 10 Jun 2016 16:53:35 +0100 [thread overview]
Message-ID: <20160610155335.GC16476@arm.com> (raw)
In-Reply-To: <1464951030-14044-1-git-send-email-will.deacon@arm.com>
Hi Joerg,
On Fri, Jun 03, 2016 at 11:50:30AM +0100, Will Deacon wrote:
> From: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
>
> The map_sg callback is missing from arm_smmu_ops, but is required by
> iommu.h. Similarly to most other IOMMU drivers, connect it to
> default_iommu_map_sg.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
> ---
>
> Joerg -- this is the only fix I have queued, so could you pick it up
> directly, please?
Could you queue this as a fix for 4.7, please?
Will
> drivers/iommu/arm-smmu-v3.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c
> index 94b68213c50d..5f6b3bcab078 100644
> --- a/drivers/iommu/arm-smmu-v3.c
> +++ b/drivers/iommu/arm-smmu-v3.c
> @@ -1941,6 +1941,7 @@ static struct iommu_ops arm_smmu_ops = {
> .attach_dev = arm_smmu_attach_dev,
> .map = arm_smmu_map,
> .unmap = arm_smmu_unmap,
> + .map_sg = default_iommu_map_sg,
> .iova_to_phys = arm_smmu_iova_to_phys,
> .add_device = arm_smmu_add_device,
> .remove_device = arm_smmu_remove_device,
> --
> 2.1.4
>
next prev parent reply other threads:[~2016-06-10 15:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 10:50 [PATCH] iommu/arm-smmu: wire up map_sg for arm-smmu-v3 Will Deacon
2016-06-03 10:50 ` Will Deacon
2016-06-03 10:50 ` Will Deacon
2016-06-10 15:53 ` Will Deacon [this message]
2016-06-10 15:53 ` Will Deacon
2016-06-13 9:01 ` Joerg Roedel
2016-06-13 9:01 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160610155335.GC16476@arm.com \
--to=will.deacon@arm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe.brucker@arm.com \
--cc=jroedel@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.