From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] configure: Rename CONFIG_QGA_NTDDDISK into CONFIG_QGA_NTDDSCSI
Date: Fri, 10 Jun 2016 12:47:40 -0500 [thread overview]
Message-ID: <20160610174740.665.66463@loki> (raw)
In-Reply-To: <1465572354-3083-1-git-send-email-thuth@redhat.com>
Quoting Thomas Huth (2016-06-10 10:25:54)
> There is no CONFIG_QGA_NTDDDISK define used anywhere in the QEMU
> sources. Looking at the changelog and qga/commands-win32.c, it
> seems like this should be called CONFIG_QGA_NTDDSCSI instead.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Yikes, this does appear to be the case. Need to recheck the original
functionality since apparently it's been disabled ever since I added
this patch to the original series, but can take this in through my
tree.
Cc'ing qemu-stable
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 8c2f90b..55019d6 100755
> --- a/configure
> +++ b/configure
> @@ -4965,7 +4965,7 @@ if test "$mingw32" = "yes" ; then
> echo "WIN_SDK=\"$win_sdk\"" >> $config_host_mak
> fi
> if test "$guest_agent_ntddscsi" = "yes" ; then
> - echo "CONFIG_QGA_NTDDDISK=y" >> $config_host_mak
> + echo "CONFIG_QGA_NTDDSCSI=y" >> $config_host_mak
> fi
> if test "$guest_agent_msi" = "yes"; then
> echo "QEMU_GA_MSI_ENABLED=yes" >> $config_host_mak
> --
> 1.8.3.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: Rename CONFIG_QGA_NTDDDISK into CONFIG_QGA_NTDDSCSI
Date: Fri, 10 Jun 2016 12:47:40 -0500 [thread overview]
Message-ID: <20160610174740.665.66463@loki> (raw)
In-Reply-To: <1465572354-3083-1-git-send-email-thuth@redhat.com>
Quoting Thomas Huth (2016-06-10 10:25:54)
> There is no CONFIG_QGA_NTDDDISK define used anywhere in the QEMU
> sources. Looking at the changelog and qga/commands-win32.c, it
> seems like this should be called CONFIG_QGA_NTDDSCSI instead.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Yikes, this does appear to be the case. Need to recheck the original
functionality since apparently it's been disabled ever since I added
this patch to the original series, but can take this in through my
tree.
Cc'ing qemu-stable
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 8c2f90b..55019d6 100755
> --- a/configure
> +++ b/configure
> @@ -4965,7 +4965,7 @@ if test "$mingw32" = "yes" ; then
> echo "WIN_SDK=\"$win_sdk\"" >> $config_host_mak
> fi
> if test "$guest_agent_ntddscsi" = "yes" ; then
> - echo "CONFIG_QGA_NTDDDISK=y" >> $config_host_mak
> + echo "CONFIG_QGA_NTDDSCSI=y" >> $config_host_mak
> fi
> if test "$guest_agent_msi" = "yes"; then
> echo "QEMU_GA_MSI_ENABLED=yes" >> $config_host_mak
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2016-06-10 17:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 15:25 [Qemu-trivial] [PATCH] configure: Rename CONFIG_QGA_NTDDDISK into CONFIG_QGA_NTDDSCSI Thomas Huth
2016-06-10 15:25 ` [Qemu-devel] " Thomas Huth
2016-06-10 17:47 ` Michael Roth [this message]
2016-06-10 17:47 ` Michael Roth
2016-06-30 19:04 ` [Qemu-trivial] " Michael Roth
2016-06-30 19:04 ` [Qemu-devel] " Michael Roth
2016-07-21 23:19 ` [Qemu-trivial] " Michael Roth
2016-07-21 23:19 ` [Qemu-devel] " Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160610174740.665.66463@loki \
--to=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.