From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: dts: BCM5310x: Enable switch ports on SmartRG SR400AC
Date: Fri, 10 Jun 2016 21:32:59 +0200 [thread overview]
Message-ID: <20160610193259.GI2338@lunn.ch> (raw)
In-Reply-To: <1465583756-26740-4-git-send-email-f.fainelli@gmail.com>
On Fri, Jun 10, 2016 at 11:35:56AM -0700, Florian Fainelli wrote:
> Define the port mapping for the SmartRG SR400ACE device.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts | 40 +++++++++++++++++++++++++++
> 1 file changed, 40 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts
> index 8b0c440b2e71..c219d33496cc 100644
> --- a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts
> +++ b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts
> @@ -126,3 +126,43 @@
> &spi_nor {
> status = "okay";
> };
> +
> +&srab {
> + status = "okay";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + switch0port0: port at 0 {
Hi Florian
You don't need the labels, since you don't have any phandles pointing
at them.
Other than that, great to see a board using the new switch driver.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org,
zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
nbd-Vt+b4OUoWG0@public.gmane.org
Subject: Re: [PATCH 3/3] ARM: dts: BCM5310x: Enable switch ports on SmartRG SR400AC
Date: Fri, 10 Jun 2016 21:32:59 +0200 [thread overview]
Message-ID: <20160610193259.GI2338@lunn.ch> (raw)
In-Reply-To: <1465583756-26740-4-git-send-email-f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Fri, Jun 10, 2016 at 11:35:56AM -0700, Florian Fainelli wrote:
> Define the port mapping for the SmartRG SR400ACE device.
>
> Signed-off-by: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts | 40 +++++++++++++++++++++++++++
> 1 file changed, 40 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts
> index 8b0c440b2e71..c219d33496cc 100644
> --- a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts
> +++ b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts
> @@ -126,3 +126,43 @@
> &spi_nor {
> status = "okay";
> };
> +
> +&srab {
> + status = "okay";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + switch0port0: port@0 {
Hi Florian
You don't need the labels, since you don't have any phandles pointing
at them.
Other than that, great to see a board using the new switch driver.
Reviewed-by: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-06-10 19:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 18:35 [PATCH 0/3] ARM: dts: BCM5310x switch support Florian Fainelli
2016-06-10 18:35 ` Florian Fainelli
2016-06-10 18:35 ` [PATCH 1/3] ARM: dts: Enable SRAB switch and GMACs on 5301x DTS Florian Fainelli
2016-06-10 18:35 ` Florian Fainelli
2016-06-10 18:35 ` [PATCH 2/3] ARM: dts: BCM5301X: Add SRAB interrupts Florian Fainelli
2016-06-10 18:35 ` Florian Fainelli
2016-06-10 18:35 ` [PATCH 3/3] ARM: dts: BCM5310x: Enable switch ports on SmartRG SR400AC Florian Fainelli
2016-06-10 18:35 ` Florian Fainelli
2016-06-10 19:32 ` Andrew Lunn [this message]
2016-06-10 19:32 ` Andrew Lunn
2016-06-13 19:46 ` [PATCH 0/3] ARM: dts: BCM5310x switch support Florian Fainelli
2016-06-13 19:46 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160610193259.GI2338@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.