From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: dts: sun4i: The blue led on the Mele A1000 is a power led
Date: Sat, 11 Jun 2016 17:45:33 +0200 [thread overview]
Message-ID: <20160611154533.GE19854@lukather> (raw)
In-Reply-To: <0acb666e-3fa7-fb10-4c0d-1d7990f9eaa6@redhat.com>
On Wed, Jun 08, 2016 at 03:23:31PM +0200, Hans de Goede wrote:
> Hi,
>
> On 07-06-16 23:24, Maxime Ripard wrote:
> >On Sun, Jun 05, 2016 at 02:23:11PM +0200, Hans de Goede wrote:
> >>The blue led on the Mele A1000 is wired to light up as soon as the board
> >>has powered (it will be on while the gpio is still in input / floating
> >>mode), also its location on the top-set box clearly signals "power led".
> >>
> >>Until now we've been treating this as a generic usr function led, which
> >>means that when you plug power into the top-set box, the power-led lights
> >>and then turns off as soon as the kernel loads, which looks wrong.
> >
> >I'm not sure I understand the relationship between usr vs pwr led and
> >the fact that it's disabled.
>
> There is no relation, other then that pwr leds typically have
> default-state = "on"; set whereas usr leds do not.
>
> >>This renames the led from a1000:blue:usr to a1000:blue:pwr and marks
> >>it as default on, fixing this.
> >
> >however, the default on might. Is it just a confusing commit log, or
> >am I overlooking something?
>
> Just a slightly confusing commit log.
Ok, applied all three.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160611/1fed2eb6/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/3] ARM: dts: sun4i: The blue led on the Mele A1000 is a power led
Date: Sat, 11 Jun 2016 17:45:33 +0200 [thread overview]
Message-ID: <20160611154533.GE19854@lukather> (raw)
In-Reply-To: <0acb666e-3fa7-fb10-4c0d-1d7990f9eaa6-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1304 bytes --]
On Wed, Jun 08, 2016 at 03:23:31PM +0200, Hans de Goede wrote:
> Hi,
>
> On 07-06-16 23:24, Maxime Ripard wrote:
> >On Sun, Jun 05, 2016 at 02:23:11PM +0200, Hans de Goede wrote:
> >>The blue led on the Mele A1000 is wired to light up as soon as the board
> >>has powered (it will be on while the gpio is still in input / floating
> >>mode), also its location on the top-set box clearly signals "power led".
> >>
> >>Until now we've been treating this as a generic usr function led, which
> >>means that when you plug power into the top-set box, the power-led lights
> >>and then turns off as soon as the kernel loads, which looks wrong.
> >
> >I'm not sure I understand the relationship between usr vs pwr led and
> >the fact that it's disabled.
>
> There is no relation, other then that pwr leds typically have
> default-state = "on"; set whereas usr leds do not.
>
> >>This renames the led from a1000:blue:usr to a1000:blue:pwr and marks
> >>it as default on, fixing this.
> >
> >however, the default on might. Is it just a confusing commit log, or
> >am I overlooking something?
>
> Just a slightly confusing commit log.
Ok, applied all three.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-11 15:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-05 12:23 [PATCH 1/3] ARM: dts: sun4i: The blue led on the Mele A1000 is a power led Hans de Goede
2016-06-05 12:23 ` Hans de Goede
2016-06-05 12:23 ` [PATCH 2/3] ARM: dts: sun6i: The blue led on the Mele A1000G quad " Hans de Goede
2016-06-05 12:23 ` Hans de Goede
2016-06-06 7:01 ` Chen-Yu Tsai
2016-06-06 7:01 ` Chen-Yu Tsai
2016-06-05 12:23 ` [PATCH 3/3] ARM: dts: sun6i: The blue led on the Mele M9 " Hans de Goede
2016-06-05 12:23 ` Hans de Goede
2016-06-06 7:02 ` Chen-Yu Tsai
2016-06-06 7:02 ` Chen-Yu Tsai
2016-06-06 7:01 ` [PATCH 1/3] ARM: dts: sun4i: The blue led on the Mele A1000 " Chen-Yu Tsai
2016-06-06 7:01 ` Chen-Yu Tsai
2016-06-06 7:05 ` Chen-Yu Tsai
2016-06-06 7:05 ` Chen-Yu Tsai
2016-06-06 7:24 ` Hans de Goede
2016-06-06 7:24 ` Hans de Goede
2016-06-07 21:24 ` Maxime Ripard
2016-06-07 21:24 ` Maxime Ripard
2016-06-08 13:23 ` Hans de Goede
2016-06-08 13:23 ` Hans de Goede
2016-06-11 15:45 ` Maxime Ripard [this message]
2016-06-11 15:45 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160611154533.GE19854@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.