* [PATCH] dmaengine: vdma: Fix compilation warning in cyclic dma mode
@ 2016-06-09 6:02 ` Kedareswara rao Appana
0 siblings, 0 replies; 6+ messages in thread
From: Kedareswara rao Appana @ 2016-06-09 6:02 UTC (permalink / raw)
To: linux-arm-kernel
This patch fixes the below compilation warining.
drivers/dma/xilinx/xilinx_vdma.c: In function 'xilinx_dma_prep_dma_cyclic':
drivers/dma/xilinx/xilinx_vdma.c:1808:23: warning: 'segment' may be used
uninitialized in this function [-Wmaybe-uninitialized]
segment->hw.control |= XILINX_DMA_BD_SOP;
The start of packet (SOP) should be set to the first segment in the desc
chain not for the last segment of the desc chain.
Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com>
---
drivers/dma/xilinx/xilinx_vdma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/xilinx/xilinx_vdma.c b/drivers/dma/xilinx/xilinx_vdma.c
index cbcf595..20fe5ea 100644
--- a/drivers/dma/xilinx/xilinx_vdma.c
+++ b/drivers/dma/xilinx/xilinx_vdma.c
@@ -1840,7 +1840,7 @@ static struct dma_async_tx_descriptor *xilinx_dma_prep_dma_cyclic(
/* For the last DMA_MEM_TO_DEV transfer, set EOP */
if (direction == DMA_MEM_TO_DEV) {
- segment->hw.control |= XILINX_DMA_BD_SOP;
+ head_segment->hw.control |= XILINX_DMA_BD_SOP;
segment = list_last_entry(&desc->segments,
struct xilinx_axidma_tx_segment,
node);
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] dmaengine: vdma: Fix compilation warning in cyclic dma mode
@ 2016-06-09 6:02 ` Kedareswara rao Appana
0 siblings, 0 replies; 6+ messages in thread
From: Kedareswara rao Appana @ 2016-06-09 6:02 UTC (permalink / raw)
To: dan.j.williams, vinod.koul, michal.simek, soren.brinkmann,
appanad, moritz.fischer, laurent.pinchart, luis, sfr
Cc: dmaengine, linux-arm-kernel, linux-kernel
This patch fixes the below compilation warining.
drivers/dma/xilinx/xilinx_vdma.c: In function 'xilinx_dma_prep_dma_cyclic':
drivers/dma/xilinx/xilinx_vdma.c:1808:23: warning: 'segment' may be used
uninitialized in this function [-Wmaybe-uninitialized]
segment->hw.control |= XILINX_DMA_BD_SOP;
The start of packet (SOP) should be set to the first segment in the desc
chain not for the last segment of the desc chain.
Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com>
---
drivers/dma/xilinx/xilinx_vdma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/xilinx/xilinx_vdma.c b/drivers/dma/xilinx/xilinx_vdma.c
index cbcf595..20fe5ea 100644
--- a/drivers/dma/xilinx/xilinx_vdma.c
+++ b/drivers/dma/xilinx/xilinx_vdma.c
@@ -1840,7 +1840,7 @@ static struct dma_async_tx_descriptor *xilinx_dma_prep_dma_cyclic(
/* For the last DMA_MEM_TO_DEV transfer, set EOP */
if (direction == DMA_MEM_TO_DEV) {
- segment->hw.control |= XILINX_DMA_BD_SOP;
+ head_segment->hw.control |= XILINX_DMA_BD_SOP;
segment = list_last_entry(&desc->segments,
struct xilinx_axidma_tx_segment,
node);
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] dmaengine: vdma: Fix compilation warning in cyclic dma mode
2016-06-09 6:02 ` Kedareswara rao Appana
@ 2016-06-13 5:42 ` Vinod Koul
-1 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2016-06-13 5:42 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jun 09, 2016 at 11:32:12AM +0530, Kedareswara rao Appana wrote:
> This patch fixes the below compilation warining.
> drivers/dma/xilinx/xilinx_vdma.c: In function 'xilinx_dma_prep_dma_cyclic':
> drivers/dma/xilinx/xilinx_vdma.c:1808:23: warning: 'segment' may be used
> uninitialized in this function [-Wmaybe-uninitialized]
> segment->hw.control |= XILINX_DMA_BD_SOP;
>
> The start of packet (SOP) should be set to the first segment in the desc
> chain not for the last segment of the desc chain.
I have applied this after adding Reported by from SFR.
You should always give credit to folks who report issues.
Thanks
--
~Vinod
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dmaengine: vdma: Fix compilation warning in cyclic dma mode
@ 2016-06-13 5:42 ` Vinod Koul
0 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2016-06-13 5:42 UTC (permalink / raw)
To: Kedareswara rao Appana
Cc: dan.j.williams, michal.simek, soren.brinkmann, appanad,
moritz.fischer, laurent.pinchart, luis, sfr, dmaengine,
linux-arm-kernel, linux-kernel
On Thu, Jun 09, 2016 at 11:32:12AM +0530, Kedareswara rao Appana wrote:
> This patch fixes the below compilation warining.
> drivers/dma/xilinx/xilinx_vdma.c: In function 'xilinx_dma_prep_dma_cyclic':
> drivers/dma/xilinx/xilinx_vdma.c:1808:23: warning: 'segment' may be used
> uninitialized in this function [-Wmaybe-uninitialized]
> segment->hw.control |= XILINX_DMA_BD_SOP;
>
> The start of packet (SOP) should be set to the first segment in the desc
> chain not for the last segment of the desc chain.
I have applied this after adding Reported by from SFR.
You should always give credit to folks who report issues.
Thanks
--
~Vinod
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] dmaengine: vdma: Fix compilation warning in cyclic dma mode
2016-06-13 5:42 ` Vinod Koul
@ 2016-06-13 5:37 ` Appana Durga Kedareswara Rao
-1 siblings, 0 replies; 6+ messages in thread
From: Appana Durga Kedareswara Rao @ 2016-06-13 5:37 UTC (permalink / raw)
To: linux-arm-kernel
Hi Vinod,
> On Thu, Jun 09, 2016 at 11:32:12AM +0530, Kedareswara rao Appana wrote:
> > This patch fixes the below compilation warining.
> > drivers/dma/xilinx/xilinx_vdma.c: In function 'xilinx_dma_prep_dma_cyclic':
> > drivers/dma/xilinx/xilinx_vdma.c:1808:23: warning: 'segment' may be
> > used uninitialized in this function [-Wmaybe-uninitialized]
> > segment->hw.control |= XILINX_DMA_BD_SOP;
> >
> > The start of packet (SOP) should be set to the first segment in the
> > desc chain not for the last segment of the desc chain.
>
> I have applied this after adding Reported by from SFR.
Sorry will fix it next time on wards....
>
> You should always give credit to folks who report issues.
Sure will fix next time onwards...
Thanks,
Kedar.
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] dmaengine: vdma: Fix compilation warning in cyclic dma mode
@ 2016-06-13 5:37 ` Appana Durga Kedareswara Rao
0 siblings, 0 replies; 6+ messages in thread
From: Appana Durga Kedareswara Rao @ 2016-06-13 5:37 UTC (permalink / raw)
To: Vinod Koul
Cc: dan.j.williams@intel.com, Michal Simek, Soren Brinkmann,
moritz.fischer@ettus.com, laurent.pinchart@ideasonboard.com,
luis@debethencourt.com, sfr@canb.auug.org.au,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Hi Vinod,
> On Thu, Jun 09, 2016 at 11:32:12AM +0530, Kedareswara rao Appana wrote:
> > This patch fixes the below compilation warining.
> > drivers/dma/xilinx/xilinx_vdma.c: In function 'xilinx_dma_prep_dma_cyclic':
> > drivers/dma/xilinx/xilinx_vdma.c:1808:23: warning: 'segment' may be
> > used uninitialized in this function [-Wmaybe-uninitialized]
> > segment->hw.control |= XILINX_DMA_BD_SOP;
> >
> > The start of packet (SOP) should be set to the first segment in the
> > desc chain not for the last segment of the desc chain.
>
> I have applied this after adding Reported by from SFR.
Sorry will fix it next time on wards....
>
> You should always give credit to folks who report issues.
Sure will fix next time onwards...
Thanks,
Kedar.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-06-13 5:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-09 6:02 [PATCH] dmaengine: vdma: Fix compilation warning in cyclic dma mode Kedareswara rao Appana
2016-06-09 6:02 ` Kedareswara rao Appana
2016-06-13 5:42 ` Vinod Koul
2016-06-13 5:42 ` Vinod Koul
2016-06-13 5:37 ` Appana Durga Kedareswara Rao
2016-06-13 5:37 ` Appana Durga Kedareswara Rao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.