From: Jesper Dangaard Brouer <brouer@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, Jason Wang <jasowang@redhat.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
davem@davemloft.net, netdev@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
kvm@vger.kernel.org, brouer@redhat.com
Subject: Re: [PATCH v8 4/5] ptr_ring: resize support
Date: Tue, 14 Jun 2016 14:04:28 +0200 [thread overview]
Message-ID: <20160614140428.7fb2bd94@redhat.com> (raw)
In-Reply-To: <20160613235445-mutt-send-email-mst@redhat.com>
On Mon, 13 Jun 2016 23:54:45 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> This adds ring resize support. Seems to be necessary as
> users such as tun allow userspace control over queue size.
>
> If resize is used, this costs us ability to peek at queue without
> consumer lock - should not be a big deal as peek and consumer are
> usually run on the same CPU.
>
> If ring is made bigger, ring contents is preserved. If ring is made
> smaller, extra pointers are passed to an optional destructor callback.
>
> Cleanup function also gains destructor callback such that
> all pointers in queue can be cleaned up.
>
> This changes some APIs but we don't have any users yet,
> so it won't break bisect.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2016-06-14 12:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1465851234-13558-1-git-send-email-mst@redhat.com>
2016-06-13 20:54 ` [PATCH v8 1/5] ptr_ring: array based FIFO for pointers Michael S. Tsirkin
2016-06-14 12:02 ` Jesper Dangaard Brouer
2016-06-13 20:54 ` [PATCH v8 2/5] ptr_ring: ring test Michael S. Tsirkin
2016-06-13 20:54 ` Michael S. Tsirkin
2016-06-13 20:54 ` [PATCH v8 3/5] skb_array: array based FIFO for skbs Michael S. Tsirkin
2016-06-14 12:03 ` Jesper Dangaard Brouer
2016-06-13 20:54 ` [PATCH v8 4/5] ptr_ring: resize support Michael S. Tsirkin
2016-06-14 12:04 ` Jesper Dangaard Brouer [this message]
2016-06-13 20:54 ` [PATCH v8 5/5] skb_array: " Michael S. Tsirkin
2016-06-14 12:21 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160614140428.7fb2bd94@redhat.com \
--to=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.