From: Jesper Dangaard Brouer <brouer@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, Jason Wang <jasowang@redhat.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
davem@davemloft.net, netdev@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
kvm@vger.kernel.org, brouer@redhat.com
Subject: Re: [PATCH v8 5/5] skb_array: resize support
Date: Tue, 14 Jun 2016 14:21:13 +0200 [thread overview]
Message-ID: <20160614142113.1f0391d0@redhat.com> (raw)
In-Reply-To: <20160613235450-mutt-send-email-mst@redhat.com>
On Mon, 13 Jun 2016 23:54:50 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> Update skb_array after ptr_ring API changes.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
Tested-by: Jesper Dangaard Brouer <brouer@redhat.com>
Also did resize unit test:
https://github.com/netoptimizer/prototype-kernel/commit/af0b4d7e7261e9
The parallel benchmark:
https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/lib/skb_array_parallel01.c
Have been adjusted to use the non-BH variant of the lock. And the
parallel benchmark results, where a single producer and a single
consumer CPU runs concurrently, and the queue always partly full
(optimal case for minimize cache-contention):
On CPU i7-4790K @ 4.00GHz:
- Enqueue 32 cycles(tsc) 8.162 ns
- Dequeue 33 cycles(tsc) 8.417 ns
Notice this is an extremely good concurrency results, as it is very
close to the optimal case benchmark 26 cycles, when running
enqueue+dequeue on the same CPU in a tight loop[2].
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
[2] https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/lib/skb_array_bench01.c
prev parent reply other threads:[~2016-06-14 12:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1465851234-13558-1-git-send-email-mst@redhat.com>
2016-06-13 20:54 ` [PATCH v8 1/5] ptr_ring: array based FIFO for pointers Michael S. Tsirkin
2016-06-14 12:02 ` Jesper Dangaard Brouer
2016-06-13 20:54 ` [PATCH v8 2/5] ptr_ring: ring test Michael S. Tsirkin
2016-06-13 20:54 ` Michael S. Tsirkin
2016-06-13 20:54 ` [PATCH v8 3/5] skb_array: array based FIFO for skbs Michael S. Tsirkin
2016-06-14 12:03 ` Jesper Dangaard Brouer
2016-06-13 20:54 ` [PATCH v8 4/5] ptr_ring: resize support Michael S. Tsirkin
2016-06-14 12:04 ` Jesper Dangaard Brouer
2016-06-13 20:54 ` [PATCH v8 5/5] skb_array: " Michael S. Tsirkin
2016-06-14 12:21 ` Jesper Dangaard Brouer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160614142113.1f0391d0@redhat.com \
--to=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.