[meta-oe][PATCH] wvstreams: fixing segfault with new gcc optimizations

[meta-oe][PATCH] wvstreams: fixing segfault with new gcc optimizations

[Ray Kinsella]

Recent GCC optimizations -ftree-dce and -foptimize-sibling-calls are causing
a segfault in the wvstream stackmaster. Fedora had the same problem and
resolved the issue by removing these optimizations.

See: https://bugzilla.redhat.com/show_bug.cgi?id=812651

Signed-off-by: Ray Kinsella <ray.kinsella@intel.com>
---
 meta-oe/recipes-connectivity/wvdial/wvstreams_4.6.1.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta-oe/recipes-connectivity/wvdial/wvstreams_4.6.1.bb b/meta-oe/recipes-connectivity/wvdial/wvstreams_4.6.1.bb
index 73cfb03..6199a2f 100644
--- a/meta-oe/recipes-connectivity/wvdial/wvstreams_4.6.1.bb
+++ b/meta-oe/recipes-connectivity/wvdial/wvstreams_4.6.1.bb
@@ -20,6 +20,8 @@ inherit autotools-brokensep pkgconfig
 
 PARALLEL_MAKE = ""
 
+TARGET_CFLAGS_append = " -fno-tree-dce -fno-optimize-sibling-calls"
+
 LDFLAGS_append = " -Wl,-rpath-link,${CROSS_DIR}/${TARGET_SYS}/lib"
 
 EXTRA_OECONF = " --without-tcl --without-qt --without-pam --without-valgrind"
-- 
1.8.5.6

Re: [meta-oe][PATCH] wvstreams: fixing segfault with new gcc optimizations

[Kinsella, Ray]

Hi Martin,

What should I do to progress this?

Ray K

On 06/05/2016 14:49, Kinsella, Ray wrote:
> Recent GCC optimizations -ftree-dce and -foptimize-sibling-calls are causing
> a segfault in the wvstream stackmaster. Fedora had the same problem and
> resolved the issue by removing these optimizations.
>
> See: https://bugzilla.redhat.com/show_bug.cgi?id=812651
>
> Signed-off-by: Ray Kinsella <ray.kinsella@intel.com>
> ---
>  meta-oe/recipes-connectivity/wvdial/wvstreams_4.6.1.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta-oe/recipes-connectivity/wvdial/wvstreams_4.6.1.bb b/meta-oe/recipes-connectivity/wvdial/wvstreams_4.6.1.bb
> index 73cfb03..6199a2f 100644
> --- a/meta-oe/recipes-connectivity/wvdial/wvstreams_4.6.1.bb
> +++ b/meta-oe/recipes-connectivity/wvdial/wvstreams_4.6.1.bb
> @@ -20,6 +20,8 @@ inherit autotools-brokensep pkgconfig
>
>  PARALLEL_MAKE = ""
>
> +TARGET_CFLAGS_append = " -fno-tree-dce -fno-optimize-sibling-calls"
> +
>  LDFLAGS_append = " -Wl,-rpath-link,${CROSS_DIR}/${TARGET_SYS}/lib"
>
>  EXTRA_OECONF = " --without-tcl --without-qt --without-pam --without-valgrind"
>

Re: [meta-oe][PATCH] wvstreams: fixing segfault with new gcc optimizations

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1666 bytes --]

On Tue, Jun 14, 2016 at 03:26:16PM +0100, Kinsella, Ray wrote:
> Hi Martin,
> 
> What should I do to progress this?

What progress you're expecting? it was merged more than a month ago:

commit 786ab843f0eb825781df5b4c639b6ae5f4c74c41
Author:     Kinsella, Ray <ray.kinsella@intel.com>
AuthorDate: Fri May 6 14:49:19 2016 +0100
Commit:     Martin Jansa <Martin.Jansa@gmail.com>
CommitDate: Tue May 10 20:18:56 2016 +0200

> 
> Ray K
> 
> On 06/05/2016 14:49, Kinsella, Ray wrote:
> > Recent GCC optimizations -ftree-dce and -foptimize-sibling-calls are causing
> > a segfault in the wvstream stackmaster. Fedora had the same problem and
> > resolved the issue by removing these optimizations.
> >
> > See: https://bugzilla.redhat.com/show_bug.cgi?id=812651
> >
> > Signed-off-by: Ray Kinsella <ray.kinsella@intel.com>
> > ---
> >  meta-oe/recipes-connectivity/wvdial/wvstreams_4.6.1.bb | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/meta-oe/recipes-connectivity/wvdial/wvstreams_4.6.1.bb b/meta-oe/recipes-connectivity/wvdial/wvstreams_4.6.1.bb
> > index 73cfb03..6199a2f 100644
> > --- a/meta-oe/recipes-connectivity/wvdial/wvstreams_4.6.1.bb
> > +++ b/meta-oe/recipes-connectivity/wvdial/wvstreams_4.6.1.bb
> > @@ -20,6 +20,8 @@ inherit autotools-brokensep pkgconfig
> >
> >  PARALLEL_MAKE = ""
> >
> > +TARGET_CFLAGS_append = " -fno-tree-dce -fno-optimize-sibling-calls"
> > +
> >  LDFLAGS_append = " -Wl,-rpath-link,${CROSS_DIR}/${TARGET_SYS}/lib"
> >
> >  EXTRA_OECONF = " --without-tcl --without-qt --without-pam --without-valgrind"
> >

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]