* [PATCH] Staging: sm750fb: fix block comment coding style issue in ddk750_chip.c
@ 2016-06-06 19:04 ` Moshe Green
0 siblings, 0 replies; 10+ messages in thread
From: Moshe Green @ 2016-06-06 19:04 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh; +Cc: linux-fbdev, devel, linux-kernel
This is a patch to the ddk750_chip.c file that fixes up two block
comment coding style warnings found by the checkpatch.pl tool
Signed-off-by: Moshe Green <mgmoshes@gmail.com>
---
drivers/staging/sm750fb/ddk750_chip.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index f80ee77..3d408d6 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -91,8 +91,10 @@ static void setMemoryClock(unsigned int frequency)
return;
if (frequency) {
- /* Set the frequency to the maximum frequency that the DDR Memory can take
- which is 336MHz. */
+ /*
+ * Set the frequency to the maximum frequency that the DDR Memory can take
+ * which is 336MHz.
+ */
if (frequency > MHz(336))
frequency = MHz(336);
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] staging: sm750fb: fix block comments errors in ddk750_display.c
@ 2016-06-14 15:38 ` yeongjun Kim
0 siblings, 0 replies; 10+ messages in thread
From: yeongjun Kim @ 2016-06-14 15:38 UTC (permalink / raw)
To: sudipm.mukherjee; +Cc: teddy.wang, gregkh, linux-fbdev, devel, linux-kernel
WARNING: Block comments use * on subsequent lines
WARNING: Block comments use a trailing */ on a separate line
WARNING: Block comments use * on subsequent lines
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: yeongjun Kim <iam.yeongjunkim@gmail.com>
---
drivers/staging/sm750fb/ddk750_display.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_display.c
index ca4973e..a040042 100644
--- a/drivers/staging/sm750fb/ddk750_display.c
+++ b/drivers/staging/sm750fb/ddk750_display.c
@@ -68,8 +68,10 @@ static void waitNextVerticalSync(int ctrl, int delay)
if (!ctrl) {
/* primary controller */
- /* Do not wait when the Primary PLL is off or display control is already off.
- This will prevent the software to wait forever. */
+ /*
+ * Do not wait when the Primary PLL is off or display control is
+ * already off. This will prevent the software to wait forever.
+ */
if (!(PEEK32(PANEL_PLL_CTRL) & PLL_CTRL_POWER) ||
!(PEEK32(PANEL_DISPLAY_CTRL) & DISPLAY_CTRL_TIMING)) {
return;
@@ -88,9 +90,10 @@ static void waitNextVerticalSync(int ctrl, int delay)
}
} else {
-
- /* Do not wait when the Primary PLL is off or display control is already off.
- This will prevent the software to wait forever. */
+ /*
+ * Do not wait when the Primary PLL is off or display control is
+ * already off. This will prevent the software to wait forever.
+ */
if (!(PEEK32(CRT_PLL_CTRL) & PLL_CTRL_POWER) ||
!(PEEK32(CRT_DISPLAY_CTRL) & DISPLAY_CTRL_TIMING)) {
return;
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] staging: sm750fb: fix block comments errors in ddk750_display.c
@ 2016-06-14 15:38 ` yeongjun Kim
0 siblings, 0 replies; 10+ messages in thread
From: yeongjun Kim @ 2016-06-14 15:38 UTC (permalink / raw)
To: sudipm.mukherjee; +Cc: teddy.wang, gregkh, linux-fbdev, devel, linux-kernel
WARNING: Block comments use * on subsequent lines
WARNING: Block comments use a trailing */ on a separate line
WARNING: Block comments use * on subsequent lines
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: yeongjun Kim <iam.yeongjunkim@gmail.com>
---
drivers/staging/sm750fb/ddk750_display.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_display.c
index ca4973e..a040042 100644
--- a/drivers/staging/sm750fb/ddk750_display.c
+++ b/drivers/staging/sm750fb/ddk750_display.c
@@ -68,8 +68,10 @@ static void waitNextVerticalSync(int ctrl, int delay)
if (!ctrl) {
/* primary controller */
- /* Do not wait when the Primary PLL is off or display control is already off.
- This will prevent the software to wait forever. */
+ /*
+ * Do not wait when the Primary PLL is off or display control is
+ * already off. This will prevent the software to wait forever.
+ */
if (!(PEEK32(PANEL_PLL_CTRL) & PLL_CTRL_POWER) ||
!(PEEK32(PANEL_DISPLAY_CTRL) & DISPLAY_CTRL_TIMING)) {
return;
@@ -88,9 +90,10 @@ static void waitNextVerticalSync(int ctrl, int delay)
}
} else {
-
- /* Do not wait when the Primary PLL is off or display control is already off.
- This will prevent the software to wait forever. */
+ /*
+ * Do not wait when the Primary PLL is off or display control is
+ * already off. This will prevent the software to wait forever.
+ */
if (!(PEEK32(CRT_PLL_CTRL) & PLL_CTRL_POWER) ||
!(PEEK32(CRT_DISPLAY_CTRL) & DISPLAY_CTRL_TIMING)) {
return;
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] staging: sm750fb: Fix block comment style
@ 2016-07-23 18:57 ` Edward Lipinsky
0 siblings, 0 replies; 10+ messages in thread
From: Edward Lipinsky @ 2016-07-23 18:57 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh; +Cc: linux-fbdev, devel, linux-kernel
This patch fixes the checkpatch.pl warning:
WARNING: Block comments use * on subsequent lines
Signed-off-by: Edward Lipinsky <ellipinsky@gmail.com>
---
drivers/staging/sm750fb/ddk750_dvi.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
index a4a2550..8252f77 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.c
+++ b/drivers/staging/sm750fb/ddk750_dvi.c
@@ -6,9 +6,11 @@
#include "ddk750_sii164.h"
-/* This global variable contains all the supported driver and its corresponding
- function API. Please set the function pointer to NULL whenever the function
- is not supported. */
+/*
+ * This global variable contains all the supported driver and its corresponding
+ * function API. Please set the function pointer to NULL whenever the function
+ * is not supported.
+ */
static dvi_ctrl_device_t g_dcftSupportedDviController[] = {
#ifdef DVI_CTRL_SII164
{
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] staging: sm750fb: Fix block comment style
@ 2016-07-23 18:57 ` Edward Lipinsky
0 siblings, 0 replies; 10+ messages in thread
From: Edward Lipinsky @ 2016-07-23 18:57 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh; +Cc: linux-fbdev, devel, linux-kernel
This patch fixes the checkpatch.pl warning:
WARNING: Block comments use * on subsequent lines
Signed-off-by: Edward Lipinsky <ellipinsky@gmail.com>
---
drivers/staging/sm750fb/ddk750_dvi.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
index a4a2550..8252f77 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.c
+++ b/drivers/staging/sm750fb/ddk750_dvi.c
@@ -6,9 +6,11 @@
#include "ddk750_sii164.h"
-/* This global variable contains all the supported driver and its corresponding
- function API. Please set the function pointer to NULL whenever the function
- is not supported. */
+/*
+ * This global variable contains all the supported driver and its corresponding
+ * function API. Please set the function pointer to NULL whenever the function
+ * is not supported.
+ */
static dvi_ctrl_device_t g_dcftSupportedDviController[] = {
#ifdef DVI_CTRL_SII164
{
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] Staging: sm750fb: Fix block comments
@ 2016-09-29 10:26 ` Ramiro Oliveira
0 siblings, 0 replies; 10+ messages in thread
From: Ramiro Oliveira @ 2016-09-29 10:26 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, devel,
linux-kernel
Cc: Ramiro Oliveira
Correct the styling of some block comments as reported by checkpatch.
Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com>
---
drivers/staging/sm750fb/ddk750_swi2c.c | 36 +++++++++++++++++-----------------
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c b/drivers/staging/sm750fb/ddk750_swi2c.c
index 6c1ffa1..011c1bd 100644
--- a/drivers/staging/sm750fb/ddk750_swi2c.c
+++ b/drivers/staging/sm750fb/ddk750_swi2c.c
@@ -1,15 +1,15 @@
/*******************************************************************
-*
-* Copyright (c) 2007 by Silicon Motion, Inc. (SMI)
-*
-* All rights are reserved. Reproduction or in part is prohibited
-* without the written consent of the copyright owner.
-*
-* swi2c.c --- SM750/SM718 DDK
-* This file contains the source code for I2C using software
-* implementation.
-*
-*******************************************************************/
+ *
+ * Copyright (c) 2007 by Silicon Motion, Inc. (SMI)
+ *
+ * All rights are reserved. Reproduction or in part is prohibited
+ * without the written consent of the copyright owner.
+ *
+ * swi2c.c --- SM750/SM718 DDK
+ * This file contains the source code for I2C using software
+ * implementation.
+ *
+ *******************************************************************/
#include "ddk750_help.h"
#include "ddk750_reg.h"
#include "ddk750_swi2c.h"
@@ -89,12 +89,12 @@ static void sw_i2c_wait(void)
* always be non-zero,which makes the while loop
* never finish.
* use non-ultimate for loop below is safe
- * */
+ */
- /* Change wait algorithm to use PCI bus clock,
- it's more reliable than counter loop ..
- write 0x61 to 0x3ce and read from 0x3cf
- */
+ /* Change wait algorithm to use PCI bus clock,
+ * it's more reliable than counter loop ..
+ * write 0x61 to 0x3ce and read from 0x3cf
+ */
int i, tmp;
for (i = 0; i < 600; i++) {
@@ -501,8 +501,8 @@ long sm750_sw_i2c_write_reg(
sw_i2c_start();
/* Send the device address and read the data. All should return success
- in order for the writing processed to be successful
- */
+ * in order for the writing processed to be successful
+ */
if ((sw_i2c_write_byte(addr) != 0) ||
(sw_i2c_write_byte(reg) != 0) ||
(sw_i2c_write_byte(data) != 0)) {
--
2.9.3
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] Staging: sm750fb: Fix block comments
@ 2016-09-29 10:26 ` Ramiro Oliveira
0 siblings, 0 replies; 10+ messages in thread
From: Ramiro Oliveira @ 2016-09-29 10:26 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, devel,
linux-kernel
Cc: Ramiro Oliveira
Correct the styling of some block comments as reported by checkpatch.
Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com>
---
drivers/staging/sm750fb/ddk750_swi2c.c | 36 +++++++++++++++++-----------------
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c b/drivers/staging/sm750fb/ddk750_swi2c.c
index 6c1ffa1..011c1bd 100644
--- a/drivers/staging/sm750fb/ddk750_swi2c.c
+++ b/drivers/staging/sm750fb/ddk750_swi2c.c
@@ -1,15 +1,15 @@
/*******************************************************************
-*
-* Copyright (c) 2007 by Silicon Motion, Inc. (SMI)
-*
-* All rights are reserved. Reproduction or in part is prohibited
-* without the written consent of the copyright owner.
-*
-* swi2c.c --- SM750/SM718 DDK
-* This file contains the source code for I2C using software
-* implementation.
-*
-*******************************************************************/
+ *
+ * Copyright (c) 2007 by Silicon Motion, Inc. (SMI)
+ *
+ * All rights are reserved. Reproduction or in part is prohibited
+ * without the written consent of the copyright owner.
+ *
+ * swi2c.c --- SM750/SM718 DDK
+ * This file contains the source code for I2C using software
+ * implementation.
+ *
+ *******************************************************************/
#include "ddk750_help.h"
#include "ddk750_reg.h"
#include "ddk750_swi2c.h"
@@ -89,12 +89,12 @@ static void sw_i2c_wait(void)
* always be non-zero,which makes the while loop
* never finish.
* use non-ultimate for loop below is safe
- * */
+ */
- /* Change wait algorithm to use PCI bus clock,
- it's more reliable than counter loop ..
- write 0x61 to 0x3ce and read from 0x3cf
- */
+ /* Change wait algorithm to use PCI bus clock,
+ * it's more reliable than counter loop ..
+ * write 0x61 to 0x3ce and read from 0x3cf
+ */
int i, tmp;
for (i = 0; i < 600; i++) {
@@ -501,8 +501,8 @@ long sm750_sw_i2c_write_reg(
sw_i2c_start();
/* Send the device address and read the data. All should return success
- in order for the writing processed to be successful
- */
+ * in order for the writing processed to be successful
+ */
if ((sw_i2c_write_byte(addr) != 0) ||
(sw_i2c_write_byte(reg) != 0) ||
(sw_i2c_write_byte(data) != 0)) {
--
2.9.3
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] Staging: sm750fb: Fix block comments
2016-09-29 10:26 ` Ramiro Oliveira
@ 2016-10-02 14:53 ` Greg KH
-1 siblings, 0 replies; 10+ messages in thread
From: Greg KH @ 2016-10-02 14:53 UTC (permalink / raw)
To: Ramiro Oliveira
Cc: sudipm.mukherjee, teddy.wang, linux-fbdev, devel, linux-kernel
On Thu, Sep 29, 2016 at 11:26:31AM +0100, Ramiro Oliveira wrote:
> Correct the styling of some block comments as reported by checkpatch.
>
> Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com>
> ---
> drivers/staging/sm750fb/ddk750_swi2c.c | 36 +++++++++++++++++-----------------
> 1 file changed, 18 insertions(+), 18 deletions(-)
Someone else sent in this same patch before you did, sorry.
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Staging: sm750fb: Fix block comments
@ 2016-10-02 14:53 ` Greg KH
0 siblings, 0 replies; 10+ messages in thread
From: Greg KH @ 2016-10-02 14:53 UTC (permalink / raw)
To: Ramiro Oliveira
Cc: sudipm.mukherjee, teddy.wang, linux-fbdev, devel, linux-kernel
On Thu, Sep 29, 2016 at 11:26:31AM +0100, Ramiro Oliveira wrote:
> Correct the styling of some block comments as reported by checkpatch.
>
> Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com>
> ---
> drivers/staging/sm750fb/ddk750_swi2c.c | 36 +++++++++++++++++-----------------
> 1 file changed, 18 insertions(+), 18 deletions(-)
Someone else sent in this same patch before you did, sorry.
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread