From: Rob Herring <robh@kernel.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Milo Kim <milo.kim@ti.com>, Jingoo Han <jingoohan1@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Stephen Barber <smbarber@chromium.org>,
Doug Anderson <dianders@chromium.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v2] backlight: lp855x: Add enable regulator
Date: Tue, 14 Jun 2016 20:09:36 +0000 [thread overview]
Message-ID: <20160614200936.GA9318@rob-hp-laptop> (raw)
In-Reply-To: <1465587597-131467-1-git-send-email-briannorris@chromium.org>
On Fri, Jun 10, 2016 at 12:39:57PM -0700, Brian Norris wrote:
> The LP8556 datasheet describes an EN/VDDIO input, which serves "both as
> a chip enable and as a power supply reference for PWM, SDA, and SCL
> inputs." The LP8556 that I'm testing doesn't respond properly if I try
> to talk I2C to it too quickly after enabling VDDIO, and the LP8555
> datasheet mentions a t_RESPONSE delay of up to 1 millisecond.
>
> Support this EN/VDDIO by adding a regulator property to the binding;
> enabling this regulator at probe time; and sleeping for 1 to 2ms, if the
> EN/VDDIO regulator was provided.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
> v2: s/TS8555/LP8555/ in comment (typo)
>
> .../devicetree/bindings/leds/backlight/lp855x.txt | 2 ++
I would have picked 'vddio' as the name, but it's fine.
Acked-by: Rob Herring <robh@kernel.org>
> drivers/video/backlight/lp855x_bl.c | 29 ++++++++++++++++++++++
> 2 files changed, 31 insertions(+)
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Milo Kim <milo.kim@ti.com>, Jingoo Han <jingoohan1@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Stephen Barber <smbarber@chromium.org>,
Doug Anderson <dianders@chromium.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v2] backlight: lp855x: Add enable regulator
Date: Tue, 14 Jun 2016 15:09:36 -0500 [thread overview]
Message-ID: <20160614200936.GA9318@rob-hp-laptop> (raw)
In-Reply-To: <1465587597-131467-1-git-send-email-briannorris@chromium.org>
On Fri, Jun 10, 2016 at 12:39:57PM -0700, Brian Norris wrote:
> The LP8556 datasheet describes an EN/VDDIO input, which serves "both as
> a chip enable and as a power supply reference for PWM, SDA, and SCL
> inputs." The LP8556 that I'm testing doesn't respond properly if I try
> to talk I2C to it too quickly after enabling VDDIO, and the LP8555
> datasheet mentions a t_RESPONSE delay of up to 1 millisecond.
>
> Support this EN/VDDIO by adding a regulator property to the binding;
> enabling this regulator at probe time; and sleeping for 1 to 2ms, if the
> EN/VDDIO regulator was provided.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
> v2: s/TS8555/LP8555/ in comment (typo)
>
> .../devicetree/bindings/leds/backlight/lp855x.txt | 2 ++
I would have picked 'vddio' as the name, but it's fine.
Acked-by: Rob Herring <robh@kernel.org>
> drivers/video/backlight/lp855x_bl.c | 29 ++++++++++++++++++++++
> 2 files changed, 31 insertions(+)
next prev parent reply other threads:[~2016-06-14 20:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 19:39 [PATCH v2] backlight: lp855x: Add enable regulator Brian Norris
2016-06-10 19:39 ` Brian Norris
2016-06-10 19:39 ` Brian Norris
[not found] ` <1465587597-131467-1-git-send-email-briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-06-10 23:52 ` Stephen Barber
2016-06-10 23:52 ` Stephen Barber
2016-06-10 23:52 ` Stephen Barber
2016-06-13 1:05 ` Kim, Milo
2016-06-13 1:05 ` Kim, Milo
2016-06-13 1:05 ` Kim, Milo
2016-06-14 20:09 ` Rob Herring [this message]
2016-06-14 20:09 ` Rob Herring
2016-06-15 8:34 ` Lee Jones
2016-06-15 8:34 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160614200936.GA9318@rob-hp-laptop \
--to=robh@kernel.org \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=milo.kim@ti.com \
--cc=plagnioj@jcrosoft.com \
--cc=smbarber@chromium.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.