All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Willy Tarreau <w@1wt.eu>
Cc: Greg KH <greg@kroah.com>,
	xfs@oss.sgi.com, spender@grsecurity.net, stable@vger.kernel.org,
	"Thomas D." <whissi@whissi.de>
Subject: Re: Something badly broken with the latest XFS changeset in all stable kernels?
Date: Wed, 15 Jun 2016 16:51:21 +1000	[thread overview]
Message-ID: <20160615065121.GE26977@dastard> (raw)
In-Reply-To: <20160615052831.GA3452@1wt.eu>

On Wed, Jun 15, 2016 at 07:28:31AM +0200, Willy Tarreau wrote:
> On Tue, Jun 14, 2016 at 06:30:56PM -0700, Greg KH wrote:
> > As the patch was tagged with 3.10+, I assumed that it was safe to be
> > merged to those older kernels, otherwise I would never have done so.  We
> > do have ways to mark external things like this for stable patches, it's
> > a great help when doing backports.
> 
> I guess only 3.14.72 was affected in the end. 3.18.35 has the fix but my
> understanding is that after 3.17 it's OK.

Correct.

> Apparently it's not yet queued
> for 3.16.

The queue for 3.16 has a different bunch of XFS stuff that I've
previous said is pretty risky and not advisable to back port (the
mmaplock stuff). I'm waiting for that to get to users and a new
bunch of whacky problems to be reported...

> Jiri has queued it for 3.12 but not yet released it. For 3.10
> I only pick patches that are already in a 3.14 release so I didn't have
> the time to backport it to 3.10 yet as the preview started before the
> release.

Just lucky, eh?

> Overall the regression lived only 8 days in a single branch, I
> guess it shows that our process works rather well and limits the exposure
> to regressions.

That it got as far as release and it took so long to get to the
upstream maintainers shows the process could do with being improved.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Willy Tarreau <w@1wt.eu>
Cc: Greg KH <greg@kroah.com>, "Thomas D." <whissi@whissi.de>,
	xfs@oss.sgi.com, stable@vger.kernel.org, spender@grsecurity.net
Subject: Re: Something badly broken with the latest XFS changeset in all stable kernels?
Date: Wed, 15 Jun 2016 16:51:21 +1000	[thread overview]
Message-ID: <20160615065121.GE26977@dastard> (raw)
In-Reply-To: <20160615052831.GA3452@1wt.eu>

On Wed, Jun 15, 2016 at 07:28:31AM +0200, Willy Tarreau wrote:
> On Tue, Jun 14, 2016 at 06:30:56PM -0700, Greg KH wrote:
> > As the patch was tagged with 3.10+, I assumed that it was safe to be
> > merged to those older kernels, otherwise I would never have done so.  We
> > do have ways to mark external things like this for stable patches, it's
> > a great help when doing backports.
> 
> I guess only 3.14.72 was affected in the end. 3.18.35 has the fix but my
> understanding is that after 3.17 it's OK.

Correct.

> Apparently it's not yet queued
> for 3.16.

The queue for 3.16 has a different bunch of XFS stuff that I've
previous said is pretty risky and not advisable to back port (the
mmaplock stuff). I'm waiting for that to get to users and a new
bunch of whacky problems to be reported...

> Jiri has queued it for 3.12 but not yet released it. For 3.10
> I only pick patches that are already in a 3.14 release so I didn't have
> the time to backport it to 3.10 yet as the preview started before the
> release.

Just lucky, eh?

> Overall the regression lived only 8 days in a single branch, I
> guess it shows that our process works rather well and limits the exposure
> to regressions.

That it got as far as release and it took so long to get to the
upstream maintainers shows the process could do with being improved.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

  reply	other threads:[~2016-06-15  6:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-13 21:57 Something badly broken with the latest XFS changeset in all stable kernels? Thomas D.
2016-06-15  0:02 ` Dave Chinner
2016-06-15  0:02   ` Dave Chinner
2016-06-15  1:30   ` Greg KH
2016-06-15  1:30     ` Greg KH
2016-06-15  5:28     ` Willy Tarreau
2016-06-15  5:28       ` Willy Tarreau
2016-06-15  6:51       ` Dave Chinner [this message]
2016-06-15  6:51         ` Dave Chinner
2016-06-15  7:14         ` Willy Tarreau
2016-06-15  7:14           ` Willy Tarreau
2016-06-15  7:00       ` Jiri Slaby
2016-06-15  7:00         ` Jiri Slaby
2016-06-15  6:40     ` Dave Chinner
2016-06-15  6:40       ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160615065121.GE26977@dastard \
    --to=david@fromorbit.com \
    --cc=greg@kroah.com \
    --cc=spender@grsecurity.net \
    --cc=stable@vger.kernel.org \
    --cc=w@1wt.eu \
    --cc=whissi@whissi.de \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.