All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Reichel <sre@kernel.org>
To: "Andrew F. Davis" <afd@ti.com>
Cc: kbuild test robot <lkp@intel.com>,
	kbuild-all@01.org, Russell King <linux@armlinux.org.uk>,
	Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Wolfram Sang <wsa@the-dreams.de>,
	Richard Purdie <rpurdie@rpsys.net>,
	Jacek Anaszewski <j.anaszewski@samsung.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Lauro Ramos Venancio <lauro.venancio@openbossa.org>,
	Aloisio Almeida Jr <aloisio.almeida@openbossa.org>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Ingo Molnar <mingo@kernel.org>,
	linux-pwm@vger.kernel.org, lguest@lists.ozlabs.org,
	linux-wireless@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-i2c@vger.kernel.org, linuxppc-dev@lists.ozlab
Subject: Re: [PATCH] hsi: Build hsi_boardinfo.c into hsi core if enabled
Date: Wed, 15 Jun 2016 14:48:42 +0200	[thread overview]
Message-ID: <20160615124842.GA6702@earth> (raw)
In-Reply-To: <57602D10.4080708@ti.com>

[-- Attachment #1: Type: text/plain, Size: 908 bytes --]

Hi Andrew,

On Tue, Jun 14, 2016 at 11:13:04AM -0500, Andrew F. Davis wrote:
> If the HSI core is built as a module hsi_boardinfo may still
> be built-in as its Kconfig type is bool, which can cause build
> issues. Fix this by building this code into the HSI core when
> enabled.
> 
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
> This build error seems to be due to Kconfig symbol CONFIG_HSI_BOARDINFO
> being a bool but depending on a tristate (CONFIG_HSI). This is normally
> okay when it is just a flag to enable a feature in source, but the
> helper code file hsi_boardinfo.c is built as a separate entity when
> enabled. This patch is probably how it was intended, and is more like
> how others do this kind of thing.
> 
> This patch should be applied before the parent patch:

Thanks, I applied both patches.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Reichel <sre@kernel.org>
To: "Andrew F. Davis" <afd@ti.com>
Cc: kbuild test robot <lkp@intel.com>,
	kbuild-all@01.org, Russell King <linux@armlinux.org.uk>,
	Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Wolfram Sang <wsa@the-dreams.de>,
	Richard Purdie <rpurdie@rpsys.net>,
	Jacek Anaszewski <j.anaszewski@samsung.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Lauro Ramos Venancio <lauro.venancio@openbossa.org>,
	Aloisio Almeida Jr <aloisio.almeida@openbossa.org>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Ingo Molnar <mingo@kernel.org>,
	linux-pwm@vger.kernel.org, lguest@lists.ozlabs.org,
	linux-wireless@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-i2c@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-leds@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH] hsi: Build hsi_boardinfo.c into hsi core if enabled
Date: Wed, 15 Jun 2016 14:48:42 +0200	[thread overview]
Message-ID: <20160615124842.GA6702@earth> (raw)
In-Reply-To: <57602D10.4080708@ti.com>

[-- Attachment #1: Type: text/plain, Size: 908 bytes --]

Hi Andrew,

On Tue, Jun 14, 2016 at 11:13:04AM -0500, Andrew F. Davis wrote:
> If the HSI core is built as a module hsi_boardinfo may still
> be built-in as its Kconfig type is bool, which can cause build
> issues. Fix this by building this code into the HSI core when
> enabled.
> 
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
> This build error seems to be due to Kconfig symbol CONFIG_HSI_BOARDINFO
> being a bool but depending on a tristate (CONFIG_HSI). This is normally
> okay when it is just a flag to enable a feature in source, but the
> helper code file hsi_boardinfo.c is built as a separate entity when
> enabled. This patch is probably how it was intended, and is more like
> how others do this kind of thing.
> 
> This patch should be applied before the parent patch:

Thanks, I applied both patches.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-06-15 12:48 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-13 20:01 [PATCH 00/12] Remove unneeded build directory traversals Andrew F. Davis
2016-06-13 20:01 ` Andrew F. Davis
2016-06-13 20:02 ` [PATCH 01/12] gpio: Only descend into gpio directory when CONFIG_GPIOLIB is set Andrew F. Davis
2016-06-13 20:02   ` Andrew F. Davis
2016-06-14  6:58   ` Linus Walleij
2016-06-14  6:58     ` Linus Walleij
2016-06-13 20:02 ` [PATCH 02/12] pwm: Only descend into pwm directory when CONFIG_PWM " Andrew F. Davis
2016-06-13 20:02   ` Andrew F. Davis
2016-06-13 20:02 ` [PATCH 03/12] amba: Only descend into amba directory when CONFIG_ARM_AMBA " Andrew F. Davis
2016-06-13 20:02   ` Andrew F. Davis
2016-06-13 20:02 ` [PATCH 04/12] NFC: Only descend into nfc directory when CONFIG_NFC " Andrew F. Davis
2016-06-13 20:02   ` Andrew F. Davis
2016-06-13 20:02 ` [PATCH 05/12] macintosh: Only descend into directory when CONFIG_MACINTOSH_DRIVERS " Andrew F. Davis
2016-06-13 20:02   ` Andrew F. Davis
2016-06-13 20:02 ` [PATCH 06/12] hsi: Only descend into hsi directory when CONFIG_HSI " Andrew F. Davis
2016-06-13 20:02   ` Andrew F. Davis
2016-06-14  0:36   ` kbuild test robot
2016-06-14  0:36     ` kbuild test robot
2016-06-14 16:13     ` [PATCH] hsi: Build hsi_boardinfo.c into hsi core if enabled Andrew F. Davis
2016-06-14 16:13       ` Andrew F. Davis
2016-06-15 12:48       ` Sebastian Reichel [this message]
2016-06-15 12:48         ` Sebastian Reichel
2016-06-13 20:02 ` [PATCH 07/12] auxdisplay: Only descend into directory when CONFIG_AUXDISPLAY is set Andrew F. Davis
2016-06-13 20:02   ` Andrew F. Davis
2016-06-13 20:02 ` [PATCH 08/12] i2c: Only descend into i2c directory when CONFIG_I2C " Andrew F. Davis
2016-06-13 20:02   ` Andrew F. Davis
2016-06-14  0:18   ` kbuild test robot
2016-06-14  0:18     ` kbuild test robot
2016-06-13 20:02 ` [PATCH 09/12] [media] Only descend into directory when CONFIG_MEDIA_SUPPORT " Andrew F. Davis
2016-06-13 20:02   ` Andrew F. Davis
2016-06-13 20:02 ` [PATCH 10/12] lguest: Only descend into lguest directory when CONFIG_LGUEST " Andrew F. Davis
2016-06-13 20:02   ` Andrew F. Davis
2016-06-20 20:44   ` Rusty Russell
2016-06-20 20:44     ` Rusty Russell
2016-06-13 20:02 ` [PATCH 11/12] mmc: Only descend into mmc directory when CONFIG_MMC " Andrew F. Davis
2016-06-13 20:02   ` Andrew F. Davis
2016-06-14  1:33   ` kbuild test robot
2016-06-14  1:33     ` kbuild test robot
2016-06-13 20:02 ` [PATCH 12/12] leds: Only descend into leds directory when CONFIG_NEW_LEDS " Andrew F. Davis
2016-06-13 20:02   ` Andrew F. Davis
2016-06-14  0:19   ` kbuild test robot
2016-06-14  0:19     ` kbuild test robot
2016-06-15  6:48   ` Jacek Anaszewski
2016-06-17 22:46     ` Andrew F. Davis
2016-06-17 22:46       ` Andrew F. Davis
2016-06-20  7:41       ` Jacek Anaszewski
2016-06-20  7:41         ` Jacek Anaszewski
2016-06-20 22:13         ` [PATCH] leds: Add no-op gpio_led_register_device when LED subsystem is disabled Andrew F. Davis
2016-06-20 22:13           ` Andrew F. Davis
2016-06-21  7:09           ` Jacek Anaszewski
2016-06-21  7:09             ` Jacek Anaszewski
2016-06-21 11:48             ` Andrew F. Davis
2016-06-21 11:48               ` Andrew F. Davis
2016-06-21 13:11               ` Jacek Anaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160615124842.GA6702@earth \
    --to=sre@kernel.org \
    --cc=afd@ti.com \
    --cc=aloisio.almeida@openbossa.org \
    --cc=benh@kernel.crashing.org \
    --cc=j.anaszewski@samsung.com \
    --cc=kbuild-all@01.org \
    --cc=lauro.venancio@openbossa.org \
    --cc=lguest@lists.ozlabs.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=linuxppc-dev@lists.ozlab \
    --cc=lkp@intel.com \
    --cc=mchehab@osg.samsung.com \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=mingo@kernel.org \
    --cc=rpurdie@rpsys.net \
    --cc=rusty@rustcorp.com.au \
    --cc=sameo@linux.intel.com \
    --cc=ulf.hansson@linaro.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.