* [PATCH v3 1/2] ARM: dts: imx6q-cm-fx6: fix the operation points
@ 2016-06-12 23:24 ` christopher.spinrath-vA1bhqPz9FBZXbeN9DUtxg
0 siblings, 0 replies; 4+ messages in thread
From: christopher.spinrath at rwth-aachen.de @ 2016-06-12 23:24 UTC (permalink / raw)
To: linux-arm-kernel
From: Valentin Raevsky <valentin@compulab.co.il>
The current ldo settings of the cm-fx6 do not allow 1.2GHz cpu
frequency. At this frequency the module behaves unstable.
But the imx6q fuse indicates that 1.2GHz operation is possible.
Hence, remove the 1.2GHz operation point in the device tree.
Signed-off-by: Valentin Raevsky <valentin@compulab.co.il>
[christopher.spinrath at rwth-aachen.de: enhance commit message, adjust
remaining operation points to match the ones in imx6q.dtsi and add
a comment in the device tree]
Signed-off-by: Christopher Spinrath <christopher.spinrath@rwth-aachen.de>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
---
Notes:
Changes since v2:
- fix comment style
- add Fabio's Reviewed-By
Changes since v1:
- Enhance commit message to explain that we cannot rely on the imx6q
fuse to restrict the frequency
- put the same information into a comment in the device tree
- fix the remaining operation points to match the ones given in
imx6q.dtsi
arch/arm/boot/dts/imx6q-cm-fx6.dts | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/arch/arm/boot/dts/imx6q-cm-fx6.dts b/arch/arm/boot/dts/imx6q-cm-fx6.dts
index 6d8d5e9..b5de7e6 100644
--- a/arch/arm/boot/dts/imx6q-cm-fx6.dts
+++ b/arch/arm/boot/dts/imx6q-cm-fx6.dts
@@ -91,6 +91,28 @@
};
};
+&cpu0 {
+ /*
+ * Although the imx6q fuse indicates that 1.2GHz operation is possible,
+ * the module behaves unstable at this frequency. Hence, remove the
+ * 1.2GHz operation point here.
+ */
+ operating-points = <
+ /* kHz uV */
+ 996000 1250000
+ 852000 1250000
+ 792000 1175000
+ 396000 975000
+ >;
+ fsl,soc-operating-points = <
+ /* ARM kHz SOC-PU uV */
+ 996000 1250000
+ 852000 1250000
+ 792000 1175000
+ 396000 1175000
+ >;
+};
+
&ecspi1 {
fsl,spi-num-chipselects = <2>;
cs-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>, <&gpio3 19 GPIO_ACTIVE_HIGH>;
--
2.8.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v3 1/2] ARM: dts: imx6q-cm-fx6: fix the operation points
@ 2016-06-12 23:24 ` christopher.spinrath-vA1bhqPz9FBZXbeN9DUtxg
0 siblings, 0 replies; 4+ messages in thread
From: christopher.spinrath-vA1bhqPz9FBZXbeN9DUtxg @ 2016-06-12 23:24 UTC (permalink / raw)
To: shawnguo-DgEjT+Ai2ygdnm+yROfE0A, kernel-bIcnvbaLZ9MEGnE8C9+IrQ
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-I+IVW8TIWO2tmTQ+vhA3Yw,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
grinberg-UTxiZqZC01RS1MOuV/RT9w, fabio.estevam-3arQi8VN3Tc,
Valentin Raevsky, Christopher Spinrath
From: Valentin Raevsky <valentin-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
The current ldo settings of the cm-fx6 do not allow 1.2GHz cpu
frequency. At this frequency the module behaves unstable.
But the imx6q fuse indicates that 1.2GHz operation is possible.
Hence, remove the 1.2GHz operation point in the device tree.
Signed-off-by: Valentin Raevsky <valentin-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
[christopher.spinrath-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org: enhance commit message, adjust
remaining operation points to match the ones in imx6q.dtsi and add
a comment in the device tree]
Signed-off-by: Christopher Spinrath <christopher.spinrath-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org>
Reviewed-by: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
---
Notes:
Changes since v2:
- fix comment style
- add Fabio's Reviewed-By
Changes since v1:
- Enhance commit message to explain that we cannot rely on the imx6q
fuse to restrict the frequency
- put the same information into a comment in the device tree
- fix the remaining operation points to match the ones given in
imx6q.dtsi
arch/arm/boot/dts/imx6q-cm-fx6.dts | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/arch/arm/boot/dts/imx6q-cm-fx6.dts b/arch/arm/boot/dts/imx6q-cm-fx6.dts
index 6d8d5e9..b5de7e6 100644
--- a/arch/arm/boot/dts/imx6q-cm-fx6.dts
+++ b/arch/arm/boot/dts/imx6q-cm-fx6.dts
@@ -91,6 +91,28 @@
};
};
+&cpu0 {
+ /*
+ * Although the imx6q fuse indicates that 1.2GHz operation is possible,
+ * the module behaves unstable at this frequency. Hence, remove the
+ * 1.2GHz operation point here.
+ */
+ operating-points = <
+ /* kHz uV */
+ 996000 1250000
+ 852000 1250000
+ 792000 1175000
+ 396000 975000
+ >;
+ fsl,soc-operating-points = <
+ /* ARM kHz SOC-PU uV */
+ 996000 1250000
+ 852000 1250000
+ 792000 1175000
+ 396000 1175000
+ >;
+};
+
&ecspi1 {
fsl,spi-num-chipselects = <2>;
cs-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>, <&gpio3 19 GPIO_ACTIVE_HIGH>;
--
2.8.3
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v3 1/2] ARM: dts: imx6q-cm-fx6: fix the operation points
@ 2016-06-16 1:35 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2016-06-16 1:35 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jun 13, 2016 at 01:24:55AM +0200, christopher.spinrath at rwth-aachen.de wrote:
> From: Valentin Raevsky <valentin@compulab.co.il>
>
> The current ldo settings of the cm-fx6 do not allow 1.2GHz cpu
> frequency. At this frequency the module behaves unstable.
>
> But the imx6q fuse indicates that 1.2GHz operation is possible.
> Hence, remove the 1.2GHz operation point in the device tree.
>
> Signed-off-by: Valentin Raevsky <valentin@compulab.co.il>
> [christopher.spinrath at rwth-aachen.de: enhance commit message, adjust
> remaining operation points to match the ones in imx6q.dtsi and add
> a comment in the device tree]
> Signed-off-by: Christopher Spinrath <christopher.spinrath@rwth-aachen.de>
> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 1/2] ARM: dts: imx6q-cm-fx6: fix the operation points
@ 2016-06-16 1:35 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2016-06-16 1:35 UTC (permalink / raw)
To: christopher.spinrath-vA1bhqPz9FBZXbeN9DUtxg
Cc: kernel-bIcnvbaLZ9MEGnE8C9+IrQ, mark.rutland-5wv7dgnIgG8,
devicetree-u79uwXL29TY76Z2rM5mHXA, pawel.moll-5wv7dgnIgG8,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
linux-I+IVW8TIWO2tmTQ+vhA3Yw, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
grinberg-UTxiZqZC01RS1MOuV/RT9w, Valentin Raevsky,
galak-sgV2jX0FEOL9JmXXK+q4OQ, fabio.estevam-3arQi8VN3Tc,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Mon, Jun 13, 2016 at 01:24:55AM +0200, christopher.spinrath-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org wrote:
> From: Valentin Raevsky <valentin-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
>
> The current ldo settings of the cm-fx6 do not allow 1.2GHz cpu
> frequency. At this frequency the module behaves unstable.
>
> But the imx6q fuse indicates that 1.2GHz operation is possible.
> Hence, remove the 1.2GHz operation point in the device tree.
>
> Signed-off-by: Valentin Raevsky <valentin-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
> [christopher.spinrath-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org: enhance commit message, adjust
> remaining operation points to match the ones in imx6q.dtsi and add
> a comment in the device tree]
> Signed-off-by: Christopher Spinrath <christopher.spinrath-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org>
> Reviewed-by: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-06-16 1:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-12 23:24 [PATCH v3 1/2] ARM: dts: imx6q-cm-fx6: fix the operation points christopher.spinrath at rwth-aachen.de
2016-06-12 23:24 ` christopher.spinrath-vA1bhqPz9FBZXbeN9DUtxg
2016-06-16 1:35 ` Shawn Guo
2016-06-16 1:35 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.