From: Matt Ullman <staticfox@staticfox.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Matt Ullman <staticfox@staticfox.net>
Subject: [PATCH v2] lib: Make strreplace prototype compatible with C++
Date: Fri, 17 Jun 2016 13:24:12 -0400 [thread overview]
Message-ID: <20160617172412.9644-1-staticfox@staticfox.net> (raw)
In-Reply-To: <CA+55aFy_whqDaO_qOg0sz8+LKNRfj7QcHVQyce4FvF78tcvTkQ@mail.gmail.com>
Since "new" is a keyword in C++, this breaks compilation when string.h
is included in a C++ file. For example, this affects VirtualBox Guest
Additions.
https://www.virtualbox.org/pipermail/vbox-dev/2015-August/013368.html
Signed-off-by: Matt Ullman <staticfox@staticfox.net>
---
Thanks for your feedback and I agree. I've made the requested changes.
include/linux/string.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/string.h b/include/linux/string.h
index 26b6f6a..1e5183b 100644
--- a/include/linux/string.h
+++ b/include/linux/string.h
@@ -115,7 +115,7 @@ extern int memcmp(const void *,const void *,__kernel_size_t);
extern void * memchr(const void *,int,__kernel_size_t);
#endif
void *memchr_inv(const void *s, int c, size_t n);
-char *strreplace(char *s, char old, char new);
+char *strreplace(char *, char, char);
extern void kfree_const(const void *x);
--
2.9.0
next parent reply other threads:[~2016-06-17 17:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+55aFy_whqDaO_qOg0sz8+LKNRfj7QcHVQyce4FvF78tcvTkQ@mail.gmail.com>
2016-06-17 17:24 ` Matt Ullman [this message]
2016-06-17 18:38 ` [PATCH v2] lib: Make strreplace prototype compatible with C++ Randy Dunlap
2016-06-17 19:38 ` Matt Ullman
2016-06-17 19:54 ` Joe Perches
2016-06-17 20:25 ` Matt Ullman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160617172412.9644-1-staticfox@staticfox.net \
--to=staticfox@staticfox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.