From: Joe Perches <joe@perches.com>
To: 57644395.9010505@infradead.org,
Randy Dunlap <rdunlap@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Matt Ullman <staticfox@staticfox.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] lib: Make strreplace prototype compatible with C++
Date: Fri, 17 Jun 2016 12:54:55 -0700 [thread overview]
Message-ID: <1466193295.19647.118.camel@perches.com> (raw)
In-Reply-To: <20160617193856.GA25433@staticfox.net>
(Matt, you've got an unusual reply-to header)
On Fri, 2016-06-17 at 15:38 -0400, Matt Ullman wrote:
> On Fri, Jun 17, 2016 at 11:38:13AM -0700, Randy Dunlap wrote:
> > I didn't see and could not find any reply to v1. Who is that comment
> > addressed to? Linus?
> Yes, this was addressed to Linus. He CC'd the mailing list, but I could not
> find it either. Here is what he wrote:
> >
> > Please only change the prototype, not the function. Might as well remove
> > the argument names in the prototype.
> >
> > Let's not make the C code uglier for no reason. The fact that C++ screwed
> > up and thought that "new" can't be used as a variable name is no reason not
> > to do it in C code.
> >
> > Similarly, we don't make C code use the insane C++ pointer caring rules.
> >
> > Linus
> -- Matt Ullman
I think kernel-doc is useful and maybe from/to or find/replace
could be used instead of old/new
next prev parent reply other threads:[~2016-06-17 19:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+55aFy_whqDaO_qOg0sz8+LKNRfj7QcHVQyce4FvF78tcvTkQ@mail.gmail.com>
2016-06-17 17:24 ` [PATCH v2] lib: Make strreplace prototype compatible with C++ Matt Ullman
2016-06-17 18:38 ` Randy Dunlap
2016-06-17 19:38 ` Matt Ullman
2016-06-17 19:54 ` Joe Perches [this message]
2016-06-17 20:25 ` Matt Ullman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466193295.19647.118.camel@perches.com \
--to=joe@perches.com \
--cc=57644395.9010505@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=staticfox@staticfox.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.