* [PATCH][v2] dell-wmi: add a WMI event code for display on/off
@ 2016-06-17 3:44 Alex Hung
2016-06-17 18:19 ` Darren Hart
2016-06-17 18:50 ` Pali Rohár
0 siblings, 2 replies; 4+ messages in thread
From: Alex Hung @ 2016-06-17 3:44 UTC (permalink / raw)
To: mjg59, pali.rohar, dvhart, platform-driver-x86, alex.hung
Some new Dell AIO systems have a button that generates WMI evnet
that is to be used to turn LCD on/off.
Acked-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
drivers/platform/x86/dell-wmi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
index b8ad055..8e6c357 100644
--- a/drivers/platform/x86/dell-wmi.c
+++ b/drivers/platform/x86/dell-wmi.c
@@ -133,6 +133,9 @@ static const struct key_entry dell_wmi_keymap_type_0000[] __initconst = {
/* Audio panel key */
{ KE_IGNORE, 0xe026, { KEY_RESERVED } },
+ /* Monitor On/Off Control key */
+ { KE_KEY, 0xe027, { KEY_DISPLAYTOGGLE } },
+
/* Untested, Multimedia key on Dell Vostro 3560 */
/* { KE_IGNORE, 0xe028, { KEY_RESERVED } }, */
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH][v2] dell-wmi: add a WMI event code for display on/off
2016-06-17 3:44 [PATCH][v2] dell-wmi: add a WMI event code for display on/off Alex Hung
@ 2016-06-17 18:19 ` Darren Hart
2016-06-17 18:50 ` Pali Rohár
1 sibling, 0 replies; 4+ messages in thread
From: Darren Hart @ 2016-06-17 18:19 UTC (permalink / raw)
To: Alex Hung; +Cc: mjg59, pali.rohar, platform-driver-x86
On Fri, Jun 17, 2016 at 11:44:27AM +0800, Alex Hung wrote:
> Some new Dell AIO systems have a button that generates WMI evnet
> that is to be used to turn LCD on/off.
>
> Acked-by: Pali Rohár <pali.rohar@gmail.com>
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
> drivers/platform/x86/dell-wmi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index b8ad055..8e6c357 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -133,6 +133,9 @@ static const struct key_entry dell_wmi_keymap_type_0000[] __initconst = {
> /* Audio panel key */
> { KE_IGNORE, 0xe026, { KEY_RESERVED } },
>
> + /* Monitor On/Off Control key */
I've changed this to:
/* LCD Display On/Off Control Key */
As "Monitor" read like external display to me. I can change this back if you
strongly disagree.
Queued for 4.8.
--
Darren Hart
Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][v2] dell-wmi: add a WMI event code for display on/off
2016-06-17 3:44 [PATCH][v2] dell-wmi: add a WMI event code for display on/off Alex Hung
2016-06-17 18:19 ` Darren Hart
@ 2016-06-17 18:50 ` Pali Rohár
2016-06-21 16:24 ` Darren Hart
1 sibling, 1 reply; 4+ messages in thread
From: Pali Rohár @ 2016-06-17 18:50 UTC (permalink / raw)
To: dvhart; +Cc: Alex Hung, mjg59, platform-driver-x86
[-- Attachment #1: Type: Text/Plain, Size: 511 bytes --]
On Friday 17 June 2016 05:44:27 Alex Hung wrote:
> @@ -133,6 +133,9 @@ static const struct key_entry
> dell_wmi_keymap_type_0000[] __initconst = { /* Audio panel key */
> { KE_IGNORE, 0xe026, { KEY_RESERVED } },
>
> + /* Monitor On/Off Control key */
> + { KE_KEY, 0xe027, { KEY_DISPLAYTOGGLE } },
Darren, I would suggest small alignment (as for 0xe026):
{ KE_KEY, 0xe027, { KEY_DISPLAYTOGGLE } },
> { KE_IGNORE, 0xe026, { KEY_RESERVED } },
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][v2] dell-wmi: add a WMI event code for display on/off
2016-06-17 18:50 ` Pali Rohár
@ 2016-06-21 16:24 ` Darren Hart
0 siblings, 0 replies; 4+ messages in thread
From: Darren Hart @ 2016-06-21 16:24 UTC (permalink / raw)
To: Pali Rohár; +Cc: Alex Hung, mjg59, platform-driver-x86
On Fri, Jun 17, 2016 at 08:50:27PM +0200, Pali Rohár wrote:
> On Friday 17 June 2016 05:44:27 Alex Hung wrote:
> > @@ -133,6 +133,9 @@ static const struct key_entry
> > dell_wmi_keymap_type_0000[] __initconst = { /* Audio panel key */
> > { KE_IGNORE, 0xe026, { KEY_RESERVED } },
> >
> > + /* Monitor On/Off Control key */
> > + { KE_KEY, 0xe027, { KEY_DISPLAYTOGGLE } },
>
> Darren, I would suggest small alignment (as for 0xe026):
Done.
>
> { KE_KEY, 0xe027, { KEY_DISPLAYTOGGLE } },
>
> > { KE_IGNORE, 0xe026, { KEY_RESERVED } },
>
> --
> Pali Rohár
> pali.rohar@gmail.com
--
Darren Hart
Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-06-21 16:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-17 3:44 [PATCH][v2] dell-wmi: add a WMI event code for display on/off Alex Hung
2016-06-17 18:19 ` Darren Hart
2016-06-17 18:50 ` Pali Rohár
2016-06-21 16:24 ` Darren Hart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.