From: Leon Romanovsky <leon@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Moni Shoua <monis@mellanox.com>,
Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ib/rxe: double free on error
Date: Sat, 18 Jun 2016 11:22:07 +0000 [thread overview]
Message-ID: <20160618112207.GG5408@leon.nu> (raw)
In-Reply-To: <20160618110330.GF5408@leon.nu>
[-- Attachment #1: Type: text/plain, Size: 1102 bytes --]
On Sat, Jun 18, 2016 at 02:03:30PM +0300, Leon Romanovsky wrote:
> On Sat, Jun 18, 2016 at 02:00:03PM +0300, Dan Carpenter wrote:
> > On Sat, Jun 18, 2016 at 01:34:30PM +0300, Leon Romanovsky wrote:
> > > drivers/infiniband/hw/rxe/rxe.c | 29 ++++++-----------------------
> > > 1 file changed, 6 insertions(+), 23 deletions(-)
> > >
> > > diff --git a/drivers/infiniband/hw/rxe/rxe.c b/drivers/infiniband/hw/rxe/rxe.c
> > > index 48c41e00..156a1021 100644
> > > --- a/drivers/infiniband/hw/rxe/rxe.c
> > > +++ b/drivers/infiniband/hw/rxe/rxe.c
> > > @@ -165,42 +165,25 @@ static int rxe_init_port_param(struct rxe_port *port)
> > > */
> > > static int rxe_init_ports(struct rxe_dev *rxe)
> > > {
> > > - int err;
> > > - struct rxe_port *port;
> > > -
> > > - port = &rxe->port;
> > > + struct rxe_port *port = rxe->port;
> >
> > This won't compile.
>
> Interesting, it compiled locally. I'll check it now.
Thanks, I accidentally pushed wrong version.
>
> >
> > Just give me Reported-by credit not authorship.
> >
> > regards,
> > dan carpenter
> >
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Leon Romanovsky <leon@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Moni Shoua <monis@mellanox.com>,
Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ib/rxe: double free on error
Date: Sat, 18 Jun 2016 14:22:07 +0300 [thread overview]
Message-ID: <20160618112207.GG5408@leon.nu> (raw)
In-Reply-To: <20160618110330.GF5408@leon.nu>
[-- Attachment #1: Type: text/plain, Size: 1102 bytes --]
On Sat, Jun 18, 2016 at 02:03:30PM +0300, Leon Romanovsky wrote:
> On Sat, Jun 18, 2016 at 02:00:03PM +0300, Dan Carpenter wrote:
> > On Sat, Jun 18, 2016 at 01:34:30PM +0300, Leon Romanovsky wrote:
> > > drivers/infiniband/hw/rxe/rxe.c | 29 ++++++-----------------------
> > > 1 file changed, 6 insertions(+), 23 deletions(-)
> > >
> > > diff --git a/drivers/infiniband/hw/rxe/rxe.c b/drivers/infiniband/hw/rxe/rxe.c
> > > index 48c41e00..156a1021 100644
> > > --- a/drivers/infiniband/hw/rxe/rxe.c
> > > +++ b/drivers/infiniband/hw/rxe/rxe.c
> > > @@ -165,42 +165,25 @@ static int rxe_init_port_param(struct rxe_port *port)
> > > */
> > > static int rxe_init_ports(struct rxe_dev *rxe)
> > > {
> > > - int err;
> > > - struct rxe_port *port;
> > > -
> > > - port = &rxe->port;
> > > + struct rxe_port *port = rxe->port;
> >
> > This won't compile.
>
> Interesting, it compiled locally. I'll check it now.
Thanks, I accidentally pushed wrong version.
>
> >
> > Just give me Reported-by credit not authorship.
> >
> > regards,
> > dan carpenter
> >
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-18 11:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-18 8:40 [patch] ib/rxe: double free on error Dan Carpenter
2016-06-18 8:40 ` Dan Carpenter
2016-06-18 10:34 ` Leon Romanovsky
2016-06-18 10:34 ` Leon Romanovsky
[not found] ` <20160618103430.GC5408-2ukJVAZIZ/Y@public.gmane.org>
2016-06-18 11:00 ` Dan Carpenter
2016-06-18 11:00 ` Dan Carpenter
2016-06-18 11:03 ` Leon Romanovsky
2016-06-18 11:03 ` Leon Romanovsky
2016-06-18 11:22 ` Leon Romanovsky [this message]
2016-06-18 11:22 ` Leon Romanovsky
-- strict thread matches above, loose matches on Subject: below --
2016-06-18 13:36 [PATCH] IB/rxe: Simplify rxe_init_ports logic kbuild test robot
2016-06-18 13:36 ` kbuild test robot
2017-03-08 5:21 [PATCH] IB/rxe: double free on error Dan Carpenter
2017-03-08 5:21 ` Dan Carpenter
2017-03-08 6:58 ` Leon Romanovsky
2017-03-08 6:58 ` Leon Romanovsky
[not found] ` <20170308065829.GV14379-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-03-08 16:42 ` Moni Shoua
2017-03-08 16:42 ` Moni Shoua
2017-03-08 16:44 ` Moni Shoua
2017-03-08 16:44 ` Moni Shoua
2017-03-25 1:48 ` Doug Ledford
2017-03-25 1:48 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160618112207.GG5408@leon.nu \
--to=leon@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=monis@mellanox.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.