From: Minchan Kim <minchan@kernel.org>
To: Vitaly Wool <vitalywool@gmail.com>
Cc: Geliang Tang <geliangtang@gmail.com>,
Nitin Gupta <ngupta@vflare.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Dan Streetman <ddstreet@ieee.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>
Subject: Re: [PATCH] zram: update zram to use zpool
Date: Mon, 20 Jun 2016 17:00:21 +0900 [thread overview]
Message-ID: <20160620080021.GB28207@bbox> (raw)
In-Reply-To: <CAMJBoFPcaAbsQ=PA2WPsmuyd1a-SyJgE5k4Rn2CUf6rS0-ykKw@mail.gmail.com>
On Fri, Jun 17, 2016 at 10:30:58AM +0200, Vitaly Wool wrote:
> Hi Minchan,
>
> On Thu, Jun 16, 2016 at 1:17 AM, Minchan Kim <minchan@kernel.org> wrote:
> > On Wed, Jun 15, 2016 at 10:42:07PM +0800, Geliang Tang wrote:
> >> Change zram to use the zpool api instead of directly using zsmalloc.
> >> The zpool api doesn't have zs_compact() and zs_pool_stats() functions.
> >> I did the following two things to fix it.
> >> 1) I replace zs_compact() with zpool_shrink(), use zpool_shrink() to
> >> call zs_compact() in zsmalloc.
> >> 2) The 'pages_compacted' attribute is showed in zram by calling
> >> zs_pool_stats(). So in order not to call zs_pool_state() I move the
> >> attribute to zsmalloc.
> >>
> >> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> >
> > NACK.
> >
> > I already explained why.
> > http://lkml.kernel.org/r/20160609013411.GA29779@bbox
>
> This is a fair statement, to a certain extent. I'll let Geliang speak
> for himself but I am personally interested in this zram extension
> because I want it to work on MMU-less systems. zsmalloc can not handle
> that, so I want to be able to use zram over z3fold.
Could you tell me more detail? What's the usecase?
>
> Best regards,
> Vitaly
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Vitaly Wool <vitalywool@gmail.com>
Cc: Geliang Tang <geliangtang@gmail.com>,
Nitin Gupta <ngupta@vflare.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Dan Streetman <ddstreet@ieee.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>
Subject: Re: [PATCH] zram: update zram to use zpool
Date: Mon, 20 Jun 2016 17:00:21 +0900 [thread overview]
Message-ID: <20160620080021.GB28207@bbox> (raw)
In-Reply-To: <CAMJBoFPcaAbsQ=PA2WPsmuyd1a-SyJgE5k4Rn2CUf6rS0-ykKw@mail.gmail.com>
On Fri, Jun 17, 2016 at 10:30:58AM +0200, Vitaly Wool wrote:
> Hi Minchan,
>
> On Thu, Jun 16, 2016 at 1:17 AM, Minchan Kim <minchan@kernel.org> wrote:
> > On Wed, Jun 15, 2016 at 10:42:07PM +0800, Geliang Tang wrote:
> >> Change zram to use the zpool api instead of directly using zsmalloc.
> >> The zpool api doesn't have zs_compact() and zs_pool_stats() functions.
> >> I did the following two things to fix it.
> >> 1) I replace zs_compact() with zpool_shrink(), use zpool_shrink() to
> >> call zs_compact() in zsmalloc.
> >> 2) The 'pages_compacted' attribute is showed in zram by calling
> >> zs_pool_stats(). So in order not to call zs_pool_state() I move the
> >> attribute to zsmalloc.
> >>
> >> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> >
> > NACK.
> >
> > I already explained why.
> > http://lkml.kernel.org/r/20160609013411.GA29779@bbox
>
> This is a fair statement, to a certain extent. I'll let Geliang speak
> for himself but I am personally interested in this zram extension
> because I want it to work on MMU-less systems. zsmalloc can not handle
> that, so I want to be able to use zram over z3fold.
Could you tell me more detail? What's the usecase?
>
> Best regards,
> Vitaly
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-06-20 8:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 9:39 [PATCH] zram: add zpool support Geliang Tang
2016-06-08 9:39 ` Geliang Tang
2016-06-08 14:51 ` Dan Streetman
2016-06-08 14:51 ` Dan Streetman
2016-06-09 1:34 ` Minchan Kim
2016-06-09 1:34 ` Minchan Kim
2016-06-09 1:43 ` Sergey Senozhatsky
2016-06-09 1:43 ` Sergey Senozhatsky
2016-06-13 9:11 ` Vitaly Wool
2016-06-13 20:04 ` Fwd: " Vitaly Wool
2016-06-15 14:42 ` [PATCH] zram: add zpool support v2 Geliang Tang
2016-06-15 14:42 ` Geliang Tang
2016-06-15 14:42 ` [PATCH] zram: update zram to use zpool Geliang Tang
2016-06-15 14:42 ` Geliang Tang
2016-06-15 14:54 ` Dan Streetman
2016-06-15 14:54 ` Dan Streetman
2016-06-15 15:33 ` kbuild test robot
2016-06-15 15:33 ` kbuild test robot
2016-06-15 23:17 ` Minchan Kim
2016-06-15 23:17 ` Minchan Kim
2016-06-17 8:30 ` Vitaly Wool
2016-06-17 8:30 ` Vitaly Wool
2016-06-17 12:28 ` Austin S. Hemmelgarn
2016-06-17 12:28 ` Austin S. Hemmelgarn
2016-06-20 8:00 ` Minchan Kim [this message]
2016-06-20 8:00 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620080021.GB28207@bbox \
--to=minchan@kernel.org \
--cc=ddstreet@ieee.org \
--cc=geliangtang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=vitalywool@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.