From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend
Date: Mon, 20 Jun 2016 10:03:34 +0200 [thread overview]
Message-ID: <20160620080334.GL5809@piout.net> (raw)
In-Reply-To: <B256D81BAE5131468A838E5D7A24364101650C5253@penmbx01>
On 20/06/2016 at 03:16:35 +0000, Yang, Wenyou wrote :
> > Sure, what I mean is that you can try to get the regmap for the SFR in every case.
> > Depending on whether you were able to get it, you can decide to call
> > ohci_at91_port_suspend/resume or not (just test for sfr_regmap != NULL).
>
> I don't think so. The SFR includes a lot of miscellaneous functions, more than this one.
>
I know but this is irrelevant to this discussion. If you need to use the
SFR from another driver you will simply get it from that other driver.
I that case, you will try to get "atmel,sama5d2-sfr". It is only present
on sama5d2 so you have enough information to know whether or not you can
use it to suspend/resume.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: "Yang, Wenyou" <Wenyou.Yang@atmel.com>
Cc: Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"Ferre, Nicolas" <Nicolas.FERRE@atmel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Kumar Gala <galak@codeaurora.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend
Date: Mon, 20 Jun 2016 10:03:34 +0200 [thread overview]
Message-ID: <20160620080334.GL5809@piout.net> (raw)
In-Reply-To: <B256D81BAE5131468A838E5D7A24364101650C5253@penmbx01>
On 20/06/2016 at 03:16:35 +0000, Yang, Wenyou wrote :
> > Sure, what I mean is that you can try to get the regmap for the SFR in every case.
> > Depending on whether you were able to get it, you can decide to call
> > ohci_at91_port_suspend/resume or not (just test for sfr_regmap != NULL).
>
> I don't think so. The SFR includes a lot of miscellaneous functions, more than this one.
>
I know but this is irrelevant to this discussion. If you need to use the
SFR from another driver you will simply get it from that other driver.
I that case, you will try to get "atmel,sama5d2-sfr". It is only present
on sama5d2 so you have enough information to know whether or not you can
use it to suspend/resume.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: "Yang, Wenyou" <Wenyou.Yang@atmel.com>
Cc: Rob Herring <robh@kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Ferre, Nicolas" <Nicolas.FERRE@atmel.com>,
Pawel Moll <pawel.moll@arm.com>, Mark Brown <broonie@kernel.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend
Date: Mon, 20 Jun 2016 10:03:34 +0200 [thread overview]
Message-ID: <20160620080334.GL5809@piout.net> (raw)
In-Reply-To: <B256D81BAE5131468A838E5D7A24364101650C5253@penmbx01>
On 20/06/2016 at 03:16:35 +0000, Yang, Wenyou wrote :
> > Sure, what I mean is that you can try to get the regmap for the SFR in every case.
> > Depending on whether you were able to get it, you can decide to call
> > ohci_at91_port_suspend/resume or not (just test for sfr_regmap != NULL).
>
> I don't think so. The SFR includes a lot of miscellaneous functions, more than this one.
>
I know but this is irrelevant to this discussion. If you need to use the
SFR from another driver you will simply get it from that other driver.
I that case, you will try to get "atmel,sama5d2-sfr". It is only present
on sama5d2 so you have enough information to know whether or not you can
use it to suspend/resume.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-06-20 8:03 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 4:15 [PATCH v3 0/2] ARM: ohci-at91: Add support to forcibly suspend ports while sleep Wenyou Yang
2016-06-08 4:15 ` Wenyou Yang
2016-06-08 4:15 ` Wenyou Yang
2016-06-08 4:15 ` [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend Wenyou Yang
2016-06-08 4:15 ` Wenyou Yang
2016-06-08 4:15 ` Wenyou Yang
2016-06-08 10:04 ` Nicolas Ferre
2016-06-08 10:04 ` Nicolas Ferre
2016-06-08 10:04 ` Nicolas Ferre
2016-06-08 10:45 ` Nicolas Ferre
2016-06-08 10:45 ` Nicolas Ferre
2016-06-08 10:45 ` Nicolas Ferre
2016-06-20 7:49 ` Yang, Wenyou
2016-06-20 7:49 ` Yang, Wenyou
2016-06-20 7:49 ` Yang, Wenyou
2016-06-08 19:13 ` Alan Stern
2016-06-08 19:13 ` Alan Stern
2016-06-08 19:13 ` Alan Stern
2016-06-10 8:58 ` Yang, Wenyou
2016-06-10 8:58 ` Yang, Wenyou
2016-06-08 20:26 ` Rob Herring
2016-06-08 20:26 ` Rob Herring
2016-06-08 20:26 ` Rob Herring
2016-06-08 20:38 ` Alexandre Belloni
2016-06-08 20:38 ` Alexandre Belloni
2016-06-08 20:38 ` Alexandre Belloni
2016-06-17 13:44 ` Yang, Wenyou
2016-06-17 13:44 ` Yang, Wenyou
2016-06-17 13:54 ` Alexandre Belloni
2016-06-17 13:54 ` Alexandre Belloni
2016-06-20 3:16 ` Yang, Wenyou
2016-06-20 3:16 ` Yang, Wenyou
2016-06-20 3:16 ` Yang, Wenyou
2016-06-20 8:03 ` Alexandre Belloni [this message]
2016-06-20 8:03 ` Alexandre Belloni
2016-06-20 8:03 ` Alexandre Belloni
2016-06-20 8:46 ` Yang, Wenyou
2016-06-20 8:46 ` Yang, Wenyou
2016-06-20 8:46 ` Yang, Wenyou
2016-06-20 8:52 ` Alexandre Belloni
2016-06-20 8:52 ` Alexandre Belloni
2016-06-20 8:52 ` Alexandre Belloni
2016-06-20 9:21 ` Nicolas Ferre
2016-06-20 9:21 ` Nicolas Ferre
2016-06-20 9:21 ` Nicolas Ferre
2016-06-20 7:42 ` Yang, Wenyou
2016-06-20 7:42 ` Yang, Wenyou
2016-06-20 7:42 ` Yang, Wenyou
2016-06-08 4:15 ` [PATCH v3 2/2] ARM: at91/dt: sama5d2: Use new compatible for ohci node Wenyou Yang
2016-06-08 4:15 ` Wenyou Yang
2016-06-08 4:15 ` Wenyou Yang
2016-06-08 10:06 ` Nicolas Ferre
2016-06-08 10:06 ` Nicolas Ferre
2016-06-08 10:06 ` Nicolas Ferre
2016-06-08 10:33 ` Alexandre Belloni
2016-06-08 10:33 ` Alexandre Belloni
2016-06-08 10:33 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620080334.GL5809@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.