From: Johannes Weiner <hannes@cmpxchg.org>
To: Tejun Heo <tj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@kernel.org>,
Vladimir Davydov <vdavydov@virtuozzo.com>,
Linux MM <linux-mm@kvack.org>,
cgroups@vger.kernel.org,
"linux-kernel@vger.kernel.org >> Linux Kernel Mailing List"
<linux-kernel@vger.kernel.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
kernel-team@fb.com
Subject: Re: [PATCH] memcg: mem_cgroup_migrate() may be called with irq disabled
Date: Mon, 20 Jun 2016 15:50:01 -0400 [thread overview]
Message-ID: <20160620195001.GA19775@cmpxchg.org> (raw)
In-Reply-To: <20160620184158.GO3262@mtj.duckdns.org>
On Mon, Jun 20, 2016 at 02:41:58PM -0400, Tejun Heo wrote:
> mem_cgroup_migrate() uses local_irq_disable/enable() but can be called
> with irq disabled from migrate_page_copy(). This ends up enabling irq
> while holding a irq context lock triggering the following lockdep
> warning. Fix it by using irq_save/restore instead.
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Fixes: 74485cf2bc85 ("mm: migrate: consolidate mem_cgroup_migrate() calls")
CC: stable@vger.kernel.org # 4.5
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Tejun Heo <tj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@kernel.org>,
Vladimir Davydov <vdavydov@virtuozzo.com>,
Linux MM <linux-mm@kvack.org>,
cgroups@vger.kernel.org,
"linux-kernel@vger.kernel.org >> Linux Kernel Mailing List"
<linux-kernel@vger.kernel.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
kernel-team@fb.com
Subject: Re: [PATCH] memcg: mem_cgroup_migrate() may be called with irq disabled
Date: Mon, 20 Jun 2016 15:50:01 -0400 [thread overview]
Message-ID: <20160620195001.GA19775@cmpxchg.org> (raw)
In-Reply-To: <20160620184158.GO3262@mtj.duckdns.org>
On Mon, Jun 20, 2016 at 02:41:58PM -0400, Tejun Heo wrote:
> mem_cgroup_migrate() uses local_irq_disable/enable() but can be called
> with irq disabled from migrate_page_copy(). This ends up enabling irq
> while holding a irq context lock triggering the following lockdep
> warning. Fix it by using irq_save/restore instead.
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Fixes: 74485cf2bc85 ("mm: migrate: consolidate mem_cgroup_migrate() calls")
CC: stable@vger.kernel.org # 4.5
next prev parent reply other threads:[~2016-06-20 19:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 11:13 4.7-rc1: lockdep: inconsistent lock state kcompactd/aio_migratepage/mem_cgroup_migrate Christian Borntraeger
2016-06-20 11:13 ` Christian Borntraeger
2016-06-20 18:41 ` [PATCH] memcg: mem_cgroup_migrate() may be called with irq disabled Tejun Heo
2016-06-20 18:41 ` Tejun Heo
2016-06-20 19:50 ` Johannes Weiner [this message]
2016-06-20 19:50 ` Johannes Weiner
2016-06-20 20:33 ` Christian Borntraeger
2016-06-20 20:33 ` Christian Borntraeger
2016-06-21 8:42 ` Michal Hocko
2016-06-21 8:42 ` Michal Hocko
2016-06-21 9:59 ` Vladimir Davydov
2016-06-21 9:59 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620195001.GA19775@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@de.ibm.com \
--cc=cgroups@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=tj@kernel.org \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.