From: Peter Chen <hzpeterchen@gmail.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: mark.rutland@arm.com, Peter Chen <peter.chen@nxp.com>,
ulf.hansson@linaro.org, stephen.boyd@linaro.org,
festevam@gmail.com, arnd@arndb.de, javier@osg.samsung.com,
stern@rowland.harvard.edu, devicetree@vger.kernel.org,
mail@maciej.szmigiero.name, pawel.moll@arm.com,
linux-pm@vger.kernel.org, s.hauer@pengutronix.de,
troy.kisky@boundarydevices.com, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org, oscar@naiandei.net,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-mmc@vger.kernel.org, sre@kernel.org, broonie@kernel.org,
p.zabel@pengutronix.de
Subject: Re: [PATCH 07/12] power: pwrseq: rename file name for generic driver
Date: Tue, 21 Jun 2016 10:19:49 +0800 [thread overview]
Message-ID: <20160621021949.GF26936@shlinux2> (raw)
In-Reply-To: <5767E614.5030002@samsung.com>
On Mon, Jun 20, 2016 at 02:48:20PM +0200, Krzysztof Kozlowski wrote:
> On 06/17/2016 12:09 PM, Peter Chen wrote:
> > The individual driver file name is better to contain module name.
> >
> > Signed-off-by: Peter Chen <peter.chen@nxp.com>
> > ---
> > .../power/pwrseq/{pwrseq-simple.txt => mmc-pwrseq-simple.txt} | 0
> > drivers/power/pwrseq/Makefile | 4 ++--
> > drivers/power/pwrseq/{pwrseq.c => core.c} | 0
> > drivers/power/pwrseq/{pwrseq_simple.c => pwrseq_mmc_simple.c} | 0
> > 4 files changed, 2 insertions(+), 2 deletions(-)
> > rename Documentation/devicetree/bindings/power/pwrseq/{pwrseq-simple.txt => mmc-pwrseq-simple.txt} (100%)
> > rename drivers/power/pwrseq/{pwrseq.c => core.c} (100%)
> > rename drivers/power/pwrseq/{pwrseq_simple.c => pwrseq_mmc_simple.c} (100%)
> >
> > diff --git a/Documentation/devicetree/bindings/power/pwrseq/pwrseq-simple.txt b/Documentation/devicetree/bindings/power/pwrseq/mmc-pwrseq-simple.txt
> > similarity index 100%
> > rename from Documentation/devicetree/bindings/power/pwrseq/pwrseq-simple.txt
> > rename to Documentation/devicetree/bindings/power/pwrseq/mmc-pwrseq-simple.txt
> > diff --git a/drivers/power/pwrseq/Makefile b/drivers/power/pwrseq/Makefile
> > index 9e40e4b..d475e01 100644
> > --- a/drivers/power/pwrseq/Makefile
> > +++ b/drivers/power/pwrseq/Makefile
> > @@ -1,3 +1,3 @@
> > -obj-$(CONFIG_POWER_SEQ) += pwrseq.o
> > -obj-$(CONFIG_POWER_SEQ_SIMPLE) += pwrseq_simple.o
> > +obj-$(CONFIG_POWER_SEQ) += core.o
> > +obj-$(CONFIG_POWER_SEQ_SIMPLE) += pwrseq_mmc_simple.o
>
> Although the driver was developed for MMC but it is quite generic (or
> rather - mmc independent). The name of the driver is just
> "pwrseq_simple" so I think MMC prefix is not needed.
>
It is may be common for MMC, but not USB, or others. Eg, its reset-gpios
is just like enable-gpios. Some reset chip process needs to toggle gpio.
--
Best Regards,
Peter Chen
WARNING: multiple messages have this Message-ID (diff)
From: hzpeterchen@gmail.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/12] power: pwrseq: rename file name for generic driver
Date: Tue, 21 Jun 2016 10:19:49 +0800 [thread overview]
Message-ID: <20160621021949.GF26936@shlinux2> (raw)
In-Reply-To: <5767E614.5030002@samsung.com>
On Mon, Jun 20, 2016 at 02:48:20PM +0200, Krzysztof Kozlowski wrote:
> On 06/17/2016 12:09 PM, Peter Chen wrote:
> > The individual driver file name is better to contain module name.
> >
> > Signed-off-by: Peter Chen <peter.chen@nxp.com>
> > ---
> > .../power/pwrseq/{pwrseq-simple.txt => mmc-pwrseq-simple.txt} | 0
> > drivers/power/pwrseq/Makefile | 4 ++--
> > drivers/power/pwrseq/{pwrseq.c => core.c} | 0
> > drivers/power/pwrseq/{pwrseq_simple.c => pwrseq_mmc_simple.c} | 0
> > 4 files changed, 2 insertions(+), 2 deletions(-)
> > rename Documentation/devicetree/bindings/power/pwrseq/{pwrseq-simple.txt => mmc-pwrseq-simple.txt} (100%)
> > rename drivers/power/pwrseq/{pwrseq.c => core.c} (100%)
> > rename drivers/power/pwrseq/{pwrseq_simple.c => pwrseq_mmc_simple.c} (100%)
> >
> > diff --git a/Documentation/devicetree/bindings/power/pwrseq/pwrseq-simple.txt b/Documentation/devicetree/bindings/power/pwrseq/mmc-pwrseq-simple.txt
> > similarity index 100%
> > rename from Documentation/devicetree/bindings/power/pwrseq/pwrseq-simple.txt
> > rename to Documentation/devicetree/bindings/power/pwrseq/mmc-pwrseq-simple.txt
> > diff --git a/drivers/power/pwrseq/Makefile b/drivers/power/pwrseq/Makefile
> > index 9e40e4b..d475e01 100644
> > --- a/drivers/power/pwrseq/Makefile
> > +++ b/drivers/power/pwrseq/Makefile
> > @@ -1,3 +1,3 @@
> > -obj-$(CONFIG_POWER_SEQ) += pwrseq.o
> > -obj-$(CONFIG_POWER_SEQ_SIMPLE) += pwrseq_simple.o
> > +obj-$(CONFIG_POWER_SEQ) += core.o
> > +obj-$(CONFIG_POWER_SEQ_SIMPLE) += pwrseq_mmc_simple.o
>
> Although the driver was developed for MMC but it is quite generic (or
> rather - mmc independent). The name of the driver is just
> "pwrseq_simple" so I think MMC prefix is not needed.
>
It is may be common for MMC, but not USB, or others. Eg, its reset-gpios
is just like enable-gpios. Some reset chip process needs to toggle gpio.
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2016-06-21 2:19 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 10:09 [PATCH 00/12] power: add generic power sequence framework Peter Chen
2016-06-17 10:09 ` Peter Chen
2016-06-17 10:09 ` [PATCH 01/12] power/mmc: Move pwrseq drivers to power/pwrseq Peter Chen
2016-06-17 10:09 ` Peter Chen
2016-06-17 10:09 ` [PATCH 02/12] MAINTAINERS: Retain Ulf Hansson as the same maintainer of pwrseq Peter Chen
2016-06-17 10:09 ` Peter Chen
2016-06-17 10:09 ` [PATCH 03/12] power: pwrseq: Enable COMPILE_TEST for drivers Peter Chen
2016-06-17 10:09 ` Peter Chen
2016-06-17 10:09 ` [PATCH 05/12] power: pwrseq: Generalize mmc_pwrseq operations by removing mmc prefix Peter Chen
2016-06-17 10:09 ` Peter Chen
2016-06-17 10:09 ` [PATCH 06/12] power: pwrseq: change common helpers as generic Peter Chen
2016-06-17 10:09 ` Peter Chen
2016-06-17 10:09 ` [PATCH 07/12] power: pwrseq: rename file name for generic driver Peter Chen
2016-06-17 10:09 ` Peter Chen
2016-06-20 12:48 ` Krzysztof Kozlowski
2016-06-20 12:48 ` Krzysztof Kozlowski
2016-06-21 2:19 ` Peter Chen [this message]
2016-06-21 2:19 ` Peter Chen
2016-06-17 10:09 ` [PATCH 09/12] power: pwrseq: pwrseq_usb_generic: add generic power sequence support for USB deivces Peter Chen
2016-06-17 10:09 ` Peter Chen
2016-06-17 10:09 ` [PATCH 11/12] usb: chipidea: host: let the hcd know's parent device node Peter Chen
2016-06-17 10:09 ` Peter Chen
[not found] ` <1466158165-9380-1-git-send-email-peter.chen-3arQi8VN3Tc@public.gmane.org>
2016-06-17 10:09 ` [PATCH 04/12] power: pwrseq: Remove mmc prefix from mmc_pwrseq Peter Chen
2016-06-17 10:09 ` Peter Chen
2016-06-17 10:09 ` [PATCH 08/12] doc: binding: pwrseq-usb-generic: add binding doc for generic usb power sequence driver Peter Chen
2016-06-17 10:09 ` Peter Chen
2016-06-17 17:16 ` Rob Herring
2016-06-17 17:16 ` Rob Herring
2016-06-20 11:26 ` Peter Chen
2016-06-20 11:26 ` Peter Chen
2016-06-20 12:29 ` Chen-Yu Tsai
2016-06-20 12:29 ` Chen-Yu Tsai
2016-06-21 2:14 ` Peter Chen
2016-06-21 2:14 ` Peter Chen
2016-06-20 16:16 ` Rob Herring
2016-06-20 16:16 ` Rob Herring
2016-06-20 17:06 ` Mark Brown
2016-06-20 17:06 ` Mark Brown
2016-06-21 2:11 ` Peter Chen
2016-06-21 2:11 ` Peter Chen
2016-06-21 21:26 ` Rob Herring
2016-06-21 21:26 ` Rob Herring
2016-06-22 1:14 ` Peter Chen
2016-06-22 1:14 ` Peter Chen
2016-06-22 9:09 ` Ulf Hansson
2016-06-22 9:09 ` Ulf Hansson
2016-06-24 15:25 ` Rob Herring
2016-06-24 15:25 ` Rob Herring
2016-06-17 10:09 ` [PATCH 10/12] usb: core: add power sequence handling for USB devices Peter Chen
2016-06-17 10:09 ` Peter Chen
[not found] ` <1466158165-9380-11-git-send-email-peter.chen-3arQi8VN3Tc@public.gmane.org>
2016-06-17 16:12 ` Alan Stern
2016-06-17 16:12 ` Alan Stern
2016-06-17 10:09 ` [PATCH 12/12] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property Peter Chen
2016-06-17 10:09 ` Peter Chen
2016-06-17 23:29 ` [PATCH 00/12] power: add generic power sequence framework Maciej S. Szmigiero
2016-06-17 23:29 ` Maciej S. Szmigiero
2016-06-20 11:27 ` Peter Chen
2016-06-20 11:27 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160621021949.GF26936@shlinux2 \
--to=hzpeterchen@gmail.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=mark.rutland@arm.com \
--cc=oscar@naiandei.net \
--cc=p.zabel@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=peter.chen@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sre@kernel.org \
--cc=stephen.boyd@linaro.org \
--cc=stern@rowland.harvard.edu \
--cc=troy.kisky@boundarydevices.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.