From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: linux-kernel@vger.kernel.org
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: [PATCH 4/5] PM / devfreq: make event/exynos-nocp explicitly non-modular
Date: Tue, 21 Jun 2016 01:15:00 -0400 [thread overview]
Message-ID: <20160621051501.18396-5-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <20160621051501.18396-1-paul.gortmaker@windriver.com>
The Kconfig currently controlling compilation of this code is:
event/Kconfig:config DEVFREQ_EVENT_EXYNOS_NOCP
event/Kconfig: bool "EXYNOS NoC (Network On Chip) Probe DEVFREQ event Driver"
...meaning that it currently is not being built as a module by anyone.
Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.
We explicitly disallow a driver unbind, since that doesn't have a
sensible use case anyway, and it allows us to drop the ".remove"
code for non-modular drivers.
Since module_platform_driver() uses the same init level priority as
builtin_platform_driver() the init ordering remains unchanged with
this commit.
We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: linux-pm@vger.kernel.org
Cc: linux-samsung-soc@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/devfreq/event/exynos-nocp.c | 19 +++----------------
1 file changed, 3 insertions(+), 16 deletions(-)
diff --git a/drivers/devfreq/event/exynos-nocp.c b/drivers/devfreq/event/exynos-nocp.c
index 6b6a5f310486..f954578abfdf 100644
--- a/drivers/devfreq/event/exynos-nocp.c
+++ b/drivers/devfreq/event/exynos-nocp.c
@@ -10,7 +10,7 @@
*/
#include <linux/clk.h>
-#include <linux/module.h>
+#include <linux/init.h>
#include <linux/devfreq-event.h>
#include <linux/kernel.h>
#include <linux/of_address.h>
@@ -280,25 +280,12 @@ static int exynos_nocp_probe(struct platform_device *pdev)
return 0;
}
-static int exynos_nocp_remove(struct platform_device *pdev)
-{
- struct exynos_nocp *nocp = platform_get_drvdata(pdev);
-
- clk_disable_unprepare(nocp->clk);
-
- return 0;
-}
-
static struct platform_driver exynos_nocp_driver = {
.probe = exynos_nocp_probe,
- .remove = exynos_nocp_remove,
.driver = {
.name = "exynos-nocp",
+ .suppress_bind_attrs = true,
.of_match_table = exynos_nocp_id_match,
},
};
-module_platform_driver(exynos_nocp_driver);
-
-MODULE_DESCRIPTION("Exynos NoC (Network on Chip) Probe driver");
-MODULE_AUTHOR("Chanwoo Choi <cw00.choi@samsung.com>");
-MODULE_LICENSE("GPL");
+builtin_platform_driver(exynos_nocp_driver);
--
2.8.4
WARNING: multiple messages have this Message-ID (diff)
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
<linux-pm@vger.kernel.org>, <linux-samsung-soc@vger.kernel.org>
Subject: [PATCH 4/5] PM / devfreq: make event/exynos-nocp explicitly non-modular
Date: Tue, 21 Jun 2016 01:15:00 -0400 [thread overview]
Message-ID: <20160621051501.18396-5-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <20160621051501.18396-1-paul.gortmaker@windriver.com>
The Kconfig currently controlling compilation of this code is:
event/Kconfig:config DEVFREQ_EVENT_EXYNOS_NOCP
event/Kconfig: bool "EXYNOS NoC (Network On Chip) Probe DEVFREQ event Driver"
...meaning that it currently is not being built as a module by anyone.
Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.
We explicitly disallow a driver unbind, since that doesn't have a
sensible use case anyway, and it allows us to drop the ".remove"
code for non-modular drivers.
Since module_platform_driver() uses the same init level priority as
builtin_platform_driver() the init ordering remains unchanged with
this commit.
We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: linux-pm@vger.kernel.org
Cc: linux-samsung-soc@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/devfreq/event/exynos-nocp.c | 19 +++----------------
1 file changed, 3 insertions(+), 16 deletions(-)
diff --git a/drivers/devfreq/event/exynos-nocp.c b/drivers/devfreq/event/exynos-nocp.c
index 6b6a5f310486..f954578abfdf 100644
--- a/drivers/devfreq/event/exynos-nocp.c
+++ b/drivers/devfreq/event/exynos-nocp.c
@@ -10,7 +10,7 @@
*/
#include <linux/clk.h>
-#include <linux/module.h>
+#include <linux/init.h>
#include <linux/devfreq-event.h>
#include <linux/kernel.h>
#include <linux/of_address.h>
@@ -280,25 +280,12 @@ static int exynos_nocp_probe(struct platform_device *pdev)
return 0;
}
-static int exynos_nocp_remove(struct platform_device *pdev)
-{
- struct exynos_nocp *nocp = platform_get_drvdata(pdev);
-
- clk_disable_unprepare(nocp->clk);
-
- return 0;
-}
-
static struct platform_driver exynos_nocp_driver = {
.probe = exynos_nocp_probe,
- .remove = exynos_nocp_remove,
.driver = {
.name = "exynos-nocp",
+ .suppress_bind_attrs = true,
.of_match_table = exynos_nocp_id_match,
},
};
-module_platform_driver(exynos_nocp_driver);
-
-MODULE_DESCRIPTION("Exynos NoC (Network on Chip) Probe driver");
-MODULE_AUTHOR("Chanwoo Choi <cw00.choi@samsung.com>");
-MODULE_LICENSE("GPL");
+builtin_platform_driver(exynos_nocp_driver);
--
2.8.4
next prev parent reply other threads:[~2016-06-21 5:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20160621051708epcas1p4d2bacb86070cd65ec1fba990e108425e@epcas1p4.samsung.com>
2016-06-21 5:14 ` [PATCH 0/5] PM / devfreq: remove modular references from non-modules Paul Gortmaker
2016-06-21 5:14 ` Paul Gortmaker
2016-06-21 5:14 ` [PATCH 1/5] PM / devfreq: make devfreq explicitly non-modular Paul Gortmaker
2016-06-21 5:14 ` Paul Gortmaker
2016-06-21 5:14 ` [PATCH 2/5] PM / devfreq: make devfreq-event " Paul Gortmaker
2016-06-21 5:14 ` Paul Gortmaker
2016-06-21 5:14 ` [PATCH 3/5] PM / devfreq: make exynos-bus " Paul Gortmaker
2016-06-21 5:14 ` Paul Gortmaker
2016-06-21 5:15 ` Paul Gortmaker [this message]
2016-06-21 5:15 ` [PATCH 4/5] PM / devfreq: make event/exynos-nocp " Paul Gortmaker
2016-06-21 5:15 ` [PATCH 5/5] PM / devfreq: make event/exynos-ppmu " Paul Gortmaker
2016-06-21 5:15 ` Paul Gortmaker
2016-06-21 6:17 ` [PATCH 0/5] PM / devfreq: remove modular references from non-modules Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160621051501.18396-5-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=cw00.choi@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.