All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Andy Gross <andy.gross@linaro.org>,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	David Brown <david.brown@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/8] arm64: dts: db820c: add basic board support
Date: Tue, 21 Jun 2016 21:49:16 -0700	[thread overview]
Message-ID: <20160622044916.GF1256@tuxbot> (raw)
In-Reply-To: <1466529769-2674-2-git-send-email-srinivas.kandagatla@linaro.org>

On Tue 21 Jun 10:22 PDT 2016, Srinivas Kandagatla wrote:

[..]
> diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
[..]
> +
> +/ {
> +	model = "Qualcomm Technologies, Inc. DB820c";
> +	compatible = "qcom,apq8096-sbc";

I'm still not buying the concept of this being the one and only
single-board-computer.

If this compatible fully and exclusively identifies this particular
board then dtbTool should be updated to follow the product name
"qcom,apq8096-db820c". If on the other hand this identifies a class of
single-board-computers, then the compatible should list both
"qcom,apq8096-dtb820c" and "qcom,apq8096-sbc".



Further more, the ePAPR defines this property as:
"Specifies a list of platform architectures with which this platform is
compatible. This property can be used by operating systems in selecting
platform specific code."

So I think we should follow the common pattern of having the least
significant entry being "qcom,apq8096".

> +};

Regards,
Bjorn

WARNING: multiple messages have this Message-ID (diff)
From: bjorn.andersson@linaro.org (Bjorn Andersson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/8] arm64: dts: db820c: add basic board support
Date: Tue, 21 Jun 2016 21:49:16 -0700	[thread overview]
Message-ID: <20160622044916.GF1256@tuxbot> (raw)
In-Reply-To: <1466529769-2674-2-git-send-email-srinivas.kandagatla@linaro.org>

On Tue 21 Jun 10:22 PDT 2016, Srinivas Kandagatla wrote:

[..]
> diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
[..]
> +
> +/ {
> +	model = "Qualcomm Technologies, Inc. DB820c";
> +	compatible = "qcom,apq8096-sbc";

I'm still not buying the concept of this being the one and only
single-board-computer.

If this compatible fully and exclusively identifies this particular
board then dtbTool should be updated to follow the product name
"qcom,apq8096-db820c". If on the other hand this identifies a class of
single-board-computers, then the compatible should list both
"qcom,apq8096-dtb820c" and "qcom,apq8096-sbc".



Further more, the ePAPR defines this property as:
"Specifies a list of platform architectures with which this platform is
compatible. This property can be used by operating systems in selecting
platform specific code."

So I think we should follow the common pattern of having the least
significant entry being "qcom,apq8096".

> +};

Regards,
Bjorn

  reply	other threads:[~2016-06-22  4:49 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-21 17:22 [PATCH v2 0/8] arm64: dts: db820c: Add basic board support Srinivas Kandagatla
2016-06-21 17:22 ` Srinivas Kandagatla
2016-06-21 17:22 ` Srinivas Kandagatla
2016-06-21 17:22 ` [PATCH v2 1/8] arm64: dts: db820c: add " Srinivas Kandagatla
2016-06-21 17:22   ` Srinivas Kandagatla
2016-06-21 17:22   ` Srinivas Kandagatla
2016-06-22  4:49   ` Bjorn Andersson [this message]
2016-06-22  4:49     ` Bjorn Andersson
2016-06-22  8:52     ` Srinivas Kandagatla
2016-06-22  8:52       ` Srinivas Kandagatla
     [not found]       ` <576A51BC.5090108-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-06-22 16:04         ` Bjorn Andersson
2016-06-22 16:04           ` Bjorn Andersson
2016-06-22 16:04           ` Bjorn Andersson
2016-06-22 13:06   ` Mark Rutland
2016-06-22 13:06     ` Mark Rutland
2016-06-21 17:22 ` [PATCH v2 2/8] arm64: dts: db820c: add support to LS-UART0 Srinivas Kandagatla
2016-06-21 17:22   ` Srinivas Kandagatla
2016-06-21 17:22   ` Srinivas Kandagatla
2016-06-21 17:22 ` [PATCH v2 3/8] arm64: dts: db820c: add support to LS-I2C0 Srinivas Kandagatla
2016-06-21 17:22   ` Srinivas Kandagatla
2016-06-21 17:22   ` Srinivas Kandagatla
2016-06-21 17:22 ` [PATCH v2 4/8] arm64: dts: db820c: add support to LS-I2C1 Srinivas Kandagatla
2016-06-21 17:22   ` Srinivas Kandagatla
2016-06-21 17:22   ` Srinivas Kandagatla
2016-06-21 17:22 ` [PATCH v2 5/8] arm64: dts: db820c: add support to I2C on HS Srinivas Kandagatla
2016-06-21 17:22   ` Srinivas Kandagatla
2016-06-21 17:22   ` Srinivas Kandagatla
2016-06-21 17:22 ` [PATCH v2 6/8] arm64: dts: db820c: add support to LS-SPI0 Srinivas Kandagatla
2016-06-21 17:22   ` Srinivas Kandagatla
2016-06-21 17:22   ` Srinivas Kandagatla
2016-06-21 17:22 ` [PATCH v2 7/8] arm64: dts: db820c: add support to SPI on HS Srinivas Kandagatla
2016-06-21 17:22   ` Srinivas Kandagatla
2016-06-21 17:22   ` Srinivas Kandagatla
2016-06-21 17:22 ` [PATCH v2 8/8] arm64: dts: db820c: add support to external sd card Srinivas Kandagatla
2016-06-21 17:22   ` Srinivas Kandagatla
2016-06-21 17:22   ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160622044916.GF1256@tuxbot \
    --to=bjorn.andersson@linaro.org \
    --cc=andy.gross@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.