From: Thierry Reding <thierry.reding@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-tegra@vger.kernel.org, Alexandre Courbot <gnurou@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Stephen Warren <swarren@wwwdotorg.org>
Subject: Re: [PATCH] ARM: tegra: remove board_init_funcs array
Date: Wed, 22 Jun 2016 14:50:13 +0200 [thread overview]
Message-ID: <20160622125013.GH26943@ulmo.ba.sec> (raw)
In-Reply-To: <20160622124052.1263574-1-arnd@arndb.de>
[-- Attachment #1.1: Type: text/plain, Size: 1047 bytes --]
On Wed, Jun 22, 2016 at 02:39:41PM +0200, Arnd Bergmann wrote:
> In a configuration that enables CONFIG_UBSAN_SANITIZE_ALL, I am getting
> a section mismatch warning for tegra20:
>
> WARNING: arch/arm/mach-tegra/built-in.o(.data+0x6e0): Section mismatch in reference from the variable board_init_funcs to the function .init.text:paz00_init()
>
> The array is no longer useful here since there is only one entry,
> so we can simply call the function directly after checking
> of_machine_is_compatible(). This fixes the section mismatch
> and is easier to read.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arm/mach-tegra/tegra.c | 24 +++---------------------
> 1 file changed, 3 insertions(+), 21 deletions(-)
Shouldn't these section mismatches show up with default builds? I
haven't seen any when building Tegra configurations.
I'm going to apply this patch because I think it's useful, but it sure
would be nice to know why I need to enable this new UBSAN stuff to get
these warnings now.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: remove board_init_funcs array
Date: Wed, 22 Jun 2016 14:50:13 +0200 [thread overview]
Message-ID: <20160622125013.GH26943@ulmo.ba.sec> (raw)
In-Reply-To: <20160622124052.1263574-1-arnd@arndb.de>
On Wed, Jun 22, 2016 at 02:39:41PM +0200, Arnd Bergmann wrote:
> In a configuration that enables CONFIG_UBSAN_SANITIZE_ALL, I am getting
> a section mismatch warning for tegra20:
>
> WARNING: arch/arm/mach-tegra/built-in.o(.data+0x6e0): Section mismatch in reference from the variable board_init_funcs to the function .init.text:paz00_init()
>
> The array is no longer useful here since there is only one entry,
> so we can simply call the function directly after checking
> of_machine_is_compatible(). This fixes the section mismatch
> and is easier to read.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arm/mach-tegra/tegra.c | 24 +++---------------------
> 1 file changed, 3 insertions(+), 21 deletions(-)
Shouldn't these section mismatches show up with default builds? I
haven't seen any when building Tegra configurations.
I'm going to apply this patch because I think it's useful, but it sure
would be nice to know why I need to enable this new UBSAN stuff to get
these warnings now.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160622/b557a1b5/attachment-0001.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
Alexandre Courbot <gnurou@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: tegra: remove board_init_funcs array
Date: Wed, 22 Jun 2016 14:50:13 +0200 [thread overview]
Message-ID: <20160622125013.GH26943@ulmo.ba.sec> (raw)
In-Reply-To: <20160622124052.1263574-1-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]
On Wed, Jun 22, 2016 at 02:39:41PM +0200, Arnd Bergmann wrote:
> In a configuration that enables CONFIG_UBSAN_SANITIZE_ALL, I am getting
> a section mismatch warning for tegra20:
>
> WARNING: arch/arm/mach-tegra/built-in.o(.data+0x6e0): Section mismatch in reference from the variable board_init_funcs to the function .init.text:paz00_init()
>
> The array is no longer useful here since there is only one entry,
> so we can simply call the function directly after checking
> of_machine_is_compatible(). This fixes the section mismatch
> and is easier to read.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arm/mach-tegra/tegra.c | 24 +++---------------------
> 1 file changed, 3 insertions(+), 21 deletions(-)
Shouldn't these section mismatches show up with default builds? I
haven't seen any when building Tegra configurations.
I'm going to apply this patch because I think it's useful, but it sure
would be nice to know why I need to enable this new UBSAN stuff to get
these warnings now.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-22 12:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 12:39 [PATCH] ARM: tegra: remove board_init_funcs array Arnd Bergmann
2016-06-22 12:39 ` Arnd Bergmann
2016-06-22 12:50 ` Thierry Reding [this message]
2016-06-22 12:50 ` Thierry Reding
2016-06-22 12:50 ` Thierry Reding
2016-06-22 13:05 ` Arnd Bergmann
2016-06-22 13:05 ` Arnd Bergmann
2016-06-22 13:05 ` Arnd Bergmann
2016-06-22 13:34 ` Thierry Reding
2016-06-22 13:34 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160622125013.GH26943@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=arnd@arndb.de \
--cc=gnurou@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.