All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Rob Landley <rob@landley.net>
Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
	pavel@ucw.cz, akpm@linux-foundation.org, tglx@linutronix.de,
	mgorman@suse.de, mingo@kernel.org, keescook@chromium.org,
	paulmck@linux.vnet.ibm.com
Subject: Re: [PATCH] Make CONFIG_DEVTMPFS_MOUNT apply to initramfs/initmpfs.
Date: Wed, 22 Jun 2016 21:02:15 +0000	[thread overview]
Message-ID: <20160622210215.GA25333@kroah.com> (raw)
In-Reply-To: <576AE1C5.5090909@landley.net>

On Wed, Jun 22, 2016 at 02:06:45PM -0500, Rob Landley wrote:
> From: Rob Landley <rob@landley.net>
> 
> Make CONFIG_DEVTMPFS_MOUNT apply to initramfs/initmpfs.
> 
> Update help text, slightly improve error reporting, move /dev/console open
> down after devtmpfs mount, don't check IS_ENABLED(CONFIG_TMPFS) before
> mounting devtmpfs (it's always there, even if just a ramfs alias), and
> report whether we think we're using tmpfs or ramfs for rootfs.

That's a lot of different things to be doing all at once in the same
patch.  Can you please break these out into individual logical changes?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Rob Landley <rob@landley.net>
Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
	pavel@ucw.cz, akpm@linux-foundation.org, tglx@linutronix.de,
	mgorman@suse.de, mingo@kernel.org, keescook@chromium.org,
	paulmck@linux.vnet.ibm.com
Subject: Re: [PATCH] Make CONFIG_DEVTMPFS_MOUNT apply to initramfs/initmpfs.
Date: Wed, 22 Jun 2016 14:02:15 -0700	[thread overview]
Message-ID: <20160622210215.GA25333@kroah.com> (raw)
In-Reply-To: <576AE1C5.5090909@landley.net>

On Wed, Jun 22, 2016 at 02:06:45PM -0500, Rob Landley wrote:
> From: Rob Landley <rob@landley.net>
> 
> Make CONFIG_DEVTMPFS_MOUNT apply to initramfs/initmpfs.
> 
> Update help text, slightly improve error reporting, move /dev/console open
> down after devtmpfs mount, don't check IS_ENABLED(CONFIG_TMPFS) before
> mounting devtmpfs (it's always there, even if just a ramfs alias), and
> report whether we think we're using tmpfs or ramfs for rootfs.

That's a lot of different things to be doing all at once in the same
patch.  Can you please break these out into individual logical changes?

thanks,

greg k-h

  reply	other threads:[~2016-06-22 21:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-22 19:06 [PATCH] Make CONFIG_DEVTMPFS_MOUNT apply to initramfs/initmpfs Rob Landley
2016-06-22 19:06 ` Rob Landley
2016-06-22 21:02 ` Greg KH [this message]
2016-06-22 21:02   ` Greg KH
2016-06-23 19:39 ` Rich Felker
2016-06-23 19:39   ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160622210215.GA25333@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=pavel@ucw.cz \
    --cc=rob@landley.net \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.