All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH 6/7] crypto: remove useless casts
Date: Thu, 23 Jun 2016 12:07:35 +0100	[thread overview]
Message-ID: <20160623110735.GN17868@redhat.com> (raw)
In-Reply-To: <1466007277-17525-7-git-send-email-lvivier@redhat.com>

On Wed, Jun 15, 2016 at 06:14:36PM +0200, Laurent Vivier wrote:
> This patch is the result of coccinelle script
> scripts/coccinelle/typecast.cocci
> 
> CC: Daniel P. Berrange <berrange@redhat.com>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
>  crypto/cipher-builtin.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/crypto/cipher-builtin.c b/crypto/cipher-builtin.c
> index 88963f6..d791c80 100644
> --- a/crypto/cipher-builtin.c
> +++ b/crypto/cipher-builtin.c
> @@ -132,7 +132,7 @@ static void qcrypto_cipher_aes_xts_encrypt(const void *ctx,
>  {
>      const QCryptoCipherBuiltinAESContext *aesctx = ctx;
>  
> -    qcrypto_cipher_aes_ecb_encrypt((AES_KEY *)&aesctx->enc,
> +    qcrypto_cipher_aes_ecb_encrypt(&aesctx->enc,
>                                     src, dst, length);
>  }
>  
> @@ -144,7 +144,7 @@ static void qcrypto_cipher_aes_xts_decrypt(const void *ctx,
>  {
>      const QCryptoCipherBuiltinAESContext *aesctx = ctx;
>  
> -    qcrypto_cipher_aes_ecb_decrypt((AES_KEY *)&aesctx->dec,
> +    qcrypto_cipher_aes_ecb_decrypt(&aesctx->dec,
>                                     src, dst, length);
>  }

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

I'm fine with this going in via qemu-trivial.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


WARNING: multiple messages have this Message-ID (diff)
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 6/7] crypto: remove useless casts
Date: Thu, 23 Jun 2016 12:07:35 +0100	[thread overview]
Message-ID: <20160623110735.GN17868@redhat.com> (raw)
In-Reply-To: <1466007277-17525-7-git-send-email-lvivier@redhat.com>

On Wed, Jun 15, 2016 at 06:14:36PM +0200, Laurent Vivier wrote:
> This patch is the result of coccinelle script
> scripts/coccinelle/typecast.cocci
> 
> CC: Daniel P. Berrange <berrange@redhat.com>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
>  crypto/cipher-builtin.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/crypto/cipher-builtin.c b/crypto/cipher-builtin.c
> index 88963f6..d791c80 100644
> --- a/crypto/cipher-builtin.c
> +++ b/crypto/cipher-builtin.c
> @@ -132,7 +132,7 @@ static void qcrypto_cipher_aes_xts_encrypt(const void *ctx,
>  {
>      const QCryptoCipherBuiltinAESContext *aesctx = ctx;
>  
> -    qcrypto_cipher_aes_ecb_encrypt((AES_KEY *)&aesctx->enc,
> +    qcrypto_cipher_aes_ecb_encrypt(&aesctx->enc,
>                                     src, dst, length);
>  }
>  
> @@ -144,7 +144,7 @@ static void qcrypto_cipher_aes_xts_decrypt(const void *ctx,
>  {
>      const QCryptoCipherBuiltinAESContext *aesctx = ctx;
>  
> -    qcrypto_cipher_aes_ecb_decrypt((AES_KEY *)&aesctx->dec,
> +    qcrypto_cipher_aes_ecb_decrypt(&aesctx->dec,
>                                     src, dst, length);
>  }

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

I'm fine with this going in via qemu-trivial.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

  reply	other threads:[~2016-06-23 11:07 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-15 16:14 [Qemu-trivial] [PATCH 0/7] Remove useless casts Laurent Vivier
2016-06-15 16:14 ` [Qemu-devel] " Laurent Vivier
2016-06-15 16:14 ` [Qemu-trivial] [PATCH 1/7] coccinelle: add a script to remove " Laurent Vivier
2016-06-15 16:14   ` [Qemu-devel] " Laurent Vivier
2016-06-24 17:21   ` [Qemu-trivial] " Eric Blake
2016-06-24 17:21     ` Eric Blake
2016-06-15 16:14 ` [Qemu-trivial] [PATCH 2/7] linux-user,s390x: remove useless cast Laurent Vivier
2016-06-15 16:14   ` [Qemu-devel] " Laurent Vivier
2016-06-15 16:14 ` [Qemu-trivial] [PATCH 3/7] s390x: " Laurent Vivier
2016-06-15 16:14   ` [Qemu-devel] " Laurent Vivier
2016-06-15 16:14 ` [Qemu-trivial] [PATCH 4/7] tricore: " Laurent Vivier
2016-06-15 16:14   ` [Qemu-devel] " Laurent Vivier
2016-06-16  8:17   ` [Qemu-trivial] " Bastian Koppelmann
2016-06-16  8:17     ` Bastian Koppelmann
2016-06-15 16:14 ` [Qemu-trivial] [PATCH 5/7] fw_cfg: remove useless casts Laurent Vivier
2016-06-15 16:14   ` [Qemu-devel] " Laurent Vivier
2016-06-15 16:34   ` [Qemu-trivial] " Laszlo Ersek
2016-06-15 16:34     ` [Qemu-devel] " Laszlo Ersek
2016-06-15 16:14 ` [Qemu-trivial] [PATCH 6/7] crypto: " Laurent Vivier
2016-06-15 16:14   ` [Qemu-devel] " Laurent Vivier
2016-06-23 11:07   ` Daniel P. Berrange [this message]
2016-06-23 11:07     ` Daniel P. Berrange
2016-09-14  7:40   ` [Qemu-trivial] " Michael Tokarev
2016-09-14  7:40     ` [Qemu-devel] " Michael Tokarev
2016-06-15 16:14 ` [Qemu-trivial] [PATCH 7/7] sheepdog: " Laurent Vivier
2016-06-15 16:14   ` [Qemu-devel] " Laurent Vivier
2016-06-17  3:23   ` [Qemu-trivial] " Hitoshi Mitake
2016-06-17  3:23     ` Hitoshi Mitake
2016-06-23 11:03 ` [Qemu-trivial] [Qemu-devel] [PATCH 0/7] Remove " Laurent Vivier
2016-06-23 11:03   ` Laurent Vivier
2016-09-14  7:18 ` [Qemu-trivial] " Michael Tokarev
2016-09-14  7:18   ` [Qemu-devel] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160623110735.GN17868@redhat.com \
    --to=berrange@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.