From: Greg KH <greg@kroah.com>
To: tech@winchiphead.com
Cc: johan@kernel.org, gregkh@linuxfoundation.rog,
konstantin.shkolnyy@gmail.com, pberger@brimson.com,
david.ward@ll.mit.edu, m.othacehe@gmail.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: serial: update CH34x driver in drivers/usb/serial
Date: Thu, 23 Jun 2016 19:39:13 -0700 [thread overview]
Message-ID: <20160624023913.GA30063@kroah.com> (raw)
In-Reply-To: <1466732874-12649-1-git-send-email-tech@winchiphead.com>
On Thu, Jun 23, 2016 at 06:47:54PM -0700, tech@winchiphead.com wrote:
> The old driver for usb-serial chips ch34x which submitted by kernel volunteer
> Frank A Kingswood <frank@kingswood-consulting.co.uk> is too old to use, and the
> driver has bugs when receiving chracters, thus after communicating with the author
> we decide to revoke the old driver ch341.c and submit the new one ch34x.c.
"revoke"? Why not just fix the bugs in the existing one instead? That
would be a much smaller patch, and much easier to review.
> Add the relevant details to Documentation/usb/usb-serial.txt.
> Change the relevant files Kconfig and Makefile in drivers/usb/serial.
>
> Signed-off-by: WCH Tech Group <tech@winchiphead.com>
This has to be a person, it can not be a company, or any other anonymous
email address, sorry. Same with your "From:" address.
thanks,
greg k-h
next prev parent reply other threads:[~2016-06-24 2:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 1:47 [PATCH] usb: serial: update CH34x driver in drivers/usb/serial tech
2016-06-24 2:39 ` Greg KH [this message]
2016-06-24 2:39 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160624023913.GA30063@kroah.com \
--to=greg@kroah.com \
--cc=david.ward@ll.mit.edu \
--cc=gregkh@linuxfoundation.rog \
--cc=johan@kernel.org \
--cc=konstantin.shkolnyy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.othacehe@gmail.com \
--cc=pberger@brimson.com \
--cc=tech@winchiphead.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.