From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"moderated list:TPM DEVICE DRIVER"
<tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [PATCH 1/5] tpm: unify tpm_gen_interrupt()
Date: Fri, 24 Jun 2016 23:25:39 +0300 [thread overview]
Message-ID: <20160624202539.GE8399@intel.com> (raw)
In-Reply-To: <20160624193024.GA563-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
On Fri, Jun 24, 2016 at 01:30:24PM -0600, Jason Gunthorpe wrote:
> On Fri, Jun 17, 2016 at 11:10:43PM +0200, Jarkko Sakkinen wrote:
> > extern int tpm_get_timeouts(struct tpm_chip *);
> > -extern void tpm_gen_interrupt(struct tpm_chip *);
> > +void tpm_gen_interrupt(struct tpm_chip *);
>
> Dropping the argument name is not the kernel standard, if these lines
> are going to be churned they may as well be churned to the standard.
>
> FWIW, all the extern's should be dropped too.
Thanks for pointin these out. And yes, since this is mostly a cleanup
series, adding a patch that would clean up those unnecessary externs
would make sense. I'll send a revised version with your suggestions.
> Jason
/Jarkko
------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
linux-security-module@vger.kernel.org,
Stefan Berger <stefanb@linux.vnet.ibm.com>,
Marcel Selhorst <tpmdd@selhorst.net>,
"moderated list:TPM DEVICE DRIVER"
<tpmdd-devel@lists.sourceforge.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] tpm: unify tpm_gen_interrupt()
Date: Fri, 24 Jun 2016 23:25:39 +0300 [thread overview]
Message-ID: <20160624202539.GE8399@intel.com> (raw)
In-Reply-To: <20160624193024.GA563@obsidianresearch.com>
On Fri, Jun 24, 2016 at 01:30:24PM -0600, Jason Gunthorpe wrote:
> On Fri, Jun 17, 2016 at 11:10:43PM +0200, Jarkko Sakkinen wrote:
> > extern int tpm_get_timeouts(struct tpm_chip *);
> > -extern void tpm_gen_interrupt(struct tpm_chip *);
> > +void tpm_gen_interrupt(struct tpm_chip *);
>
> Dropping the argument name is not the kernel standard, if these lines
> are going to be churned they may as well be churned to the standard.
>
> FWIW, all the extern's should be dropped too.
Thanks for pointin these out. And yes, since this is mostly a cleanup
series, adding a patch that would clean up those unnecessary externs
would make sense. I'll send a revised version with your suggestions.
> Jason
/Jarkko
next prev parent reply other threads:[~2016-06-24 20:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 21:10 [PATCH 0/5] Use tpm_transmit_cmd() consistently Jarkko Sakkinen
2016-06-17 21:10 ` Jarkko Sakkinen
[not found] ` <1466197847-4937-1-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-06-17 21:10 ` [PATCH 1/5] tpm: unify tpm_gen_interrupt() Jarkko Sakkinen
2016-06-17 21:10 ` Jarkko Sakkinen
2016-06-24 19:30 ` Jason Gunthorpe
[not found] ` <20160624193024.GA563-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-06-24 20:25 ` Jarkko Sakkinen [this message]
2016-06-24 20:25 ` Jarkko Sakkinen
2016-06-17 21:10 ` [PATCH 2/5] tpm: return error code from tpm_gen_interrupt() Jarkko Sakkinen
2016-06-17 21:10 ` Jarkko Sakkinen
2016-06-17 21:10 ` [PATCH 3/5] tpm: use tpm_transmit_cmd() in tpm2_probe() Jarkko Sakkinen
2016-06-17 21:10 ` Jarkko Sakkinen
2016-06-17 21:10 ` [PATCH 4/5] tpm: rename tpm_pcr_read_dev() to tpm1_pcr_read() Jarkko Sakkinen
2016-06-17 21:10 ` Jarkko Sakkinen
2016-06-17 21:10 ` [PATCH 5/5] tpm: use tpm1_pcr_read() in tpm_do_selftest() Jarkko Sakkinen
2016-06-17 21:10 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160624202539.GE8399@intel.com \
--to=jarkko.sakkinen-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.