All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Jiri Slaby <jslaby@suse.com>,
	Magnus Damm <damm+renesas@opensource.se>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	linux-serial@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-sh@vger.kernel.org, uclinux-h8-devel@lists.sourceforge.jp
Subject: Re: [PATCH v2 2/4] serial: sh-sci: Stop transfers in sci_shutdown()
Date: Sat, 25 Jun 2016 09:10:51 -0700	[thread overview]
Message-ID: <20160625161051.GA30995@kroah.com> (raw)
In-Reply-To: <20160625160939.GA29593@kroah.com>

On Sat, Jun 25, 2016 at 09:09:39AM -0700, Greg Kroah-Hartman wrote:
> On Fri, Jun 24, 2016 at 04:59:14PM +0200, Geert Uytterhoeven wrote:
> > Make sure the transmitter and receiver are stopped when shutting down
> > the port, and related interrupts are disabled.
> > 
> > Without this:
> >   - New input data may be received into the RX FIFO, possibly
> >     triggering a new RX DMA completion,
> >   - Transfers will still be enabled on a subsequent startup of the UART,
> >     before the UART's FIFOs have been reset, causing reading of stale
> >     data.
> > 
> > Inspired by a patch in the BSP by Koji Matsuoka
> > <koji.matsuoka.xm@renesas.com>.
> > 
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > v2:
> >   - Do not clear clock source bits, since the serial console relies on
> >     them, as reported by Shimoda-san.
> > 
> > v1 was extracted from "[PATCH/RFC v3 0/4] serial: sh-sci: Add DT DMA
> > support".  The issues with the serial console seen before on
> > r8a7740/armadillo and sh73a0/kzm9g seem to be gone.  Changes after
> > resurrection:
> >   - Write zero to also disable related interrupts, as suggested by
> >     Laurent Pinchart,
> >   - Enhanced patch description.
> > ---
> >  drivers/tty/serial/sh-sci.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> 
> This patch does not apply to my tree :(

But I don't have access to my 2-factor token for about 24 hours, so my
tree will not be public until after then, sorry about that, I'll email
you when it gets synced up to kernel.org...

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Jiri Slaby <jslaby@suse.com>,
	Magnus Damm <damm+renesas@opensource.se>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	linux-serial@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-sh@vger.kernel.org, uclinux-h8-devel@lists.sourceforge.jp
Subject: Re: [PATCH v2 2/4] serial: sh-sci: Stop transfers in sci_shutdown()
Date: Sat, 25 Jun 2016 16:10:51 +0000	[thread overview]
Message-ID: <20160625161051.GA30995@kroah.com> (raw)
In-Reply-To: <20160625160939.GA29593@kroah.com>

On Sat, Jun 25, 2016 at 09:09:39AM -0700, Greg Kroah-Hartman wrote:
> On Fri, Jun 24, 2016 at 04:59:14PM +0200, Geert Uytterhoeven wrote:
> > Make sure the transmitter and receiver are stopped when shutting down
> > the port, and related interrupts are disabled.
> > 
> > Without this:
> >   - New input data may be received into the RX FIFO, possibly
> >     triggering a new RX DMA completion,
> >   - Transfers will still be enabled on a subsequent startup of the UART,
> >     before the UART's FIFOs have been reset, causing reading of stale
> >     data.
> > 
> > Inspired by a patch in the BSP by Koji Matsuoka
> > <koji.matsuoka.xm@renesas.com>.
> > 
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > v2:
> >   - Do not clear clock source bits, since the serial console relies on
> >     them, as reported by Shimoda-san.
> > 
> > v1 was extracted from "[PATCH/RFC v3 0/4] serial: sh-sci: Add DT DMA
> > support".  The issues with the serial console seen before on
> > r8a7740/armadillo and sh73a0/kzm9g seem to be gone.  Changes after
> > resurrection:
> >   - Write zero to also disable related interrupts, as suggested by
> >     Laurent Pinchart,
> >   - Enhanced patch description.
> > ---
> >  drivers/tty/serial/sh-sci.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> 
> This patch does not apply to my tree :(

But I don't have access to my 2-factor token for about 24 hours, so my
tree will not be public until after then, sorry about that, I'll email
you when it gets synced up to kernel.org...

greg k-h

  reply	other threads:[~2016-06-25 16:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-24 14:59 [PATCH v2 0/4] serial: sh-sci: FIFO initialization fixes Geert Uytterhoeven
2016-06-24 14:59 ` Geert Uytterhoeven
2016-06-24 14:59 ` [PATCH v2 1/4] serial: sh-sci: Do not start transfers from sci_startup() Geert Uytterhoeven
2016-06-24 14:59   ` Geert Uytterhoeven
2016-06-24 14:59 ` [PATCH v2 2/4] serial: sh-sci: Stop transfers in sci_shutdown() Geert Uytterhoeven
2016-06-24 14:59   ` Geert Uytterhoeven
2016-06-25 16:09   ` Greg Kroah-Hartman
2016-06-25 16:09     ` Greg Kroah-Hartman
2016-06-25 16:10     ` Greg Kroah-Hartman [this message]
2016-06-25 16:10       ` Greg Kroah-Hartman
2016-06-25 17:01       ` Greg Kroah-Hartman
2016-06-25 17:01         ` Greg Kroah-Hartman
2016-06-24 14:59 ` [PATCH v2 3/4] serial: sh-sci: Clear RX, error, and break flags during reset Geert Uytterhoeven
2016-06-24 14:59   ` Geert Uytterhoeven
2016-06-24 14:59 ` [PATCH v2 4/4] serial: sh-sci: Clear (H)SCIF timeout and overrun " Geert Uytterhoeven
2016-06-24 14:59   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160625161051.GA30995@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=damm+renesas@opensource.se \
    --cc=geert+renesas@glider.be \
    --cc=jslaby@suse.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=uclinux-h8-devel@lists.sourceforge.jp \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.