From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Mark Brown <broonie@kernel.org>, Lee Jones <lee.jones@linaro.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH v3 5/8] rtc: ac100: Add clk output support
Date: Sun, 26 Jun 2016 02:45:57 +0200 [thread overview]
Message-ID: <20160626004557.GX5809@piout.net> (raw)
In-Reply-To: <1466391138-12862-6-git-send-email-wens@csie.org>
On 20/06/2016 at 10:52:15 +0800, Chen-Yu Tsai wrote :
> +struct ac100_clk32k {
> + struct clk_hw hw;
> + struct regmap *regmap;
> + u8 offset;
> +};
> +
> +#define to_ac100_clk32k(_hw) container_of(_hw, struct ac100_clk32k, hw)
> +
> +#define AC100_RTC_32K_NAME "ac100-rtc-32k"
> +#define AC100_RTC_32K_RATE 32768
> +#define AC100_ADDA_4M_NAME "ac100-adda-4M"
> +#define AC100_ADDA_4M_RATE 4000000
> +#define AC100_CLK32K_NUM 3
> +
> +static const char * const ac100_clk32k_names[] = {
> + "ac100-clk32k-ap",
> + "ac100-clk32k-bb",
> + "ac100-clk32k-md",
> +};
> +
Well, naming things is hard but I don't feel ac100_clk32k and
ac100-clk32k are good prefixes for those clocks as they are actually
dividing a 32KHz or 4MHz clock (one configuration out of 128 is 32KHz).
Else, I don't have any objection.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Mark Brown <broonie@kernel.org>, Lee Jones <lee.jones@linaro.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org
Subject: [rtc-linux] Re: [PATCH v3 5/8] rtc: ac100: Add clk output support
Date: Sun, 26 Jun 2016 02:45:57 +0200 [thread overview]
Message-ID: <20160626004557.GX5809@piout.net> (raw)
In-Reply-To: <1466391138-12862-6-git-send-email-wens@csie.org>
On 20/06/2016 at 10:52:15 +0800, Chen-Yu Tsai wrote :
> +struct ac100_clk32k {
> + struct clk_hw hw;
> + struct regmap *regmap;
> + u8 offset;
> +};
> +
> +#define to_ac100_clk32k(_hw) container_of(_hw, struct ac100_clk32k, hw)
> +
> +#define AC100_RTC_32K_NAME "ac100-rtc-32k"
> +#define AC100_RTC_32K_RATE 32768
> +#define AC100_ADDA_4M_NAME "ac100-adda-4M"
> +#define AC100_ADDA_4M_RATE 4000000
> +#define AC100_CLK32K_NUM 3
> +
> +static const char * const ac100_clk32k_names[] = {
> + "ac100-clk32k-ap",
> + "ac100-clk32k-bb",
> + "ac100-clk32k-md",
> +};
> +
Well, naming things is hard but I don't feel ac100_clk32k and
ac100-clk32k are good prefixes for those clocks as they are actually
dividing a 32KHz or 4MHz clock (one configuration out of 128 is 32KHz).
Else, I don't have any objection.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 5/8] rtc: ac100: Add clk output support
Date: Sun, 26 Jun 2016 02:45:57 +0200 [thread overview]
Message-ID: <20160626004557.GX5809@piout.net> (raw)
In-Reply-To: <1466391138-12862-6-git-send-email-wens@csie.org>
On 20/06/2016 at 10:52:15 +0800, Chen-Yu Tsai wrote :
> +struct ac100_clk32k {
> + struct clk_hw hw;
> + struct regmap *regmap;
> + u8 offset;
> +};
> +
> +#define to_ac100_clk32k(_hw) container_of(_hw, struct ac100_clk32k, hw)
> +
> +#define AC100_RTC_32K_NAME "ac100-rtc-32k"
> +#define AC100_RTC_32K_RATE 32768
> +#define AC100_ADDA_4M_NAME "ac100-adda-4M"
> +#define AC100_ADDA_4M_RATE 4000000
> +#define AC100_CLK32K_NUM 3
> +
> +static const char * const ac100_clk32k_names[] = {
> + "ac100-clk32k-ap",
> + "ac100-clk32k-bb",
> + "ac100-clk32k-md",
> +};
> +
Well, naming things is hard but I don't feel ac100_clk32k and
ac100-clk32k are good prefixes for those clocks as they are actually
dividing a 32KHz or 4MHz clock (one configuration out of 128 is 32KHz).
Else, I don't have any objection.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Alessandro Zummo
<a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Michael Turquette
<mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 5/8] rtc: ac100: Add clk output support
Date: Sun, 26 Jun 2016 02:45:57 +0200 [thread overview]
Message-ID: <20160626004557.GX5809@piout.net> (raw)
In-Reply-To: <1466391138-12862-6-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
On 20/06/2016 at 10:52:15 +0800, Chen-Yu Tsai wrote :
> +struct ac100_clk32k {
> + struct clk_hw hw;
> + struct regmap *regmap;
> + u8 offset;
> +};
> +
> +#define to_ac100_clk32k(_hw) container_of(_hw, struct ac100_clk32k, hw)
> +
> +#define AC100_RTC_32K_NAME "ac100-rtc-32k"
> +#define AC100_RTC_32K_RATE 32768
> +#define AC100_ADDA_4M_NAME "ac100-adda-4M"
> +#define AC100_ADDA_4M_RATE 4000000
> +#define AC100_CLK32K_NUM 3
> +
> +static const char * const ac100_clk32k_names[] = {
> + "ac100-clk32k-ap",
> + "ac100-clk32k-bb",
> + "ac100-clk32k-md",
> +};
> +
Well, naming things is hard but I don't feel ac100_clk32k and
ac100-clk32k are good prefixes for those clocks as they are actually
dividing a 32KHz or 4MHz clock (one configuration out of 128 is 32KHz).
Else, I don't have any objection.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2016-06-26 0:45 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 2:52 [PATCH v3 0/8] mfd: ac100: Add support for X-Powers AC100 audio codec / RTC combo IC Chen-Yu Tsai
2016-06-20 2:52 ` Chen-Yu Tsai
2016-06-20 2:52 ` Chen-Yu Tsai
2016-06-20 2:52 ` [rtc-linux] " Chen-Yu Tsai
2016-06-20 2:52 ` [PATCH v3 1/8] regmap: Support bulk writes for devices without raw formatting Chen-Yu Tsai
2016-06-20 2:52 ` Chen-Yu Tsai
2016-06-20 2:52 ` Chen-Yu Tsai
2016-06-20 2:52 ` [rtc-linux] " Chen-Yu Tsai
2016-06-20 2:52 ` [PATCH v3 2/8] mfd: ac100: Add device tree bindings for X-Powers AC100 codec/RTC combo IC Chen-Yu Tsai
2016-06-20 2:52 ` Chen-Yu Tsai
2016-06-20 2:52 ` Chen-Yu Tsai
2016-06-20 2:52 ` [rtc-linux] " Chen-Yu Tsai
2016-06-21 13:14 ` Rob Herring
2016-06-21 13:14 ` Rob Herring
2016-06-21 13:14 ` Rob Herring
2016-06-21 13:14 ` [rtc-linux] " Rob Herring
2016-06-22 4:16 ` Chen-Yu Tsai
2016-06-22 4:16 ` Chen-Yu Tsai
2016-06-22 4:16 ` Chen-Yu Tsai
2016-06-22 4:16 ` [rtc-linux] " Chen-Yu Tsai
2016-06-20 2:52 ` [PATCH v3 3/8] mfd: ac100: Add driver for X-Powers AC100 audio codec / RTC " Chen-Yu Tsai
2016-06-20 2:52 ` Chen-Yu Tsai
2016-06-20 2:52 ` Chen-Yu Tsai
2016-06-20 2:52 ` [rtc-linux] " Chen-Yu Tsai
2016-06-20 2:52 ` [PATCH v3 4/8] rtc: ac100: Add RTC driver for X-Powers AC100 Chen-Yu Tsai
2016-06-20 2:52 ` Chen-Yu Tsai
2016-06-20 2:52 ` Chen-Yu Tsai
2016-06-20 2:52 ` [rtc-linux] " Chen-Yu Tsai
2016-06-26 0:30 ` Alexandre Belloni
2016-06-26 0:30 ` Alexandre Belloni
2016-06-26 0:30 ` Alexandre Belloni
2016-06-26 0:30 ` [rtc-linux] " Alexandre Belloni
2016-06-26 14:54 ` Chen-Yu Tsai
2016-06-26 14:54 ` Chen-Yu Tsai
2016-06-26 14:54 ` Chen-Yu Tsai
2016-06-26 14:54 ` [rtc-linux] " Chen-Yu Tsai
2016-06-26 1:02 ` Alexandre Belloni
2016-06-26 1:02 ` Alexandre Belloni
2016-06-26 1:02 ` Alexandre Belloni
2016-06-26 1:02 ` [rtc-linux] " Alexandre Belloni
2016-06-20 2:52 ` [PATCH v3 5/8] rtc: ac100: Add clk output support Chen-Yu Tsai
2016-06-20 2:52 ` Chen-Yu Tsai
2016-06-20 2:52 ` Chen-Yu Tsai
2016-06-20 2:52 ` [rtc-linux] " Chen-Yu Tsai
2016-06-22 10:02 ` Maxime Ripard
2016-06-22 10:02 ` Maxime Ripard
2016-06-22 10:02 ` Maxime Ripard
2016-06-22 10:02 ` [rtc-linux] " Maxime Ripard
2016-06-22 10:11 ` Chen-Yu Tsai
2016-06-22 10:11 ` Chen-Yu Tsai
2016-06-22 10:11 ` Chen-Yu Tsai
2016-06-22 10:11 ` [rtc-linux] " Chen-Yu Tsai
2016-06-27 19:23 ` Maxime Ripard
2016-06-27 19:23 ` Maxime Ripard
2016-06-27 19:23 ` Maxime Ripard
2016-06-27 19:23 ` [rtc-linux] " Maxime Ripard
2016-06-28 2:27 ` Chen-Yu Tsai
2016-06-28 2:27 ` Chen-Yu Tsai
2016-06-28 2:27 ` Chen-Yu Tsai
2016-06-28 2:27 ` [rtc-linux] " Chen-Yu Tsai
2016-06-26 0:45 ` Alexandre Belloni [this message]
2016-06-26 0:45 ` Alexandre Belloni
2016-06-26 0:45 ` Alexandre Belloni
2016-06-26 0:45 ` [rtc-linux] " Alexandre Belloni
2016-06-26 14:58 ` Chen-Yu Tsai
2016-06-26 14:58 ` Chen-Yu Tsai
2016-06-26 14:58 ` [rtc-linux] " Chen-Yu Tsai
2016-06-20 2:52 ` [PATCH v3 6/8] ARM: dts: sun9i: a80-optimus: Add device node for AC100 Chen-Yu Tsai
2016-06-20 2:52 ` Chen-Yu Tsai
2016-06-20 2:52 ` Chen-Yu Tsai
2016-06-20 2:52 ` [rtc-linux] " Chen-Yu Tsai
2016-06-20 2:52 ` [PATCH v3 7/8] ARM: dts: sun9i: cubieboard4: " Chen-Yu Tsai
2016-06-20 2:52 ` Chen-Yu Tsai
2016-06-20 2:52 ` Chen-Yu Tsai
2016-06-20 2:52 ` [rtc-linux] " Chen-Yu Tsai
2016-06-20 2:52 ` [PATCH v3 8/8] ARM: dts: sun9i: Switch to the AC100 RTC clock outputs for osc32k Chen-Yu Tsai
2016-06-20 2:52 ` Chen-Yu Tsai
2016-06-20 2:52 ` Chen-Yu Tsai
2016-06-20 2:52 ` [rtc-linux] " Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160626004557.GX5809@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=mturquette@baylibre.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=sboyd@codeaurora.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.