All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: lkp@lists.01.org
Subject: Re: [dcache_{readdir, dir_lseek}() users] 4e82901cd6: reaim.jobs_per_min -49.1% regression
Date: Sun, 26 Jun 2016 19:06:04 +0100	[thread overview]
Message-ID: <20160626180604.GW14480@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CA+55aFyxRDs6uC=ppoSyf_zLOd3NP-uEKgOKZSNh5papGrszPg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 791 bytes --]

On Sun, Jun 26, 2016 at 10:13:32AM -0700, Linus Torvalds wrote:
> On Sun, Jun 26, 2016 at 2:50 AM, Thorsten Leemhuis
> <regressions@leemhuis.info> wrote:
> >
> > Al, what's the status here? This made it on my 4.7 regressions report
> > due to the "regression" keyword in the subject.
> 
> I don't think the tmpfs locking is going to get changed for 4.7. This
> issue will likely only show up for some very specific microbenchmarks,
> and the lockless next_positive one is likely too invasive for this
> stage. So the problem is fixable, and not serious enough to worry
> about for 4.7.

FWIW, #work.dcache_readdir in vfs.git seems to recover the performance.
Not sure if it's worth pushing right now, but if it ends up the next
cycle stuff, I think it'll be worth Cc:stable.

WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Thorsten Leemhuis <regressions@leemhuis.info>,
	"Huang, Ying" <ying.huang@intel.com>, LKP <lkp@01.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [LKP] [lkp] [dcache_{readdir, dir_lseek}() users] 4e82901cd6: reaim.jobs_per_min -49.1% regression
Date: Sun, 26 Jun 2016 19:06:04 +0100	[thread overview]
Message-ID: <20160626180604.GW14480@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CA+55aFyxRDs6uC=ppoSyf_zLOd3NP-uEKgOKZSNh5papGrszPg@mail.gmail.com>

On Sun, Jun 26, 2016 at 10:13:32AM -0700, Linus Torvalds wrote:
> On Sun, Jun 26, 2016 at 2:50 AM, Thorsten Leemhuis
> <regressions@leemhuis.info> wrote:
> >
> > Al, what's the status here? This made it on my 4.7 regressions report
> > due to the "regression" keyword in the subject.
> 
> I don't think the tmpfs locking is going to get changed for 4.7. This
> issue will likely only show up for some very specific microbenchmarks,
> and the lockless next_positive one is likely too invasive for this
> stage. So the problem is fixable, and not serious enough to worry
> about for 4.7.

FWIW, #work.dcache_readdir in vfs.git seems to recover the performance.
Not sure if it's worth pushing right now, but if it ends up the next
cycle stuff, I think it'll be worth Cc:stable.

  reply	other threads:[~2016-06-26 18:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31  8:15 [dcache_{readdir, dir_lseek}() users] 4e82901cd6: reaim.jobs_per_min -49.1% regression kernel test robot
2016-05-31  8:15 ` [lkp] [dcache_{readdir,dir_lseek}() " kernel test robot
2016-05-31 13:40 ` [dcache_{readdir, dir_lseek}() " Al Viro
2016-05-31 13:40   ` [lkp] [dcache_{readdir,dir_lseek}() " Al Viro
2016-06-01  1:03   ` [dcache_{readdir, dir_lseek}() " Huang, Ying
2016-06-01  1:03     ` [LKP] [lkp] " Huang, Ying
2016-06-02  6:28     ` Huang, Ying
2016-06-02  6:28       ` [LKP] [lkp] " Huang, Ying
2016-06-02 16:29       ` Al Viro
2016-06-02 16:29         ` [LKP] [lkp] " Al Viro
2016-06-26  9:50         ` Thorsten Leemhuis
2016-06-26 17:13           ` Linus Torvalds
2016-06-26 17:13             ` [LKP] [lkp] " Linus Torvalds
2016-06-26 18:06             ` Al Viro [this message]
2016-06-26 18:06               ` Al Viro
2016-06-26 21:20               ` Linus Torvalds
2016-06-26 21:20                 ` [LKP] [lkp] " Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160626180604.GW14480@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=lkp@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.