* re: b43: update cordic code to match current specs
@ 2016-06-27 13:40 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2016-06-27 13:40 UTC (permalink / raw)
To: zajec5; +Cc: linux-wireless, b43-dev
Hello Rafał Miłecki,
The patch 6f98e62a9f1b: "b43: update cordic code to match current
specs" from Jan 25, 2010, leads to the following static checker
warning:
drivers/net/wireless/broadcom/b43/phy_lp.c:1803 lpphy_start_tx_tone()
warn: mask and shift to zero
drivers/net/wireless/broadcom/b43/phy_lp.c
1800 for (i = 0; i < samples; i++) {
1801 sample = b43_cordic(angle);
1802 angle += rotation;
1803 buf[i] = CORDIC_CONVERT((sample.i * max) & 0xFF) << 8;
1804 buf[i] |= CORDIC_CONVERT((sample.q * max) & 0xFF);
The CORDIC_CONVERT() macro is a bit complicated but I made a small test
program to see how it worked and I believe it just sets buf[i] to zero.
1805 }
1806
1807 b43_lptab_write_bulk(dev, B43_LPTAB16(5, 0), samples, buf);
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-06-27 13:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-27 13:40 b43: update cordic code to match current specs Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.