From: Alex Riesen <alexander.riesen@cetitec.com>
To: "Jakub Narębski" <jnareb@gmail.com>
Cc: <git@vger.kernel.org>,
Pat Thoyts <patthoyts@users.sourceforge.net>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] Ensure the file in the diff pane is always in the list of selected files
Date: Tue, 28 Jun 2016 10:03:40 +0200 [thread overview]
Message-ID: <20160628080340.GA3710@pflmari> (raw)
In-Reply-To: <57716329.8000809@gmail.com>
Jakub Narębski, Mon, Jun 27, 2016 19:32:25 +0200:
> W dniu 2016-06-27 o 15:23, Alex Riesen pisze:
> > It is very confusing that the file, diff of which is displayed and which is
> > marked as selected in the file list, is not, in fact, selected. I.e. the array
> > of selected files does not contain an entry for it.
> >
> > Fixing this also improves the use of $FILENAMES in custom defined tools: one
> > does not have to click the file in the list to make it selected.
>
> Could you improve the readability of the commit message, please? Perhaps
> something like the following:
>
> It is very confusing that the file which diff is displayed is marked as
> selected, but it is not in fact selected (that means the array of selected
> files does not include the file in question).
>
> ...
>
> This patch lacks sign-off.
>
Done. Also the prefix.
---
Diese E-Mail wurde von Avast Antivirus-Software auf Viren geprüft.
https://www.avast.com/antivirus
next prev parent reply other threads:[~2016-06-28 8:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 13:21 [PATCH 1/2] Support for $FILENAMES in tool definitions Alex Riesen
2016-06-27 13:23 ` [PATCH 2/2] Ensure the file in the diff pane is always in the list of selected files Alex Riesen
2016-06-27 17:32 ` Jakub Narębski
2016-06-28 8:03 ` Alex Riesen [this message]
2016-06-27 15:49 ` [PATCH 1/2] Support for $FILENAMES in tool definitions Johannes Schindelin
2016-06-28 8:04 ` Alex Riesen
2016-06-27 17:28 ` Jakub Narębski
2016-06-27 17:53 ` Junio C Hamano
2016-06-27 18:09 ` Jakub Narębski
2016-06-28 8:54 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160628080340.GA3710@pflmari \
--to=alexander.riesen@cetitec.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=patthoyts@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.