All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Jakub Narębski" <jnareb@gmail.com>
Cc: Alex Riesen <alexander.riesen@cetitec.com>,
	git@vger.kernel.org, Pat Thoyts <patthoyts@users.sourceforge.net>
Subject: Re: [PATCH 1/2] Support for $FILENAMES in tool definitions
Date: Mon, 27 Jun 2016 10:53:24 -0700	[thread overview]
Message-ID: <xmqq7fdabjsb.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <57716227.1030104@gmail.com> ("Jakub Narębski"'s message of "Mon, 27 Jun 2016 19:28:07 +0200")

Jakub Narębski <jnareb@gmail.com> writes:

> On 2016-06-27, Alex Riesen wrote:
>
>> This adds a FILENAMES environment variable, which contains the repository
>> pathnames of all selected files the list.
>> The variable contains the names separated by spaces.
>
> Why not separate filenames with end-of-line character (LF)? It would still
> be broken for some filenames, but only for unportable ones.  Filenames with
> internal space (common on MS Windows) would work then.
>
>   http://www.dwheeler.com/essays/filenames-in-shell.html
>  
> If Tcl allows it, you could separate filenames in FILENAMES environment
> variable with NUL ("\0") character...

Tcl may or may not handle a string with an embedded NUL, but I think
it is hard to have an embedded NUL in an environment variable.

Use of LF is a good suggestion regardless.


  reply	other threads:[~2016-06-27 17:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-27 13:21 [PATCH 1/2] Support for $FILENAMES in tool definitions Alex Riesen
2016-06-27 13:23 ` [PATCH 2/2] Ensure the file in the diff pane is always in the list of selected files Alex Riesen
2016-06-27 17:32   ` Jakub Narębski
2016-06-28  8:03     ` Alex Riesen
2016-06-27 15:49 ` [PATCH 1/2] Support for $FILENAMES in tool definitions Johannes Schindelin
2016-06-28  8:04   ` Alex Riesen
2016-06-27 17:28 ` Jakub Narębski
2016-06-27 17:53   ` Junio C Hamano [this message]
2016-06-27 18:09     ` Jakub Narębski
2016-06-28  8:54   ` Alex Riesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7fdabjsb.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=alexander.riesen@cetitec.com \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=patthoyts@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.