From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: <dev@dpdk.org>, <bruce.richardson@intel.com>,
<jianbo.liu@linaro.org>, <huawei.xie@intel.com>,
<yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH 2/4] virtio: introduce RTE_LIBRTE_VIRTIO_INC_VECTOR
Date: Wed, 29 Jun 2016 17:10:31 +0530 [thread overview]
Message-ID: <20160629114030.GC5301@localhost.localdomain> (raw)
In-Reply-To: <6020070.DOjM99b0E6@xps13>
On Wed, Jun 29, 2016 at 01:25:35PM +0200, Thomas Monjalon wrote:
> 2016-06-29 16:48, Jerin Jacob:
> > On Mon, Jun 27, 2016 at 04:59:42PM +0200, Thomas Monjalon wrote:
> > > 2016-06-27 20:18, Jerin Jacob:
> > > > On Mon, Jun 27, 2016 at 04:19:57PM +0200, Thomas Monjalon wrote:
> > > > > 2016-06-27 17:24, Jerin Jacob:
> > > > > > --- a/config/common_base
> > > > > > +++ b/config/common_base
> > > > > > @@ -267,6 +267,7 @@ CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_RX=n
> > > > > > CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_TX=n
> > > > > > CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DRIVER=n
> > > > > > CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DUMP=n
> > > > > > +CONFIG_RTE_LIBRTE_VIRTIO_INC_VECTOR=y
> > > > >
> > > > > I don't remember what means INC_VECTOR?
> > > > > Why a config option is needed for vector implementations?
> > > >
> > > > I thought of adding additional configuration option(INC_VECTOR) _apart_ from
> > > > cpu flag based scheme in the patch because even though if a given platform
> > > > has cpu instruction support, in some platforms scalar version may
> > > > perform well wrt vector version(based on instruction latency, emulation required or not
> > > > etc). So a top level flag INC_VECTOR, can override the vector selection
> > > > for a given platform if required.
> > >
> > > Isn't it a runtime driver option needed to disable vector virtio?
> > >
> > > > Regarding INC_VECTOR(INC in vector configuration name, I have no idea, I
> > > > followed the existing flags)
> > > > $ grep "INC_VECTOR" config/common_base
> > > > CONFIG_RTE_IXGBE_INC_VECTOR=y
> > > > CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=y
> > > > CONFIG_RTE_LIBRTE_FM10K_INC_VECTOR=y
> > >
> > > If the flag is really needed I would suggest VIRTIO_VECTOR.
> >
> > OK I will change to VIRTIO_VECTOR
>
> I would prefer a runtime option.
OK
The platform I test their was NO need for additional VIRTIO_VECTOR
configuration as NEON versions outperforms than scalar version.
I thought of adding this option to override for any platform if it need
to accommodate such platform differences NEON vs scalar versions.
I will change completely to run-time detection based on cpuflags for IA and ARM.
Any objections?
Jerin
next prev parent reply other threads:[~2016-06-29 11:40 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 11:54 [PATCH 0/4] Virtio NEON support for ARM Jerin Jacob
2016-06-27 11:54 ` [PATCH 1/4] virtio: Fix compile time dependency of use_simple_rxtx usage Jerin Jacob
2016-06-27 11:54 ` [PATCH 2/4] virtio: introduce RTE_LIBRTE_VIRTIO_INC_VECTOR Jerin Jacob
2016-06-27 14:19 ` Thomas Monjalon
2016-06-27 14:48 ` Jerin Jacob
2016-06-27 14:59 ` Thomas Monjalon
2016-06-29 11:18 ` Jerin Jacob
2016-06-29 11:25 ` Thomas Monjalon
2016-06-29 11:40 ` Jerin Jacob [this message]
2016-06-30 5:44 ` Yuanhan Liu
2016-06-27 11:54 ` [PATCH 3/4] virtio: move SSE based Rx implementation to separate file Jerin Jacob
2016-06-28 6:17 ` Jianbo Liu
2016-06-29 11:27 ` Jerin Jacob
2016-06-30 5:43 ` Yuanhan Liu
2016-06-27 11:54 ` [PATCH 4/4] virtio: add neon support Jerin Jacob
2016-07-01 11:16 ` From: Jerin Jacob <jerin.jacob@caviumnetworks.com> Jerin Jacob
2016-07-01 11:16 ` [PATCH v2 1/3] virtio: conditional compilation cleanup Jerin Jacob
2016-07-04 7:36 ` Yuanhan Liu
2016-07-04 8:36 ` Jerin Jacob
2016-07-04 8:42 ` Yuanhan Liu
2016-07-04 9:07 ` Jerin Jacob
2016-07-04 11:02 ` Yuanhan Liu
2016-07-04 12:15 ` Jerin Jacob
2016-07-04 12:26 ` Yuanhan Liu
2016-07-04 12:50 ` Jerin Jacob
2016-07-04 12:57 ` Yuanhan Liu
2016-07-01 11:16 ` [PATCH v2 2/3] virtio: move SSE based Rx implementation to separate file Jerin Jacob
2016-07-04 7:42 ` Yuanhan Liu
2016-07-04 8:38 ` Jerin Jacob
2016-07-01 11:16 ` [PATCH v2 3/3] virtio: add neon support Jerin Jacob
2016-07-04 7:53 ` Yuanhan Liu
2016-07-04 8:55 ` Jerin Jacob
2016-07-04 9:02 ` Yuanhan Liu
2016-07-05 12:49 ` [PATCH v3 0/4] Virtio NEON support for ARM Jerin Jacob
2016-07-05 12:49 ` [PATCH v3 1/4] virtio: conditional compilation cleanup Jerin Jacob
2016-07-05 12:49 ` [PATCH v3 2/4] virtio: move SSE based Rx implementation to separate file Jerin Jacob
2016-08-18 6:52 ` Yuanhan Liu
2016-08-19 3:24 ` Jerin Jacob
2016-08-23 7:43 ` Yuanhan Liu
2016-07-05 12:49 ` [PATCH v3 3/4] virtio: add cpuflag based vector handler selection Jerin Jacob
2016-07-05 12:49 ` [PATCH v3 4/4] virtio: add neon support Jerin Jacob
2016-07-06 3:11 ` Jianbo Liu
2016-09-28 0:37 ` [PATCH v3 0/4] Virtio NEON support for ARM Yuanhan Liu
2016-07-01 11:19 ` [PATCH v2 0/3] " Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160629114030.GC5301@localhost.localdomain \
--to=jerin.jacob@caviumnetworks.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=jianbo.liu@linaro.org \
--cc=thomas.monjalon@6wind.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.