All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: dev@dpdk.org, thomas.monjalon@6wind.com,
	bruce.richardson@intel.com, jianbo.liu@linaro.org,
	huawei.xie@intel.com
Subject: Re: [PATCH v2 1/3] virtio: conditional compilation cleanup
Date: Mon, 4 Jul 2016 20:57:15 +0800	[thread overview]
Message-ID: <20160704125715.GF26521@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <20160704125041.GA6532@localhost.localdomain>

On Mon, Jul 04, 2016 at 06:20:42PM +0530, Jerin Jacob wrote:
> > > The former case will have issue as "hw" been used in "if" with vtpci_with_feature.
> > 
> > Oh, my bad. I overlooked it. Sorry for that!
> > 
> > > OR
> > > 
> > > if you meant just floating "struct virtio_hw *hw" without RTE_MACHINE_CPUFLAG_SSSE3
> > > then it comes error on non x86 as unused "hw" variable.
> > > 
> > > If you meant something else then let me know?
> > 
> > I then prefer to keep the "#ifdef .. #endif" on top then. It will stop
> > us from offending a minor rule, while you can remove the ugly "#ifdef"
> > block in the next patch.
> > 
> > Works to you?
> 
> OK. As you wish :-)

Thank you!

	--yliu

  reply	other threads:[~2016-07-04 12:56 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-27 11:54 [PATCH 0/4] Virtio NEON support for ARM Jerin Jacob
2016-06-27 11:54 ` [PATCH 1/4] virtio: Fix compile time dependency of use_simple_rxtx usage Jerin Jacob
2016-06-27 11:54 ` [PATCH 2/4] virtio: introduce RTE_LIBRTE_VIRTIO_INC_VECTOR Jerin Jacob
2016-06-27 14:19   ` Thomas Monjalon
2016-06-27 14:48     ` Jerin Jacob
2016-06-27 14:59       ` Thomas Monjalon
2016-06-29 11:18         ` Jerin Jacob
2016-06-29 11:25           ` Thomas Monjalon
2016-06-29 11:40             ` Jerin Jacob
2016-06-30  5:44               ` Yuanhan Liu
2016-06-27 11:54 ` [PATCH 3/4] virtio: move SSE based Rx implementation to separate file Jerin Jacob
2016-06-28  6:17   ` Jianbo Liu
2016-06-29 11:27     ` Jerin Jacob
2016-06-30  5:43       ` Yuanhan Liu
2016-06-27 11:54 ` [PATCH 4/4] virtio: add neon support Jerin Jacob
2016-07-01 11:16 ` From: Jerin Jacob <jerin.jacob@caviumnetworks.com> Jerin Jacob
2016-07-01 11:16   ` [PATCH v2 1/3] virtio: conditional compilation cleanup Jerin Jacob
2016-07-04  7:36     ` Yuanhan Liu
2016-07-04  8:36       ` Jerin Jacob
2016-07-04  8:42         ` Yuanhan Liu
2016-07-04  9:07           ` Jerin Jacob
2016-07-04 11:02             ` Yuanhan Liu
2016-07-04 12:15               ` Jerin Jacob
2016-07-04 12:26                 ` Yuanhan Liu
2016-07-04 12:50                   ` Jerin Jacob
2016-07-04 12:57                     ` Yuanhan Liu [this message]
2016-07-01 11:16   ` [PATCH v2 2/3] virtio: move SSE based Rx implementation to separate file Jerin Jacob
2016-07-04  7:42     ` Yuanhan Liu
2016-07-04  8:38       ` Jerin Jacob
2016-07-01 11:16   ` [PATCH v2 3/3] virtio: add neon support Jerin Jacob
2016-07-04  7:53     ` Yuanhan Liu
2016-07-04  8:55       ` Jerin Jacob
2016-07-04  9:02         ` Yuanhan Liu
2016-07-05 12:49   ` [PATCH v3 0/4] Virtio NEON support for ARM Jerin Jacob
2016-07-05 12:49     ` [PATCH v3 1/4] virtio: conditional compilation cleanup Jerin Jacob
2016-07-05 12:49     ` [PATCH v3 2/4] virtio: move SSE based Rx implementation to separate file Jerin Jacob
2016-08-18  6:52       ` Yuanhan Liu
2016-08-19  3:24         ` Jerin Jacob
2016-08-23  7:43           ` Yuanhan Liu
2016-07-05 12:49     ` [PATCH v3 3/4] virtio: add cpuflag based vector handler selection Jerin Jacob
2016-07-05 12:49     ` [PATCH v3 4/4] virtio: add neon support Jerin Jacob
2016-07-06  3:11       ` Jianbo Liu
2016-09-28  0:37     ` [PATCH v3 0/4] Virtio NEON support for ARM Yuanhan Liu
2016-07-01 11:19 ` [PATCH v2 0/3] " Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160704125715.GF26521@yliu-dev.sh.intel.com \
    --to=yuanhan.liu@linux.intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=huawei.xie@intel.com \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=jianbo.liu@linaro.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.