All of lore.kernel.org
 help / color / mirror / Atom feed
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v11 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support
Date: Thu, 30 Jun 2016 09:56:53 +0530	[thread overview]
Message-ID: <20160630042653.GM14945@localhost> (raw)
In-Reply-To: <1465486667-30737-2-git-send-email-appanad@xilinx.com>

On Thu, Jun 09, 2016 at 09:07:47PM +0530, Kedareswara rao Appana wrote:

> +	dma_set_mask(&pdev->dev, DMA_BIT_MASK(44));
> +	dma_cap_set(DMA_SG, zdev->common.cap_mask);
> +	dma_cap_set(DMA_MEMCPY, zdev->common.cap_mask);
 
>  /**
> + * struct zynqmp_dma_config - ZYNQMP DMA Configuration structure
> + * @ovrfetch: Overfetch status
> + * @has_sg: Support scatter gather transfers
> + * @ratectrl: Rate control value
> + * @src_issue: Out standing transactions on source
> + * @src_burst_len: Source burst length
> + * @dst_burst_len: Dest burst length
> + */

As discussed in other thread as well, this is no-go for memcpy. Please come
back after removing this

For slave usages use the dma_slave_config

-- 
~Vinod

WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Kedareswara rao Appana <appana.durga.rao@xilinx.com>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	michal.simek@xilinx.com, soren.brinkmann@xilinx.com,
	dan.j.williams@intel.com, appanad@xilinx.com,
	moritz.fischer@ettus.com, laurent.pinchart@ideasonboard.com,
	luis@debethencourt.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
	Punnaiah Choudary Kalluri <punnaia@xilinx.com>
Subject: Re: [PATCH v11 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support
Date: Thu, 30 Jun 2016 09:56:53 +0530	[thread overview]
Message-ID: <20160630042653.GM14945@localhost> (raw)
In-Reply-To: <1465486667-30737-2-git-send-email-appanad@xilinx.com>

On Thu, Jun 09, 2016 at 09:07:47PM +0530, Kedareswara rao Appana wrote:

> +	dma_set_mask(&pdev->dev, DMA_BIT_MASK(44));
> +	dma_cap_set(DMA_SG, zdev->common.cap_mask);
> +	dma_cap_set(DMA_MEMCPY, zdev->common.cap_mask);
 
>  /**
> + * struct zynqmp_dma_config - ZYNQMP DMA Configuration structure
> + * @ovrfetch: Overfetch status
> + * @has_sg: Support scatter gather transfers
> + * @ratectrl: Rate control value
> + * @src_issue: Out standing transactions on source
> + * @src_burst_len: Source burst length
> + * @dst_burst_len: Dest burst length
> + */

As discussed in other thread as well, this is no-go for memcpy. Please come
back after removing this

For slave usages use the dma_slave_config

-- 
~Vinod

  reply	other threads:[~2016-06-30  4:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-09 15:37 [PATCH v11 1/2] Documentation: DT: dma: Add Xilinx zynqmp dma device tree binding documentation Kedareswara rao Appana
2016-06-09 15:37 ` Kedareswara rao Appana
2016-06-09 15:37 ` Kedareswara rao Appana
2016-06-09 15:37 ` [PATCH v11 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support Kedareswara rao Appana
2016-06-09 15:37   ` Kedareswara rao Appana
2016-06-09 15:37   ` Kedareswara rao Appana
2016-06-30  4:26   ` Vinod Koul [this message]
2016-06-30  4:26     ` Vinod Koul
2016-06-30  5:23     ` Appana Durga Kedareswara Rao
2016-06-30  5:23       ` Appana Durga Kedareswara Rao
2016-06-30  5:23       ` Appana Durga Kedareswara Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160630042653.GM14945@localhost \
    --to=vinod.koul@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.